From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4E5C433DF for ; Wed, 12 Aug 2020 12:16:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 486E9207DA for ; Wed, 12 Aug 2020 12:16:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 486E9207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A72426B00B4; Wed, 12 Aug 2020 08:16:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A244D6B00B5; Wed, 12 Aug 2020 08:16:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 913DB6B00B6; Wed, 12 Aug 2020 08:16:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 7D27F6B00B4 for ; Wed, 12 Aug 2020 08:16:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DAFF3181AEF15 for ; Wed, 12 Aug 2020 12:16:51 +0000 (UTC) X-FDA: 77141815422.07.idea79_0d0afc526feb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id D99671803F9A9 for ; Wed, 12 Aug 2020 12:16:49 +0000 (UTC) X-HE-Tag: idea79_0d0afc526feb X-Filterd-Recvd-Size: 3389 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 12:16:46 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R751e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0U5ZBL.H_1597234598; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U5ZBL.H_1597234598) by smtp.aliyun-inc.com(127.0.0.1); Wed, 12 Aug 2020 20:16:39 +0800 Subject: Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction From: Alex Shi To: Alexander Duyck Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <1595681998-19193-15-git-send-email-alex.shi@linux.alibaba.com> <241ca157-104f-4f0d-7d5b-de394443788d@linux.alibaba.com> <8dbd004e-8eba-f1ec-a5eb-5dc551978936@linux.alibaba.com> <9581db48-cef3-788a-7f5a-8548fee56c13@linux.alibaba.com> Message-ID: <51249892-632b-4aaf-1f66-3bc0d5c5cbab@linux.alibaba.com> Date: Wed, 12 Aug 2020 20:16:06 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9581db48-cef3-788a-7f5a-8548fee56c13@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: D99671803F9A9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/8/12 =E4=B8=8B=E5=8D=887:43, Alex Shi =E5=86=99=E9=81=93: >>> Sorry, I still can not follow you here. Compound code part is unchang= ed >>> and follow the original logical. So would you like to pose a new code= to >>> see if its works? >> No there are significant changes as you reordered all of the >> operations. Prior to your change the LRU bit was checked, but not >> cleared before testing for PageCompound. Now you are clearing it >> before you are testing if it is a compound page. So if compaction is >> running we will be seeing the pages in the LRU stay put, but the >> compound bit flickering off and on if the compound page is encountered >> with the wrong or NULL lruvec. What I was suggesting is that the > The lruvec could be wrong or NULL here, that is the base stone of whole > patchset. >=20 Sorry for typo. s/could/could not/