From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE876C19F28 for ; Wed, 3 Aug 2022 14:42:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76D0D6B0072; Wed, 3 Aug 2022 10:42:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71C506B0073; Wed, 3 Aug 2022 10:42:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 548348E0001; Wed, 3 Aug 2022 10:42:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 412386B0072 for ; Wed, 3 Aug 2022 10:42:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 091AA1A0780 for ; Wed, 3 Aug 2022 14:42:59 +0000 (UTC) X-FDA: 79758548478.04.1C45343 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf14.hostedemail.com (Postfix) with ESMTP id 5A2C9100122 for ; Wed, 3 Aug 2022 14:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659537778; x=1691073778; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=bWXAG20qMKmiAafDQffJfBASWs9HLLQfPoZngmnJq7Y=; b=d0uzDBONxyiH/ZBkFHCxchTM+r0tyMQhg3/g6eZYXnPMwHgCSqZhdzwD lQVquuoAq6Qj++nTuJkB2eLbAuiz4JKGEpxaG2G3UGIf/itvMMFhqMZav RIqGa9zqEpIz0VvycfdLulsW4Bs+sLH+oY1eMoH1XmwWxSuyeyeqo71YM dbHL0APKSQ1v5V9hFVWw1mATZefIO7nu6POl4g/zwQYtoCiuNqFqEE+Gf hBkLMjMLA2mKXd3cSltFoAitKbQGycHUBeFV1Uq7yEp4p0lsZ29F32XIZ 5mTnYt+iT77oNLJ3O/kq1R5L0ETc3qHS+O4z/nytHNjpm0KxJnPmKjCub g==; X-IronPort-AV: E=McAfee;i="6400,9594,10428"; a="290460814" X-IronPort-AV: E=Sophos;i="5.93,214,1654585200"; d="scan'208";a="290460814" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 07:42:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,214,1654585200"; d="scan'208";a="670887020" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 03 Aug 2022 07:42:56 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 3 Aug 2022 07:42:56 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 3 Aug 2022 07:42:56 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 3 Aug 2022 07:42:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ny/2yi+goYKEKvy9oFCRGsiuK+PiEtkd1W/FCkmk8mPGRI3MIKD9Qc/5vDa02nNWzYPW1S2+95N8j8VlY7du+HGrlU/S8mKS8QUWeXxYUhBm/EsRoEN3D3jU2g/fVmz4+flnvdlVnH5XhYjFnvTDjVaZsxBJvpZxXCO8AEYuVQueRLKPCgJ5SB4VA2RjSZq8l5I0uWIeV+/aQsTzTOQEmzEasIXN6RPQ8LMZsvGUgXqrh2Ar3jTMwI+z0917BUDyKu+eXpTnUlqY59ECKL8Vyiks6qtyp0pDL4UO401YyAZom1jpa5lG/ewn5MoR+bypP73ZD3IlZgiutbT+xY567A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ujvj9hEkvp0SCAWevi9ira0caQFYXFrviD+dzXzUPhk=; b=nchWj8ZFmCOCThFLEjGv89+XtM8IK1pG3zD17jVSSHYr0BsETXCNLYt9WXqEQmr6CK/e6cSzsprj7kgQN+pPNqKc2M0+B7ne9vUe4+bYujKvZMUMcHZARwnGeCb1APmJyrSHywKEfdkn52uiPq3uvxQe7es2nzS3C6x17MCSeelXeoR6e+d2ebOgFKafxkbLWJH+sMLLm2L3eB+cPQ7Kc8CPszQzDW02LXaDgRrevQ1rw0E50ZC/SIXPEN8Su4F9a66wIlsckgM7EyIPC0F4pqvRX4acgiDfrXEl3cG08yPQmHO0/nRHT6Byd7t91GTIvQcwDwh+9UPQDyi8zbGMJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by DM6PR11MB4076.namprd11.prod.outlook.com (2603:10b6:5:197::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 3 Aug 2022 14:42:54 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32%3]) with mapi id 15.20.5504.014; Wed, 3 Aug 2022 14:42:54 +0000 Message-ID: <533c3471-b096-5e02-491c-2b70a518e6a5@intel.com> Date: Wed, 3 Aug 2022 22:42:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [RFC PATCH] mm/memory-failure: release private data before split THP Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: "linux-mm@kvack.org" , "linmiaohe@huawei.com" , "willy@infradead.org" , "aaron.lu@intel.com" , "tony.luck@intel.com" , "qiuxu.zhuo@intel.com" References: <20220803025243.155798-1-fengwei.yin@intel.com> <20220803093825.GA3601386@hori.linux.bs1.fc.nec.co.jp> From: "Yin, Fengwei" In-Reply-To: <20220803093825.GA3601386@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR06CA0188.apcprd06.prod.outlook.com (2603:1096:4:1::20) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff23ba54-63e7-4b39-15ed-08da755e72b8 X-MS-TrafficTypeDiagnostic: DM6PR11MB4076:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Wv0LcVfzCSM11M6L0SSCWuvA7DCYURPmlY1C1TD64mGJ8VgykZcJR52tQ05+9uOrWhC7UxBqyo1893Hf4JZ/Tfo4CKu713Aq7v8cxMWaoGA8PvhAatsne/vEdB1quwpN7tAEruFmnlqsI/amTUSzPbRtadYz9UBjNGJy9q0xRL++wrWjT3nNOpAhqU6h7fZIxUUN/NyWaxrRLC8SKsQr4cAlmspeuSJm4Fak0EkGHKrKaHoLXvglDah/dC/PgzZwkL+LmCPl4lDsJKNHyYliKl4C4Fjl3lc6/tIfP9887ivPrCTFEJqaz8N+o17AgZzRhKP2aET+XhB+COTsih2GoMma9jpj1emVb8Wrh2ep+j+rDgHbG1mcOWqnbN+OpEpu/6M4nZX553+ZsGBpp3zUk0+NGemYH+bOu15eJO3l8x63mEMqKTcBGgi+S5QJ0S/Z4mxNldMSjkSG6vYlGqqvKzlhq9LQfu02QFCReNp1EqfdcmxxUaWPSjBe8MSnwbQPhM22iqd6fxUMFFSR4beO+kcc48kP1/m/72Akq1rqEG/QdahDP/qTYg0V33/oRjoWHutOadrQNG+5Yf7bcMHECK4WyrhTVks6oVGDIHlqtxe+60T71UzPrFwAZZQoNBljslE54o/66T7kYQV/dFoqXtv57GUZd8EtpW1mWovwubM3XK3m+MYTgERAlLJXiDRnkaQPhA6ddxSCumYil6/Ye2RmDAXvugv49oBoE7RXzARkW2xYjjKqrFFmwmhN1NATHm1f+eTykDts86043hPKuRuJ5/83iDMWaxYKNzEnuTV/MFsO9U0imtOdN1ODLXGEaAH/PND9YTD1ty/ixuX+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(376002)(136003)(366004)(53546011)(6506007)(83380400001)(41300700001)(86362001)(6666004)(2616005)(38100700002)(107886003)(186003)(26005)(2906002)(6512007)(82960400001)(4326008)(8676002)(36756003)(66556008)(66476007)(66946007)(31686004)(8936002)(54906003)(6486002)(6916009)(31696002)(5660300002)(478600001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3hjaFR1OUExTVJZNDdtUC82K2NFQ1A1SkFFMzhUUnE0d3pRTUJET09lSFZ6?= =?utf-8?B?QTkxL0l1QzQ1ZHZsZ3dKaVQ2Y0hFN0ZFQXN4WXJDUXplL2JTN2FkWjNsUjN2?= =?utf-8?B?dmhsd08rTGlXR0V0SlhDN3IvbUp6VCtmTXlVVUxVbkRaaTZERCtCUTFNYmc0?= =?utf-8?B?WTlXSWpXMkpMcTlXZGh6OCs2c1V3bFJRcFdzUmNkL0RmUmMvRDUvSitManNJ?= =?utf-8?B?ZnFQdTlCeU9TVEQxOGpnTVJwNENORTlQbWk0R0RkVjhTdktzWEhzTHA5Q0Ew?= =?utf-8?B?RUE0UUZRTkY3L0VFR0dScTd4NzFBc1BXd2ZIdWh2NXNRTUtEYnI5MXI0TG12?= =?utf-8?B?Qk1zRWQvdTZUT0VpVGRGUFBVNlRiQ2hOY2xESityVzZmejFhOUtjZDdhVGpp?= =?utf-8?B?TDRWTzh4OUlKcktlbTVCUUhVeWZZZGw3Q3dReXBJZXRJU0xaS2dWTUJkcm1L?= =?utf-8?B?L1QyQVhKRVI5RmlTbkUzbExMdmtiN1lhYnRlbmpETGxLSDJYb1hiN29wUEI5?= =?utf-8?B?L0g1ckVIWCtrRzlqaXRYUG1yS3FIU2tRWTFRQi9FNFJHVEx1SWIvZUZ0d2FQ?= =?utf-8?B?aXM2cWE0UTYrYjhsZDVLWHNRTVpoZ2FlMVVvS0lMWkpJUERiTWhqbG95YzB1?= =?utf-8?B?dXh0b1NiY3BNVFFObjhPdGkvM05MRElrZmFwMGUvNjBoYWdvbmVhMW5sNlRW?= =?utf-8?B?M0dUWGpRRitpbUs3ZEZJWGdqbnJReEdPS2t5bnVFRnJGcW00YnFYU29xcWlj?= =?utf-8?B?cFgyS1dYd09oQWFxR21pVURQMDdRQTNSc2ErQ0RxMytlaGw3UXNObjVJS0tt?= =?utf-8?B?UytqSGFxQi9uSzd1L1RqZjlUY2FZeHZsTVV2VnRSWHNPUXUrVk5NZjdrdkFp?= =?utf-8?B?ZnhsOGhBd3pNUGpUanRoaDY3Smo3Ymx4SVBxSElpc01vcUhsZGEvMGNyQXJq?= =?utf-8?B?NHZpUVdkd3pFUU5jTHFDWHhtV25XSjFNVUtIRW1pWnNlVzA3TjFRZGJCa0FZ?= =?utf-8?B?c0ZsWG81OElRNTBlb29aNXdoNVZMM1NrS3ZkM0o2dEMxY255UmxLRXZWT1hz?= =?utf-8?B?eEY0dllva09qdXNpT1UxU2lZTUE4N0dEaXMwZjA0ellzUXlKUlEwbUluT3pu?= =?utf-8?B?aWtYYXArZjFVOFVJZzFJdmVsRnk4WWJYc0MrelNWSkJsdFlueit3VTFMblI5?= =?utf-8?B?WmhxQjlJR21Tb2dnUFp3YktrUndCUWd4UXRBMTAwZWpOZFlaenFyWDlWREVi?= =?utf-8?B?dHVTVjdUeGZaN2xtQ2d6VUhpNFdhS24ybGRQQjU2ZWxOUVlsWHZXaSt1VnVI?= =?utf-8?B?bGY5VmpudmIrczh2ajlnYUMvYTRUZkkrNWk0c3pqR2NEajhVdmR0Y2JpWCt3?= =?utf-8?B?NHZGUnRTb0ozV3FhbmhscGEvNC9IZDJEMnNiZlpVZ3NmK0pDMnBoTnBVK0N4?= =?utf-8?B?d2F4cEdycVljSmUvOEJoeHRncHc4NVJBVnJNWjd3S21Ea3ByM2RvbUFieHNz?= =?utf-8?B?emV6OXZiRC9oWFRvSHdIRmpVRTJLcHZRc2hYZ3RwK3ZpbkxycVdWbmlrN2Vi?= =?utf-8?B?V2ZmM3ZmSFdSNDRXa0JGU29oT24wUTZEb2RPdytKNEMyRGFtU2FDNXRHZWNS?= =?utf-8?B?RFlnQVJ0YnZIcTk4RHdlSitoRzRJRjdLV00wcllyeXVpRzhjQ0hQNStIamNv?= =?utf-8?B?VUEzeGo0N2hyWVoxdFdTaGtXa2ZQeU5scDNKOEUwVU9oZlpkT3N3Wk1ENlQz?= =?utf-8?B?ZHplSHBEdUxTb01OZ2F4bWFwZUpaUFFZVlBwNjZybDN1Z3hMamlDaDVVK0pD?= =?utf-8?B?bUVHaUR0NTFjckNWcXp2cFVVNnVQcUlZZ2lvUGttS0VLRkRGUWMremdiaXJ3?= =?utf-8?B?dy8zWDZkZGFXRGh2bjBQUkNybXZiK2krSG1UREQzWHdGdks3VmtvQzE5aTQz?= =?utf-8?B?RXpoWUNNZWpRVHlxWWFqVWlrUE5uYi9JQ0t0OVJneFpsUE1GajQ1UmdodGNX?= =?utf-8?B?cUNyb1R0L2lSR2N0N09ZVjVvcFdLQmhyYzBWOXV6VEtjRkFrSW4vNE52NmdY?= =?utf-8?B?Wkd4MGVPd2drQ25SZ1pzS3FtMUt5K0xsNnpyTmcrd2lzTFZFVWNpNHZDbkZ0?= =?utf-8?B?TGErSFBEZEt1Qzdyd0d3NGdqc0llL1ZIRHFSK3k4SWJqRWR6RkppekJVUFhi?= =?utf-8?B?V3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ff23ba54-63e7-4b39-15ed-08da755e72b8 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 14:42:54.1357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1CckmQ/AfLuLaMLmihIy4z920uHLDn0+f/AHkvfQ5hJMlg63B0PJTJfebx6aS3Wv0mWOIFcY/gLy8ZIdIh+GJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4076 X-OriginatorOrg: intel.com ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=d0uzDBON; spf=pass (imf14.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1659537778; a=rsa-sha256; cv=fail; b=KSOSWNQ7jtc5en/KU0g484SRNK511BvUcmr3pc4MgMzAV8wnr62caQljFOMBTP+GQ7scYG zPP01j6q2bp8H2bJBB4T+ZldgpzHq6zGUAlFpYgCIrceSLEZEbyYuugyVPZ/MDUO+g05UN FD7nwDxjCZib6Fv1b11YDDKNMpfwGdo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659537778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ujvj9hEkvp0SCAWevi9ira0caQFYXFrviD+dzXzUPhk=; b=yqdto0iAOLfNRQZVygvZSHNs11qpwzDbwMm4BX2ZkvGcp9x9f4yQBVCJD6NMfGvPcJYJHG WJhPVm80Md68glRwEdYQ3lKTEos7G0LyBFmo9ZatrPEDvLUPRdHTNZVG0l94F0/hqxgnQP eWRFHoCtLuAG+nedzQEEJU8qbbW+TlA= X-Stat-Signature: 5ritot99ap5am11bzkzz5pmxc6bm7d95 X-Rspamd-Queue-Id: 5A2C9100122 Authentication-Results: imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=d0uzDBON; spf=pass (imf14.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659537778-751078 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/3/2022 5:39 PM, HORIGUCHI NAOYA(堀口 直也) wrote: > On Wed, Aug 03, 2022 at 10:52:43AM +0800, Yin Fengwei wrote: >> If there is private data attached to THP, the refcount of >> THP will be increased and block the THP split. Which could >> further cause the meomry failure not recovered. >> >> Release private data attached to THP before split it to >> increase the chance of splitting THP successfully. >> >> The issue was hit during HW error injection testing with >> 5.18 kernel + xfs as rootfs, test got killed and system >> reboot was required to re-run the test. >> >> The issue was tracked down to THP split failure caused the >> memory failure not being handled. The page dump showed: >> >> [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 >> [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 >> [ 1785.452408] memcg:ff4247f2d28e9000 >> [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" >> [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) >> [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 >> [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 >> >> It was like the error was injected to a large folio for xfs with >> private data attached. >> >> With private data released before split THP, the test case >> could be run successfully many times without reboot system. >> >> Signed-off-by: Yin Fengwei >> Reviewed-by: Aaron Lu > > Thank you for the patch, > It looks reasonable to me so far. > > Reviewed-by: Naoya Horiguchi Thanks a lot for helping review the patch. As Willy suggested to use new folio API to replace the old try_to_release_page(), there will be a new patch post soon. Regards Yin, Fengwei