From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C253C433E1 for ; Tue, 26 May 2020 11:31:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F307F2073B for ; Tue, 26 May 2020 11:31:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F307F2073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 55EBA800A2; Tue, 26 May 2020 07:31:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50ECF80061; Tue, 26 May 2020 07:31:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44B5D800A2; Tue, 26 May 2020 07:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 2AC7780061 for ; Tue, 26 May 2020 07:31:26 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DDCAC824556B for ; Tue, 26 May 2020 11:31:25 +0000 (UTC) X-FDA: 76858654530.14.legs55_63c457a82c55d X-HE-Tag: legs55_63c457a82c55d X-Filterd-Recvd-Size: 2097 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 11:31:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 800B9B22B; Tue, 26 May 2020 11:31:26 +0000 (UTC) Subject: Re: [PATCH v3 16/19] mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo() To: Roman Gushchin , Andrew Morton Cc: Johannes Weiner , Michal Hocko , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org References: <20200422204708.2176080-1-guro@fb.com> <20200422204708.2176080-17-guro@fb.com> From: Vlastimil Babka Message-ID: <539d6b1c-9719-e29d-c724-20947c806f09@suse.cz> Date: Tue, 26 May 2020 13:31:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200422204708.2176080-17-guro@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/22/20 10:47 PM, Roman Gushchin wrote: > memcg_accumulate_slabinfo() is never called with a non-root > kmem_cache as a first argument, so the is_root_cache(s) check > is redundant and can be removed without any functional change. > > Signed-off-by: Roman Gushchin Reviewed-by: Vlastimil Babka The check is also in memcg_cache() anyway. > --- > mm/slab_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index c045afb9724e..52164ad0f197 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1087,9 +1087,6 @@ memcg_accumulate_slabinfo(struct kmem_cache *s, struct slabinfo *info) > struct kmem_cache *c; > struct slabinfo sinfo; > > - if (!is_root_cache(s)) > - return; > - > c = memcg_cache(s); > if (c) { > memset(&sinfo, 0, sizeof(sinfo)); >