From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC5DC3F2CD for ; Thu, 5 Mar 2020 09:54:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C67C208CD for ; Thu, 5 Mar 2020 09:54:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HxLAL0zP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C67C208CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB8336B0003; Thu, 5 Mar 2020 04:54:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C411E6B0005; Thu, 5 Mar 2020 04:54:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08336B0007; Thu, 5 Mar 2020 04:54:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 9577C6B0003 for ; Thu, 5 Mar 2020 04:54:39 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 820DF1CBE for ; Thu, 5 Mar 2020 09:54:39 +0000 (UTC) X-FDA: 76560849078.13.clam21_b89599dae94b X-HE-Tag: clam21_b89599dae94b X-Filterd-Recvd-Size: 3709 Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Mar 2020 09:54:39 +0000 (UTC) Received: by mail-yw1-f67.google.com with SMTP id o186so5071793ywc.1 for ; Thu, 05 Mar 2020 01:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iSgtTdfYHDSEQjOmhL8s8RS8BFT6nKcKSjSVjF96N2I=; b=HxLAL0zPWi1X9PykfSb8rUgIpzKNH4TsxvhyaKeq8qIsBhwoPnvmTGlf0s6MgIGscn ScDC2T98SirSWP9Bh72NJlhM2dYDR/VmYX1SSEnRQhlNMDJVMwhwAKlRCZC8dYd9uMZm 103NRbNz71Hg4xNBUxnktzxeTtb+PEUrfiLxjuo8LvLLEdjhfOUfxM0dmiyZrQ1Qv+iB Lcdx1+neniGiCU+3/LfiwLqAXH4X+FmoP4czc9iO+u510TRnsOH4Yl1qvjzd7+qitYWq lU1mfmDDqx4EwKKwbdrt0XvwppnInpnGb/5qFopIhFEBTB6R3nFk6P/ZvIaP9wDWIYeu ddLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iSgtTdfYHDSEQjOmhL8s8RS8BFT6nKcKSjSVjF96N2I=; b=anLcL8q/BQCA5SbyqyqFwkH9M7eQXBjtzXTB/9ceYnjw8sfTvlF6BtX8Y9wDRHDJgv gKU4a5eP0kJkmYY7xKpGwBZYVRs9USdwmd7Woda7P1jL9C1JxVh8a7eZicJxORsDy1p6 zkMu2nDstdtQjXTjnedLsw+PVvaOfnJX+QiQCWlyrS2sXdiWKQ1Q/Nfw9QsqVss3TSHn NSnVRShr7tLHXOcTW0QCY9P3/fMWKHKyarfFHR6IGWOtWcRpbs2lWa4KeiU4GGtHx2+J vLRTwNEW2HjrokJs5O2Jkj/GVGCuou++q/rchAeoKZQOoRrWC5TiHPUrLojtTrc2MY4O xb6A== X-Gm-Message-State: ANhLgQ1kDa0sIZ5S7H0wlrHAgmCkAK9pGoSb8UoSxqCFjJdhZtudXm+e 2ngHaqvOP+Kn/WQuHuV+JdY= X-Google-Smtp-Source: ADFU+vsvfytFAZdwQxRdT4tfHXXlAhDr4Wr5VnBX4fxXkx5uaguI4Wed9II7pKqQWbnIddhj+H4w/A== X-Received: by 2002:a0d:c701:: with SMTP id j1mr7171213ywd.52.1583402078324; Thu, 05 Mar 2020 01:54:38 -0800 (PST) Received: from ?IPv6:2601:285:8200:4089:21a8:67e0:7949:94e5? ([2601:285:8200:4089:21a8:67e0:7949:94e5]) by smtp.gmail.com with ESMTPSA id v5sm12342249ywh.23.2020.03.05.01.54.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 01:54:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.1\)) Subject: Re: [PATCH 2/6] mm: Optimise find_subpage for !THP From: William Kucharski In-Reply-To: <20200303214751.GW29971@bombadil.infradead.org> Date: Thu, 5 Mar 2020 02:54:36 -0700 Cc: Alexander Duyck , linux-mm , "Kirill A . Shutemov" Content-Transfer-Encoding: 7bit Message-Id: <53F12AD8-3517-4817-918E-3FBD2BD7D5FC@gmail.com> References: <20200303041125.19358-1-willy@infradead.org> <20200303041125.19358-3-willy@infradead.org> <20200303214751.GW29971@bombadil.infradead.org> To: Matthew Wilcox X-Mailer: Apple Mail (2.3608.80.23.2.1) X-Bogosity: Ham, tests=bogofilter, spamicity=0.005502, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mar 3, 2020, at 2:47 PM, Matthew Wilcox wrote: > > or maybe it's a good reason to make hpage_nr_pages() check that > assertion if !CONFIG_TRANSPARENT_HUGEPAGE. That would be easy enough to do as at present if !CONFIG_TRANSPARENT_HUGEPAGE, hpage_nr_pages() simply returns 1. It would give more coverage to the assert at the cost of a slight performance degradation. Do you think it would be worth it?