From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B21AC4727E for ; Thu, 1 Oct 2020 23:11:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC334206C1 for ; Thu, 1 Oct 2020 23:11:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Ghn4zmqc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC334206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A799E6B00A2; Thu, 1 Oct 2020 19:11:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FD816B00A3; Thu, 1 Oct 2020 19:11:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78DED6B00A4; Thu, 1 Oct 2020 19:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 4AB396B00A2 for ; Thu, 1 Oct 2020 19:11:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DDD2D180AD801 for ; Thu, 1 Oct 2020 23:11:31 +0000 (UTC) X-FDA: 77324905182.30.drink18_06070ba2719f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id BB7C7180B3C8B for ; Thu, 1 Oct 2020 23:11:31 +0000 (UTC) X-HE-Tag: drink18_06070ba2719f X-Filterd-Recvd-Size: 6961 Received: from mail-qk1-f201.google.com (mail-qk1-f201.google.com [209.85.222.201]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 1 Oct 2020 23:11:31 +0000 (UTC) Received: by mail-qk1-f201.google.com with SMTP id 16so47508qky.8 for ; Thu, 01 Oct 2020 16:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=4j3fVIkcNaRRMYto1Vw/oa1eSdu7boUQdMon3zhrkTE=; b=Ghn4zmqcG7UzC/qBoFQT2/BulLCRq2P1q3Q3vzp/lV0o3odVgbtdaJnjQomUKMTUNS oqwi/B+2ioKUixkC63ruG/lRatnOcj7u0dhVFKxxqUJ4oSLBpSv77oucYRiuDfneTsQK IfgH2GIbXDn0ZLplHLKyeY5uckf0kZXi4NinTqHYbJVr0lf4WQB8/lrsVqsa0p1spBjw 6rky4xUpvtElSjbxJv1uHPjkKxDY9uOyLLVmvkhqKC1sjiNsTt56AgsikInOnXfai8lz QxSR8dowOTguoDFsJ63pfug9NJMdHOCDnvmuVTvKhve4UfXaUcidPguyO4Eu4Os2rawW Ohvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=4j3fVIkcNaRRMYto1Vw/oa1eSdu7boUQdMon3zhrkTE=; b=QhwL3nUeY8blBcl9eRum9xOvetdCEe6BfNqePeciK87lyPOdVSgU7kMnMZ6LzRza6T k/mzG00TeajeSFTVbNXZreAyc14KYEBj3GeDGtjPOxO8C3B7lx/kN/vCaGITwTjTYuN1 3tFgGBqOVdKptM3Y54WoweNeRTKEy4N4yo6h1A12yTaUb0ASsSjkiPeIyojqbRupJvHt tzu+IFBY2AoegcXGJm6fHoqbsViPUv6nhjJpYpCgPh3GTUFBVA0zp1VojsODX2eZlE5c 4vXPF23tok6HVaOK4yZmIU8Y+GX5XNiO67qMHsKjudg+5q3rggkw+vpHN+oW/a9Fq3N0 3TsA== X-Gm-Message-State: AOAM531dTeInF5TNiTgOuEcjUnq1VsOLJQlLjyVXrDzz5yx0GyeaUWdR W9F5wOkKucP+eBjkGyIDUPEWCStWIz00TVfT X-Google-Smtp-Source: ABdhPJyMk+ci6qAAdjJN8IywObAzuYgC0PW96YFjzr/JL0Aefh5O23nCzpOKF3tpPl6PbWjvQeP3Edbq8+OFQ+aV X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:ad4:5653:: with SMTP id bl19mr9568120qvb.7.1601593890546; Thu, 01 Oct 2020 16:11:30 -0700 (PDT) Date: Fri, 2 Oct 2020 01:10:20 +0200 In-Reply-To: Message-Id: <53f9771734cebbe1ff0be648d534172c05c56db6.1601593784.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.709.gb0816b6eb0-goog Subject: [PATCH v4 19/39] kasan: rename SHADOW layout macros to META From: Andrey Konovalov To: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com Cc: Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a preparatory commit for the upcoming addition of a new hardware tag-based (MTE-based) KASAN mode. Hardware tag-based KASAN won't be using shadow memory, but will reuse these macros. Rename "SHADOW" to implementation-neutral "META". No functional changes. Signed-off-by: Andrey Konovalov Signed-off-by: Vincenzo Frascino Reviewed-by: Marco Elver --- Change-Id: Id2d836bf43b401bce1221cc06e745185f17b1cc --- mm/kasan/report.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 67aa30b45805..13b27675a696 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -31,11 +31,11 @@ #include "kasan.h" #include "../slab.h" -/* Shadow layout customization. */ -#define SHADOW_BYTES_PER_BLOCK 1 -#define SHADOW_BLOCKS_PER_ROW 16 -#define SHADOW_BYTES_PER_ROW (SHADOW_BLOCKS_PER_ROW * SHADOW_BYTES_PER_BLOCK) -#define SHADOW_ROWS_AROUND_ADDR 2 +/* Metadata layout customization. */ +#define META_BYTES_PER_BLOCK 1 +#define META_BLOCKS_PER_ROW 16 +#define META_BYTES_PER_ROW (META_BLOCKS_PER_ROW * META_BYTES_PER_BLOCK) +#define META_ROWS_AROUND_ADDR 2 static unsigned long kasan_flags; @@ -238,7 +238,7 @@ static void print_address_description(void *addr, u8 tag) static bool row_is_guilty(const void *row, const void *guilty) { - return (row <= guilty) && (guilty < row + SHADOW_BYTES_PER_ROW); + return (row <= guilty) && (guilty < row + META_BYTES_PER_ROW); } static int shadow_pointer_offset(const void *row, const void *shadow) @@ -247,7 +247,7 @@ static int shadow_pointer_offset(const void *row, const void *shadow) * 3 + (BITS_PER_LONG/8)*2 chars. */ return 3 + (BITS_PER_LONG/8)*2 + (shadow - row)*2 + - (shadow - row) / SHADOW_BYTES_PER_BLOCK + 1; + (shadow - row) / META_BYTES_PER_BLOCK + 1; } static void print_memory_metadata(const void *addr) @@ -257,15 +257,15 @@ static void print_memory_metadata(const void *addr) const void *shadow_row; shadow_row = (void *)round_down((unsigned long)shadow, - SHADOW_BYTES_PER_ROW) - - SHADOW_ROWS_AROUND_ADDR * SHADOW_BYTES_PER_ROW; + META_BYTES_PER_ROW) + - META_ROWS_AROUND_ADDR * META_BYTES_PER_ROW; pr_err("Memory state around the buggy address:\n"); - for (i = -SHADOW_ROWS_AROUND_ADDR; i <= SHADOW_ROWS_AROUND_ADDR; i++) { + for (i = -META_ROWS_AROUND_ADDR; i <= META_ROWS_AROUND_ADDR; i++) { const void *kaddr = kasan_shadow_to_mem(shadow_row); char buffer[4 + (BITS_PER_LONG/8)*2]; - char shadow_buf[SHADOW_BYTES_PER_ROW]; + char shadow_buf[META_BYTES_PER_ROW]; snprintf(buffer, sizeof(buffer), (i == 0) ? ">%px: " : " %px: ", kaddr); @@ -274,17 +274,17 @@ static void print_memory_metadata(const void *addr) * function, because generic functions may try to * access kasan mapping for the passed address. */ - memcpy(shadow_buf, shadow_row, SHADOW_BYTES_PER_ROW); + memcpy(shadow_buf, shadow_row, META_BYTES_PER_ROW); print_hex_dump(KERN_ERR, buffer, - DUMP_PREFIX_NONE, SHADOW_BYTES_PER_ROW, 1, - shadow_buf, SHADOW_BYTES_PER_ROW, 0); + DUMP_PREFIX_NONE, META_BYTES_PER_ROW, 1, + shadow_buf, META_BYTES_PER_ROW, 0); if (row_is_guilty(shadow_row, shadow)) pr_err("%*c\n", shadow_pointer_offset(shadow_row, shadow), '^'); - shadow_row += SHADOW_BYTES_PER_ROW; + shadow_row += META_BYTES_PER_ROW; } } -- 2.28.0.709.gb0816b6eb0-goog