From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947EDC433FE for ; Wed, 9 Dec 2020 10:59:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 02EE120782 for ; Wed, 9 Dec 2020 10:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02EE120782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6206F8D0018; Wed, 9 Dec 2020 05:59:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CEFF8D000B; Wed, 9 Dec 2020 05:59:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4972B8D0018; Wed, 9 Dec 2020 05:59:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 2FC648D000B for ; Wed, 9 Dec 2020 05:59:27 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E5EF71EE6 for ; Wed, 9 Dec 2020 10:59:26 +0000 (UTC) X-FDA: 77573447532.03.sofa65_06123f5273ef Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id C82DB28A4E8 for ; Wed, 9 Dec 2020 10:59:26 +0000 (UTC) X-HE-Tag: sofa65_06123f5273ef X-Filterd-Recvd-Size: 4762 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 10:59:25 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9As32V179167; Wed, 9 Dec 2020 10:59:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=mAQoBvZSA1QWuYtRVOFMl3224SBS073y0vaYACV/l9Q=; b=OGYWAem0jnGXCqNqXXwqyr9QiAXaXyuAm45DpnZP9I33R9KKUp5t4o+W+ofOM+kdFLFB WfSGueeEs3HBLc+A+4FbZGRaM3EfJ9QFakO+h99UJcey6haWIRMB53GV56qtdMH2uiqX Egkem7s4wpdkO14db59TIA0BXIoeD5HQRaA1AJY3/m4WJIpk6+AVoPzQPp9ZMFi5szXo Q165bnA8sgEtqrXULYs17+KBp4C8JIgYvG9RB0BuO/5+qwn8ad5jo9BkJ1TS5Y2BOWsY 0/LrdzlPrNb7zBTV7JP9bzrQ6pppt8jWDdyjtVtsroMVcKRiWKbEMSE8Pe7G/9FzSJ1B zg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 3581mqyfe9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Dec 2020 10:59:16 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9AtlbT100906; Wed, 9 Dec 2020 10:59:15 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 358m50ccfq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Dec 2020 10:59:15 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0B9AxDnS030207; Wed, 9 Dec 2020 10:59:14 GMT Received: from [10.175.160.66] (/10.175.160.66) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Dec 2020 02:59:13 -0800 Subject: Re: [PATCH RFC 8/9] RDMA/umem: batch page unpin in __ib_mem_release() To: Jason Gunthorpe Cc: linux-mm@kvack.org, Dan Williams , Ira Weiny , linux-nvdimm@lists.01.org, Matthew Wilcox , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton References: <20201208172901.17384-1-joao.m.martins@oracle.com> <20201208172901.17384-10-joao.m.martins@oracle.com> <20201208192935.GA1908088@ziepe.ca> From: Joao Martins Message-ID: <543363df-cefd-93e9-1ca1-9256e910a915@oracle.com> Date: Wed, 9 Dec 2020 10:59:09 +0000 MIME-Version: 1.0 In-Reply-To: <20201208192935.GA1908088@ziepe.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9829 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=5 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090076 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9829 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=5 mlxlogscore=999 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090076 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/20 7:29 PM, Jason Gunthorpe wrote: > On Tue, Dec 08, 2020 at 05:29:00PM +0000, Joao Martins wrote: > >> static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int dirty) >> { >> + bool make_dirty = umem->writable && dirty; >> + struct page **page_list = NULL; >> struct sg_page_iter sg_iter; >> + unsigned long nr = 0; >> struct page *page; >> >> + page_list = (struct page **) __get_free_page(GFP_KERNEL); > > Gah, no, don't do it like this! > > Instead something like: > > for_each_sg(umem->sg_head.sgl, sg, umem->nmap, i) > unpin_use_pages_range_dirty_lock(sg_page(sg), sg->length/PAGE_SIZE, > umem->writable && dirty); > > And have the mm implementation split the contiguous range of pages into > pairs of (compound head, ntails) with a bit of maths. > Got it :) I was trying to avoid another exported symbol. Albeit upon your suggestion below, it doesn't justify the efficiency/clearness lost. Joao