From: Ralph Campbell <rcampbell@nvidia.com>
To: Alistair Popple <apopple@nvidia.com>, <linux-mm@kvack.org>,
<nouveau@lists.freedesktop.org>, <bskeggs@redhat.com>,
<akpm@linux-foundation.org>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kvm-ppc@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<jhubbard@nvidia.com>, <jglisse@redhat.com>
Subject: Re: [PATCH v4 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Mon, 8 Mar 2021 10:39:19 -0800 [thread overview]
Message-ID: <547dda23-ac57-559e-664f-172e3d6749d5@nvidia.com> (raw)
In-Reply-To: <20210304061645.29747-4-apopple@nvidia.com>
On 3/3/21 10:16 PM, Alistair Popple wrote:
> The behaviour of try_to_unmap_one() is difficult to follow because it
> performs different operations based on a fairly large set of flags used
> in different combinations.
>
> TTU_MUNLOCK is one such flag. However it is exclusively used by
> try_to_munlock() which specifies no other flags. Therefore rather than
> overload try_to_unmap_one() with unrelated behaviour split this out into
> it's own function and remove the flag.
>
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
Looks good to me.
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
next prev parent reply other threads:[~2021-03-08 18:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 6:16 [PATCH v4 0/8] Add support for SVM atomics in Nouveau Alistair Popple
2021-03-04 6:16 ` [PATCH v4 1/8] mm: Remove special swap entry functions Alistair Popple
2021-03-08 18:24 ` Ralph Campbell
2021-03-04 6:16 ` [PATCH v4 2/8] mm/swapops: Rework swap entry manipulation code Alistair Popple
2021-03-08 18:30 ` Ralph Campbell
2021-03-04 6:16 ` [PATCH v4 3/8] mm/rmap: Split try_to_munlock from try_to_unmap Alistair Popple
2021-03-08 18:39 ` Ralph Campbell [this message]
2021-03-04 6:16 ` [PATCH v4 4/8] mm/rmap: Split migration into its own function Alistair Popple
2021-03-08 18:58 ` Ralph Campbell
2021-03-09 0:01 ` Alistair Popple
2021-03-04 6:16 ` [PATCH v4 5/8] mm: Device exclusive memory access Alistair Popple
2021-03-08 19:44 ` Ralph Campbell
2021-03-09 1:17 ` Alistair Popple
2021-03-04 6:16 ` [PATCH v4 6/8] mm: Selftests for exclusive device memory Alistair Popple
2021-03-04 6:16 ` [PATCH v4 7/8] nouveau/svm: Refactor nouveau_range_fault Alistair Popple
2021-03-04 6:16 ` [PATCH v4 8/8] nouveau/svm: Implement atomic SVM access Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547dda23-ac57-559e-664f-172e3d6749d5@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).