From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832E8C54F70 for ; Sun, 19 Apr 2020 22:50:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4FDDE21841 for ; Sun, 19 Apr 2020 22:50:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FDDE21841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB7A78E0005; Sun, 19 Apr 2020 18:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A68488E0003; Sun, 19 Apr 2020 18:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97D508E0005; Sun, 19 Apr 2020 18:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 81C648E0003 for ; Sun, 19 Apr 2020 18:50:19 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3CE8533CD for ; Sun, 19 Apr 2020 22:50:19 +0000 (UTC) X-FDA: 76726099758.08.soda60_5a0fd60180462 X-HE-Tag: soda60_5a0fd60180462 X-Filterd-Recvd-Size: 3325 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 22:50:18 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id b12so1037198pff.4 for ; Sun, 19 Apr 2020 15:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OxxnYeHTWroY6hmuHlAIlsKHz3BuO/6//L5YqJ82mMY=; b=uPtN/pI/y48sQkLOnQ6uq6gNpYlsP86Bj1i9tT8PikeHWohlvJUBZSfcgKUHHrUn6u VC55jH6ukcb+4Hrgr117hnBYxpfdaltJQFRvUGlnpvqzykQ2o8oVa3V2jjQnM7oDtve7 02rV/Cn0/tciIN3uSCxYnAqg6uo9MOiT++V8cPbgS4ystHgX7B/l7wVB1OEcCsYqjDgU PLeMoNhZkvftvLv+HHwfkhqDIpRq4CtGd4Xu5JuDHjWg9NULm4HVnoA3bMpDMj3l24Aa AyWJViYcNjxTcKFW+NcCIioefOS2QtERXviRFXdXvsX7jUpgjpC+lMvkQ9QBNYDTDpM+ OLLg== X-Gm-Message-State: AGi0PuZ6pxo9pU7DYXRPDZGWGuvgL/vX4cECV+CtWKXc/RJj8XeS7ByR Z0VMInh/NgpNxykY2UcZF9c= X-Google-Smtp-Source: APiQypKW5JUfcsFpRqbbC+YhkiXeOliCnTOExnj3O8GqgN3Ldx2ACG/U/AE1gygv1oLNFBasLCJLIQ== X-Received: by 2002:a62:8106:: with SMTP id t6mr14151348pfd.81.1587336617865; Sun, 19 Apr 2020 15:50:17 -0700 (PDT) Received: from [100.124.11.78] ([104.129.199.4]) by smtp.gmail.com with ESMTPSA id fy21sm11943472pjb.25.2020.04.19.15.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 15:50:16 -0700 (PDT) Subject: Re: [PATCH v2 05/10] blktrace: upgrade warns to BUG_ON() on unexpected circmunstances To: Luis Chamberlain , axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200419194529.4872-1-mcgrof@kernel.org> <20200419194529.4872-6-mcgrof@kernel.org> From: Bart Van Assche Message-ID: <54b63fd9-0c73-5fdc-b43d-6ab4aec3a00d@acm.org> Date: Sun, 19 Apr 2020 15:50:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200419194529.4872-6-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/19/20 12:45 PM, Luis Chamberlain wrote: > @@ -498,10 +498,7 @@ static struct dentry *blk_trace_debugfs_dir(struct blk_user_trace_setup *buts, > struct dentry *dir = NULL; > > /* This can only happen if we have a bug on our lower layers */ > - if (!q->kobj.parent) { > - pr_warn("%s: request_queue parent is gone\n", buts->name); > - return NULL; > - } > + BUG_ON(!q->kobj.parent); Does the following quote from Linus also apply to this patch: "there is NO F*CKING EXCUSE to knowingly kill the kernel." See also https://lkml.org/lkml/2016/10/4/1. Thanks, Bart.