From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 366F6C4361B for ; Thu, 10 Dec 2020 09:28:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 800B723DB3 for ; Thu, 10 Dec 2020 09:28:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 800B723DB3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AB706B006E; Thu, 10 Dec 2020 04:28:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05BAD6B0070; Thu, 10 Dec 2020 04:28:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8E5D6B0071; Thu, 10 Dec 2020 04:28:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id DC2246B006E for ; Thu, 10 Dec 2020 04:28:19 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B84A4180AD830 for ; Thu, 10 Dec 2020 09:28:19 +0000 (UTC) X-FDA: 77576846718.09.sun85_0610828273f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id A0B4B180AD822 for ; Thu, 10 Dec 2020 09:28:19 +0000 (UTC) X-HE-Tag: sun85_0610828273f7 X-Filterd-Recvd-Size: 4138 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 09:28:18 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UI810Cr_1607592488; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UI810Cr_1607592488) by smtp.aliyun-inc.com(127.0.0.1); Thu, 10 Dec 2020 17:28:08 +0800 Subject: Re: [PATCH 00/11] mm: lru related cleanups To: Yu Zhao , Andrew Morton , Hugh Dickins Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201207220949.830352-1-yuzhao@google.com> From: Alex Shi Message-ID: <54bdbe42-023a-4e32-9b94-173d0ad2dc16@linux.alibaba.com> Date: Thu, 10 Dec 2020 17:28:08 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201207220949.830352-1-yuzhao@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yu, btw, after this patchset, to do cacheline alignment on each of lru lists are possible, so did you try that to see performance changes? Thanks Alex =E5=9C=A8 2020/12/8 =E4=B8=8A=E5=8D=886:09, Yu Zhao =E5=86=99=E9=81=93: > The cleanups are intended to reduce the verbosity in lru list > operations and make them less error-prone. A typical example > would be how the patches change __activate_page(): >=20 > static void __activate_page(struct page *page, struct lruvec *lruvec) > { > if (!PageActive(page) && !PageUnevictable(page)) { > - int lru =3D page_lru_base_type(page); > int nr_pages =3D thp_nr_pages(page); > =20 > - del_page_from_lru_list(page, lruvec, lru); > + del_page_from_lru_list(page, lruvec); > SetPageActive(page); > - lru +=3D LRU_ACTIVE; > - add_page_to_lru_list(page, lruvec, lru); > + add_page_to_lru_list(page, lruvec); > trace_mm_lru_activate(page); > =20 > There are a few more places like __activate_page() and they are > unnecessarily repetitive in terms of figuring out which list a page > should be added onto or deleted from. And with the duplicated code > removed, they are easier to read, IMO. >=20 > Patch 1 to 5 basically cover the above. Patch 6 and 7 make code more > robust by improving bug reporting. Patch 8, 9 and 10 take care of > some dangling helpers left in header files. Patch 11 isn't strictly a > clean-up patch, but it seems still relevant to include it here. >=20 > Yu Zhao (11): > mm: use add_page_to_lru_list() > mm: shuffle lru list addition and deletion functions > mm: don't pass "enum lru_list" to lru list addition functions > mm: don't pass "enum lru_list" to trace_mm_lru_insertion() > mm: don't pass "enum lru_list" to del_page_from_lru_list() > mm: add __clear_page_lru_flags() to replace page_off_lru() > mm: VM_BUG_ON lru page flags > mm: fold page_lru_base_type() into its sole caller > mm: fold __update_lru_size() into its sole caller > mm: make lruvec_lru_size() static > mm: enlarge the "int nr_pages" parameter of update_lru_size() >=20 > include/linux/memcontrol.h | 10 +-- > include/linux/mm_inline.h | 115 ++++++++++++++------------------- > include/linux/mmzone.h | 2 - > include/linux/vmstat.h | 6 +- > include/trace/events/pagemap.h | 11 ++-- > mm/compaction.c | 2 +- > mm/memcontrol.c | 10 +-- > mm/mlock.c | 3 +- > mm/swap.c | 50 ++++++-------- > mm/vmscan.c | 21 ++---- > 10 files changed, 91 insertions(+), 139 deletions(-) >=20