From: David Rientjes <rientjes@google.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jirislaby@kernel.org, jacobly.alt@gmail.com,
holger@applied-asynchrony.com, michel@lespinasse.org,
jglisse@google.com, mhocko@suse.com,
Vlastimil Babka <vbabka@suse.cz>,
hannes@cmpxchg.org, mgorman@techsingularity.net,
Davidlohr Bueso <dave@stgolabs.net>,
Matthew Wilcox <willy@infradead.org>,
"Liam R. Howlett" <liam.howlett@oracle.com>,
Peter Zijlstra <peterz@infradead.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
paulmck@kernel.org, mingo@redhat.com, will@kernel.org,
luto@kernel.org, songliubraving@fb.com, peterx@redhat.com,
david@redhat.com, dhowells@redhat.com, hughd@google.com,
bigeasy@linutronix.de, kent.overstreet@linux.dev,
punit.agrawal@bytedance.com, lstoakes@gmail.com,
peterjung1337@gmail.com, chriscli@google.com,
axelrasmussen@google.com, joelaf@google.com, minchan@google.com,
rppt@kernel.org, jannh@google.com, shakeelb@google.com,
tatashin@google.com, edumazet@google.com, gthelen@google.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed
Date: Mon, 3 Jul 2023 13:07:48 -0700 (PDT) [thread overview]
Message-ID: <54cd9ffb-8f4b-003f-c2d6-3b6b0d2cb7d9@google.com> (raw)
In-Reply-To: <20230703182150.2193578-1-surenb@google.com>
On Mon, 3 Jul 2023, Suren Baghdasaryan wrote:
> A memory corruption was reported in [1] with bisection pointing to the
> patch [2] enabling per-VMA locks for x86.
> Disable per-VMA locks config to prevent this issue while the problem is
> being investigated. This is expected to be a temporary measure.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624
> [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com
>
> Reported-by: Jiri Slaby <jirislaby@kernel.org>
> Reported-by: Jacob Young <jacobly.alt@gmail.com>
> Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first")
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Acked-by: David Rientjes <rientjes@google.com>
Thanks for the heads up! The bisect commit [2] is a no-op with
CONFIG_PER_VMA_LOCK disabled, this looks good.
Nit: in that patch the "done" label could have been a:
"done: __maybe_unused"
to a avoid the #ifdef :P
> ---
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 09130434e30d..de94b2497600 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1224,7 +1224,7 @@ config ARCH_SUPPORTS_PER_VMA_LOCK
> def_bool n
>
> config PER_VMA_LOCK
> - def_bool y
> + bool "Enable per-vma locking during page fault handling."
> depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP
> help
> Allow per-vma locking during page fault handling.
> --
> 2.41.0.255.g8b1d071c50-goog
>
>
next prev parent reply other threads:[~2023-07-03 20:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 18:21 [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed Suren Baghdasaryan
2023-07-03 20:07 ` David Rientjes [this message]
2023-07-03 20:30 ` David Hildenbrand
2023-07-04 5:39 ` Suren Baghdasaryan
2023-07-04 6:50 ` Suren Baghdasaryan
2023-07-04 7:18 ` David Hildenbrand
2023-07-04 7:34 ` Suren Baghdasaryan
2023-07-04 8:03 ` David Hildenbrand
2023-07-04 18:01 ` David Hildenbrand
2023-07-04 13:07 ` Matthew Wilcox
2023-07-04 17:21 ` Suren Baghdasaryan
2023-07-04 17:36 ` David Hildenbrand
2023-07-04 17:56 ` Suren Baghdasaryan
2023-07-04 18:05 ` David Hildenbrand
2023-07-04 19:11 ` Suren Baghdasaryan
2023-07-04 20:10 ` Suren Baghdasaryan
[not found] ` <7d6ba07b-ee60-8920-b91c-04c826eb4690@applied-asynchrony.com>
2023-07-04 22:03 ` Suren Baghdasaryan
2023-07-04 22:42 ` Matthew Wilcox
[not found] ` <a7149847-4b53-8ff0-d570-042631a1ce20@applied-asynchrony.com>
2023-07-05 6:46 ` Suren Baghdasaryan
2023-07-04 17:55 ` Matthew Wilcox
2023-07-04 17:58 ` Suren Baghdasaryan
2023-07-04 8:12 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-04 8:30 ` Hans de Goede
2023-07-04 8:18 ` Hans de Goede
2023-07-04 15:24 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54cd9ffb-8f4b-003f-c2d6-3b6b0d2cb7d9@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bigeasy@linutronix.de \
--cc=chriscli@google.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=holger@applied-asynchrony.com \
--cc=hughd@google.com \
--cc=jacobly.alt@gmail.com \
--cc=jannh@google.com \
--cc=jglisse@google.com \
--cc=jirislaby@kernel.org \
--cc=joelaf@google.com \
--cc=kent.overstreet@linux.dev \
--cc=ldufour@linux.ibm.com \
--cc=liam.howlett@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=michel@lespinasse.org \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterjung1337@gmail.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=punit.agrawal@bytedance.com \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=songliubraving@fb.com \
--cc=surenb@google.com \
--cc=tatashin@google.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).