From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>, Zi Yan <ziy@nvidia.com>,
Muchun Song <songmuchun@bytedance.com>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH RESEND 0/8] hugetlb: add demote/split page functionality
Date: Mon, 16 Aug 2021 17:58:31 -0700 [thread overview]
Message-ID: <54fdf347-e12e-0d3e-6c33-8b1b7898876c@oracle.com> (raw)
In-Reply-To: <20210816173959.950443c7516a2b178e2ec376@linux-foundation.org>
On 8/16/21 5:39 PM, Andrew Morton wrote:
> On Mon, 16 Aug 2021 17:17:50 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>>>
>>> And how does one know the operation has completed so the sysfs files
>>> can be reloaded for another operation?
>>>
>>
>> When the write to the file is complete, the operation has completed.
>> Not exactly sure what you mean by reloading the sysfs files for
>> another operation?
>
> If userspace wishes to perform another demote operation, it must wait
> for the preceding one to complete.
>
> Presumably if thread A is blocked in a write to `demote' and thread B
> concurrently tries to perform a demotion, thread B will be blocked as
> well? Was this tested?
I must admit that I did not specifically test this. However, the
patch series to make freeing of hugetlb pages IRQ safe added a
(per-hstate)mutex that is taken when sysfs files modify the number of
huge pages. demote writes take this mutex (patch 1). That synchronizes
not only concurrent writes to demote but also concurrent modifications
of nr_hugepages.
>
> Lots of things are to be added to changelogs & documentation, methinks.
>
OK.
Thank you for taking a look at this!
--
Mike Kravetz
next prev parent reply other threads:[~2021-08-17 0:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 22:49 [PATCH RESEND 0/8] hugetlb: add demote/split page functionality Mike Kravetz
2021-08-16 22:49 ` [PATCH 1/8] hugetlb: add demote hugetlb page sysfs interfaces Mike Kravetz
2021-08-16 22:49 ` [PATCH 2/8] hugetlb: add HPageCma flag and code to free non-gigantic pages in CMA Mike Kravetz
2021-08-16 22:49 ` [PATCH 3/8] hugetlb: add demote bool to gigantic page routines Mike Kravetz
2021-08-16 22:49 ` [PATCH 4/8] hugetlb: add hugetlb demote page support Mike Kravetz
2021-08-16 22:49 ` [PATCH 5/8] hugetlb: document the demote sysfs interfaces Mike Kravetz
2021-08-16 23:28 ` Andrew Morton
2021-08-17 1:04 ` Mike Kravetz
2021-09-21 13:52 ` Aneesh Kumar K.V
2021-09-21 17:17 ` Mike Kravetz
2021-08-16 22:49 ` [PATCH 6/8] hugetlb: vmemmap optimizations when demoting hugetlb pages Mike Kravetz
2021-08-16 22:49 ` [PATCH 7/8] hugetlb: prepare destroy and prep routines for vmemmap optimized pages Mike Kravetz
2021-08-16 22:49 ` [PATCH 8/8] hugetlb: Optimized demote vmemmap optimizatized pages Mike Kravetz
2021-08-16 23:23 ` [PATCH RESEND 0/8] hugetlb: add demote/split page functionality Andrew Morton
2021-08-17 0:17 ` Mike Kravetz
2021-08-17 0:39 ` Andrew Morton
2021-08-17 0:58 ` Mike Kravetz [this message]
2021-08-16 23:27 ` Andrew Morton
2021-08-17 0:46 ` Mike Kravetz
2021-08-17 1:46 ` Andrew Morton
2021-08-17 7:30 ` David Hildenbrand
2021-08-17 16:19 ` Mike Kravetz
2021-08-17 18:49 ` David Hildenbrand
2021-08-24 22:08 ` Mike Kravetz
2021-08-26 7:32 ` Hillf Danton
2021-08-27 17:22 ` Vlastimil Babka
2021-08-27 23:04 ` Mike Kravetz
2021-08-30 10:11 ` Vlastimil Babka
2021-09-02 18:17 ` Mike Kravetz
2021-09-06 14:40 ` Vlastimil Babka
2021-09-07 8:50 ` Hillf Danton
2021-09-08 21:00 ` Mike Kravetz
2021-09-09 4:07 ` Hillf Danton
2021-09-09 11:54 ` Michal Hocko
2021-09-09 13:45 ` Vlastimil Babka
2021-09-09 21:31 ` Mike Kravetz
2021-09-10 8:20 ` Michal Hocko
2021-09-11 0:11 ` Mike Kravetz
2021-09-11 3:11 ` Hillf Danton
2021-09-13 15:50 ` Michal Hocko
2021-09-15 16:57 ` Mike Kravetz
2021-09-17 20:44 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54fdf347-e12e-0d3e-6c33-8b1b7898876c@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=naoya.horiguchi@linux.dev \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=songmuchun@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).