From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
cov@codeaurora.org, criu@openvz.org
Subject: Re: [PATCH 1/2] mm: Introducing arch_remap hook
Date: Mon, 23 Mar 2015 10:11:18 +0100 [thread overview]
Message-ID: <550FD8B6.305@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150323085209.GA28965@gmail.com>
On 23/03/2015 09:52, Ingo Molnar wrote:
>
> * Laurent Dufour <ldufour@linux.vnet.ibm.com> wrote:
>
>> Some architecture would like to be triggered when a memory area is moved
>> through the mremap system call.
>>
>> This patch is introducing a new arch_remap mm hook which is placed in the
>> path of mremap, and is called before the old area is unmapped (and the
>> arch_unmap hook is called).
>>
>> To no break the build, this patch adds the empty hook definition to the
>> architectures that were not using the generic hook's definition.
>>
>> Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
>> ---
>> arch/s390/include/asm/mmu_context.h | 6 ++++++
>> arch/um/include/asm/mmu_context.h | 5 +++++
>> arch/unicore32/include/asm/mmu_context.h | 6 ++++++
>> arch/x86/include/asm/mmu_context.h | 6 ++++++
>> include/asm-generic/mm_hooks.h | 6 ++++++
>> mm/mremap.c | 9 +++++++--
>> 6 files changed, 36 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/s390/include/asm/mmu_context.h b/arch/s390/include/asm/mmu_context.h
>> index 8fb3802f8fad..ddd861a490ba 100644
>> --- a/arch/s390/include/asm/mmu_context.h
>> +++ b/arch/s390/include/asm/mmu_context.h
>> @@ -131,4 +131,10 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
>> {
>> }
>>
>> +static inline void arch_remap(struct mm_struct *mm,
>> + unsigned long old_start, unsigned long old_end,
>> + unsigned long new_start, unsigned long new_end)
>> +{
>> +}
>> +
>> #endif /* __S390_MMU_CONTEXT_H */
>> diff --git a/arch/um/include/asm/mmu_context.h b/arch/um/include/asm/mmu_context.h
>> index 941527e507f7..f499b017c1f9 100644
>> --- a/arch/um/include/asm/mmu_context.h
>> +++ b/arch/um/include/asm/mmu_context.h
>> @@ -27,6 +27,11 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
>> struct vm_area_struct *vma)
>> {
>> }
>> +static inline void arch_remap(struct mm_struct *mm,
>> + unsigned long old_start, unsigned long old_end,
>> + unsigned long new_start, unsigned long new_end)
>> +{
>> +}
>> /*
>> * end asm-generic/mm_hooks.h functions
>> */
>> diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
>> index 1cb5220afaf9..39a0a553172e 100644
>> --- a/arch/unicore32/include/asm/mmu_context.h
>> +++ b/arch/unicore32/include/asm/mmu_context.h
>> @@ -97,4 +97,10 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
>> {
>> }
>>
>> +static inline void arch_remap(struct mm_struct *mm,
>> + unsigned long old_start, unsigned long old_end,
>> + unsigned long new_start, unsigned long new_end)
>> +{
>> +}
>> +
>> #endif
>> diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h
>> index 883f6b933fa4..75cb71f4be1e 100644
>> --- a/arch/x86/include/asm/mmu_context.h
>> +++ b/arch/x86/include/asm/mmu_context.h
>> @@ -172,4 +172,10 @@ static inline void arch_unmap(struct mm_struct *mm, struct vm_area_struct *vma,
>> mpx_notify_unmap(mm, vma, start, end);
>> }
>>
>> +static inline void arch_remap(struct mm_struct *mm,
>> + unsigned long old_start, unsigned long old_end,
>> + unsigned long new_start, unsigned long new_end)
>> +{
>> +}
>> +
>> #endif /* _ASM_X86_MMU_CONTEXT_H */
>
> So instead of spreading these empty prototypes around mmu_context.h
> files, why not add something like this to the PPC definition:
>
> #define __HAVE_ARCH_REMAP
>
> and define the empty prototype for everyone else? It's a bit like how
> the __HAVE_ARCH_PTEP_* namespace works.
>
> That should shrink this patch considerably.
My idea was to mimic the MMU hook's definition. This new hook is in the
continuity of what have been done for arch_dup_mmap, arch_exit_mmap,
arch_unmap and arch_bprm_mm_init.
Do you think that there is a need to make this one in another way ?
Thanks,
Laurent.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-23 9:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:53 [PATCH 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-20 15:53 ` [PATCH 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-20 23:19 ` Richard Weinberger
2015-03-23 8:52 ` Ingo Molnar
2015-03-23 9:11 ` Laurent Dufour [this message]
2015-03-25 11:06 ` [PATCH v2 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-25 11:06 ` [PATCH v2 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-25 11:06 ` [PATCH v2 2/2] powerpc/mm: Tracking vDSO remap Laurent Dufour
2015-03-25 12:11 ` Ingo Molnar
2015-03-25 13:25 ` Laurent Dufour
2015-03-25 13:53 ` [PATCH v3 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-25 13:53 ` [PATCH v3 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-25 13:53 ` [PATCH v3 2/2] powerpc/mm: Tracking vDSO remap Laurent Dufour
2015-03-25 18:33 ` Ingo Molnar
2015-03-25 18:36 ` Ingo Molnar
2015-03-25 21:11 ` Benjamin Herrenschmidt
2015-03-26 9:43 ` Ingo Molnar
2015-03-26 10:37 ` Laurent Dufour
2015-03-26 14:17 ` Ingo Molnar
2015-03-26 14:32 ` Laurent Dufour
2015-03-26 17:37 ` [PATCH v4 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-26 17:37 ` [PATCH v4 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-26 17:37 ` [PATCH v4 2/2] powerpc/mm: Tracking vDSO remap Laurent Dufour
2015-03-26 18:55 ` Ingo Molnar
2015-03-27 11:02 ` Laurent Dufour
2015-03-26 23:23 ` [PATCH v3 " Benjamin Herrenschmidt
2015-03-25 21:09 ` Benjamin Herrenschmidt
2015-03-26 9:48 ` Ingo Molnar
2015-03-26 10:13 ` Laurent Dufour
2015-03-20 15:53 ` [PATCH " Laurent Dufour
2016-03-02 12:13 ` [PATCH 0/2] Tracking user space vDSO remaping Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550FD8B6.305@linux.vnet.ibm.com \
--to=ldufour@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cov@codeaurora.org \
--cc=criu@openvz.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).