From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1EF5C433E0 for ; Fri, 31 Jul 2020 13:20:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69F2B2245C for ; Fri, 31 Jul 2020 13:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="o7VdKgxQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69F2B2245C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1581D8D002C; Fri, 31 Jul 2020 09:20:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E4E88D002A; Fri, 31 Jul 2020 09:20:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC6308D002C; Fri, 31 Jul 2020 09:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id CCD0D8D002A for ; Fri, 31 Jul 2020 09:20:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8652333CD for ; Fri, 31 Jul 2020 13:20:55 +0000 (UTC) X-FDA: 77098431270.24.fear06_4a0cf7b26f84 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 5E7A41A4A0 for ; Fri, 31 Jul 2020 13:20:55 +0000 (UTC) X-HE-Tag: fear06_4a0cf7b26f84 X-Filterd-Recvd-Size: 4865 Received: from mail-qk1-f202.google.com (mail-qk1-f202.google.com [209.85.222.202]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jul 2020 13:20:54 +0000 (UTC) Received: by mail-qk1-f202.google.com with SMTP id a186so4595497qke.1 for ; Fri, 31 Jul 2020 06:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=evCrDeDl40PK8tQYA287KciiJFZ+88x9kt3Qo3tXcbw=; b=o7VdKgxQCSSYoocE3F40S21gIBlPyWctlDUqWnc3OG5cpjU9K5ciJhmU3Bqjsak7Y1 HHiSULFwwvEZXgcCUyxBIVby5d0XcFuLVWR9CN+jXSSjYK+PLOb5aGZEe0DzARZBLB1F XV2g0MMJ+uhw+m2ZKuGEG6eEr9VXeEwE7WmTptaX6kgNA4oDLlK3odu91eiP/i8uA0Fa eTTSmd1G103bSXOgbKM0tRcjGZw2WS8G8IiOtDjcjzEKJdqyhR2RMevgshdT7qF+Vd0F P4WxKhPdEiw7CT5pZjryPOjTalDwrep9ZFlhlX3KI7lIm/4m2fJjFmd7OFhJ7QIbfNSv U40A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=evCrDeDl40PK8tQYA287KciiJFZ+88x9kt3Qo3tXcbw=; b=KbELD0gYGgviIF741H4H5NKaStRju35AI5I1u2YEPI2t9Q/NKAvjwX+VK3p9PsloCk iQ9zZk1i385WDPkEzCorkZDNFZIDD1Z/4bFHLd5pLKakSJ0u83i8AzGW7gsEVmMXIPPE IWBgqSqcA944HXeXIABVMdGsCjHoy6GdULsW2xYX6P+AlxoJkjyM/4I7TDymjPBD/b4w 06HrQILV77ov46pOnw+8fmGQzIDmSy6rIrB17xcKcBKC09ZkuW/NwOQVrjcDrH4UpcUz zF8H0M9EO3BJ79ZjbJYImfAKpmuNpjavIgEsHtUbNwD+4bJjcAey+PbB8PamZGR05TKO wQ+w== X-Gm-Message-State: AOAM531CW24nU9xRJyHh/ApA7zypL2gnMGTbXk6eZLs+lbMw/WvvRO2t i1/xX/1tIo6j3qvpwmQePnM4W8uyIbM86P5g X-Google-Smtp-Source: ABdhPJz/IdkmTWODy6uNdNCndSQBvUsuBuekmlNP84MdsovzBWlo1RYnI51/aqZjGGd4xNBPfrwZy+JY12louwin X-Received: by 2002:a0c:aac8:: with SMTP id g8mr4080160qvb.70.1596201654097; Fri, 31 Jul 2020 06:20:54 -0700 (PDT) Date: Fri, 31 Jul 2020 15:20:39 +0200 In-Reply-To: Message-Id: <55d432671a92e931ab8234b03dc36b14d4c21bfb.1596199677.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH 2/4] kasan, arm64: don't instrument functions that enable kasan From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5E7A41A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch prepares Software Tag-Based KASAN for stack tagging support. With stack tagging enabled, KASAN tags stack variable in each function in its prologue. In start_kernel() stack variables get tagged before KASAN is enabled via setup_arch()->kasan_init(). As the result the tags for start_kernel()'s stack variables end up in the temporary shadow memory. Later when KASAN gets enabled, switched to normal shadow, and starts checking tags, this leads to false-positive reports, as proper tags are missing in normal shadow. Disable KASAN instrumentation for start_kernel(). Also disable it for arm64's setup_arch() as a precaution (it doesn't have any stack variables right now). Signed-off-by: Andrey Konovalov --- arch/arm64/kernel/setup.c | 2 +- init/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index c793276ec7ad..87e81d29e6fb 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -276,7 +276,7 @@ arch_initcall(reserve_memblock_reserved_regions); u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; -void __init setup_arch(char **cmdline_p) +void __init __no_sanitize_address setup_arch(char **cmdline_p) { init_mm.start_code = (unsigned long) _text; init_mm.end_code = (unsigned long) _etext; diff --git a/init/main.c b/init/main.c index 2d74985e09b1..c73a16ff213e 100644 --- a/init/main.c +++ b/init/main.c @@ -829,7 +829,7 @@ void __init __weak arch_call_rest_init(void) rest_init(); } -asmlinkage __visible void __init start_kernel(void) +asmlinkage __visible __no_sanitize_address void __init start_kernel(void) { char *command_line; char *after_dashes; -- 2.28.0.163.g6104cc2f0b6-goog