From: Tang Chen <tangchen@cn.fujitsu.com>
To: Xishi Qiu <qiuxishi@huawei.com>,
Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
zhongjiang@huawei.com, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages
Date: Wed, 14 Oct 2015 10:50:52 +0800 [thread overview]
Message-ID: <561DC30C.70909@cn.fujitsu.com> (raw)
In-Reply-To: <561B0ECD.5000507@huawei.com>
Hi, Qiu
The patch seems OK to me. Only one little concern below.
On 10/12/2015 09:37 AM, Xishi Qiu wrote:
> On 2015/10/9 23:41, Yasuaki Ishimatsu wrote:
>
>> On Thu, 8 Oct 2015 10:21:05 +0800
>> Xishi Qiu <qiuxishi@huawei.com> wrote:
>>
>>> If kernelcore was not specified, or the kernelcore size is zero
>>> (required_movablecore >= totalpages), or the kernelcore size is larger
>> Why does required_movablecore become larger than totalpages, when the
>> kernelcore size is zero? I read the code but I could not find that you
>> mention.
>>
> If user only set boot option movablecore, and the value is larger than
> totalpages, the calculation of kernelcore is zero, but we can't fill
> the zone only with kernelcore, so skip it.
>
> I have send a patch before this patch.
> "fix overflow in find_zone_movable_pfns_for_nodes()"
> ...
> required_movablecore =
> roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> + required_movablecore = min(totalpages, required_movablecore);
> corepages = totalpages - required_movablecore;
> ...
So if required_movablecore >= totalpages, there won't be any ZONE_MOVABLE.
How about add a warning or debug info to tell the user he has specified a
too large movablecore, and it is ignored ?
Thanks.
>
> Thanks,
> Xishi Qiu
>
>> Thanks,
>> Yasuaki Ishimatsu
>>
>>> than totalpages, there is no ZONE_MOVABLE. We should fill the zone
>>> with both kernel memory and movable memory.
>>>
>>> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>>> ---
>>> mm/page_alloc.c | 7 +++++--
>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index af3c9bd..6a6da0d 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -5674,8 +5674,11 @@ static void __init find_zone_movable_pfns_for_nodes(void)
>>> required_kernelcore = max(required_kernelcore, corepages);
>>> }
>>>
>>> - /* If kernelcore was not specified, there is no ZONE_MOVABLE */
>>> - if (!required_kernelcore)
>>> + /*
>>> + * If kernelcore was not specified or kernelcore size is larger
>>> + * than totalpages, there is no ZONE_MOVABLE.
>>> + */
>>> + if (!required_kernelcore || required_kernelcore >= totalpages)
>>> goto out;
>>>
>>> /* usable_startpfn is the lowest possible pfn ZONE_MOVABLE can be at */
>>> --
>>> 2.0.0
>>>
>>>
>>> --
>>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>>> the body to majordomo@kvack.org. For more info on Linux MM,
>>> see: http://www.linux-mm.org/ .
>>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>> .
>>
>
>
> .
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-10-14 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 2:21 [PATCH] mm: skip if required_kernelcore is larger than totalpages Xishi Qiu
2015-10-09 15:41 ` Yasuaki Ishimatsu
2015-10-12 1:37 ` Xishi Qiu
2015-10-14 2:50 ` Tang Chen [this message]
2015-10-14 3:28 ` Xishi Qiu
2015-10-14 4:03 ` Tang Chen
2015-10-16 16:58 ` Yasuaki Ishimatsu
2015-10-14 2:31 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DC30C.70909@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=yasu.isimatu@gmail.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).