From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC572C433E1 for ; Thu, 27 Aug 2020 11:33:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 862C022B40 for ; Thu, 27 Aug 2020 11:33:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 862C022B40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27EA26B002B; Thu, 27 Aug 2020 07:33:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22ED98E0008; Thu, 27 Aug 2020 07:33:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F7476B002E; Thu, 27 Aug 2020 07:33:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id EA8B86B002B for ; Thu, 27 Aug 2020 07:33:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ADA628248D51 for ; Thu, 27 Aug 2020 11:33:31 +0000 (UTC) X-FDA: 77196138222.22.quill71_06006942706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 6F51418038E67 for ; Thu, 27 Aug 2020 11:33:31 +0000 (UTC) X-HE-Tag: quill71_06006942706c X-Filterd-Recvd-Size: 2637 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 11:33:30 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38EF91045; Thu, 27 Aug 2020 04:33:30 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21F033F68F; Thu, 27 Aug 2020 04:33:28 -0700 (PDT) Subject: Re: [PATCH 31/35] kasan, arm64: implement HW_TAGS runtime To: Catalin Marinas , Andrey Konovalov Cc: Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <4e86d422f930831666137e06a71dff4a7a16a5cd.1597425745.git.andreyknvl@google.com> <20200827104517.GH29264@gaia> From: Vincenzo Frascino Message-ID: <567f90b6-fa25-6ef3-73b8-45462cc7ceb2@arm.com> Date: Thu, 27 Aug 2020 12:35:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827104517.GH29264@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6F51418038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/27/20 11:45 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:13PM +0200, Andrey Konovalov wrote: >> diff --git a/mm/kasan/mte.c b/mm/kasan/mte.c >> new file mode 100644 >> index 000000000000..43b7d74161e5 >> --- /dev/null >> +++ b/mm/kasan/mte.c > > Since this is an arm64-specific kasan backend, I wonder whether it makes > more sense to keep it under arch/arm64 (mte-kasan.c). > Yes I agree, I had a similar comment in patch 25. I think we should implement the mte backend entirely in arch code because other architectures might want to enable the feature (e.g. Sparc ADI). >> diff --git a/mm/kasan/report_mte.c b/mm/kasan/report_mte.c >> new file mode 100644 >> index 000000000000..dbbf3aaa8798 >> --- /dev/null >> +++ b/mm/kasan/report_mte.c > > Same for this one. > -- Regards, Vincenzo