From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDF1C6FD19 for ; Thu, 16 Mar 2023 18:05:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D926900003; Thu, 16 Mar 2023 14:05:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7895D900002; Thu, 16 Mar 2023 14:05:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650C3900003; Thu, 16 Mar 2023 14:05:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 557FA900002 for ; Thu, 16 Mar 2023 14:05:37 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 044631A03C7 for ; Thu, 16 Mar 2023 18:05:36 +0000 (UTC) X-FDA: 80575539114.04.A3EA970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 31C618001D for ; Thu, 16 Mar 2023 18:05:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=UIKk2ods; spf=pass (imf30.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678989934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FxRrZ/TC424SEnkEnfzc0MUkd8FLwai8OCJS2Ao9jN8=; b=6EZTijGc8yE+ly9TEl1fc48ThS6qXbI+WpAww9siVvLYspatGv3O172mj27nPO01eyotNx oKefyB+OGUcDPhKnCpWRDU0SE6IqMxWbb0yKH5kYRCTz99/Y2FJNYJ3/vxNObEt0CBW6EW pXesEwVG4UYkvdQ8bWgliVaRoSeQZMs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=UIKk2ods; spf=pass (imf30.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678989934; a=rsa-sha256; cv=none; b=0/2JwvXnaCsu5M94NQpTcInedtZm+JD5YQ3Xb4leYaFhvnGv04Ej2ildPCs45OUFvEc7cr GJJwWP/jzxgNqol349IJ48ax3OOaLD37Ujrc+hVK4G4z/eSX9i6XqYqvkpB1AucKoPu+eY a/AWvQz7rYppTlwLlU43oyKOkwhz5uo= Received: from [192.168.10.39] (unknown [39.37.168.222]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 87F6A66030A0; Thu, 16 Mar 2023 18:05:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678989932; bh=jwiEZNS4tHI3AyhUR5flPCUmaY4pqgMo6a2MuOTvpgc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=UIKk2odsIVHeVbbI48EfWDpxnqExfuk36zZrRLgt0Qmook2AMvSibZKa576mOmHG2 LZmDmyzgeYfKRefHU/slR1yA/TK2MPeJ5YXaiUvcXZn8Axj9106fZHdh/24kzVSNnx HgRG5pUyDAfAiyBfsnW1T2CrEb/Olz29roFry91NjFaUG2zGVEL0HsFIxaKahufTHH RKbUppqFLOPocBRpG1jm490YFHRkzcLTj5KOMRmSntgsEj/tKOEBJzJK/pIbG1NlL9 jvNovDhTa3ZZYMseTC59Kk1llZi/L1UL7KYs8p5rGCxS2p5GW8CHmnon+5TMo6q9i2 YEQv+Q0xzRLVA== Message-ID: <5750b0af-4028-d9c3-8ae8-432713869a81@collabora.com> Date: Thu, 16 Mar 2023 23:05:21 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Cc: Muhammad Usama Anjum , Peter Xu , David Hildenbrand , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WC?= =?UTF-8?Q?aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v11 2/7] userfaultfd: Define dummy uffd_wp_range() Content-Language: en-US To: Mike Rapoport References: <20230309135718.1490461-1-usama.anjum@collabora.com> <20230309135718.1490461-3-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 31C618001D X-Stat-Signature: n31hxi6cebsu3tou7q7t5jdhyzrajg3k X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678989933-357489 X-HE-Meta: U2FsdGVkX19FEZjO6ee4WwYySIkNtUHovxQfFUuqg380PWWWwak3GtMcN0hoDmERB/UJsAOz3AmCYxtplkLG6LVb6SUydEvedQ1i5G3DywJMr0Hvl7oa+HeCI6Cx5xvSEQPMgzXFsxS9AoQNdtjZLCn5GyyNsDECLyfWIWkscdrkZSVcHzuYt9p512+Kiu6KLXNOX6PWK9sUckHTeLLCdUqG2iWkm2M8ks8d+iry+FXc0I/a5o0x4HfWbYrHlk05vZQUAIN55vm80DvoAxRbon7fNDigrrLviPV892v59+WqnpuI+8LbAuupJW5aekKvlJdPSfbG9eAcn9rF39eSjAZ37M76wD97tV1KmDRcES8rtr+KAGdvLS4zfj/cag2oMilO4hKsBcpeEl0PRkafAj6oOELyiW+/ifNslYM4eg7QgmSdxEMg/ibarICzm1xnw4VQmlCZwVFsNm+B3Vc8z+tXMZWUA38lgK8XHi4K4FGg6rTq8a1Ij+hTbjVsk525k+f5iUq9UevXZzyLi81/O0W6wL5zhgzqJb6p9DNTcdQNkHQe8kUwmtRAky1K2nYU1FM6kB9lPxEdiONvbdsX+ztLnqPz7aaIp4ODifkrMyMCVYp0sQ6mTCgUCK7r3W/NnDGiycVIHQEsc1YrJKKDpM+kLaGqL7AnKBzn0G4s9AOkqxmLbhnD+HScodmSsBwXCrdGhnR5PFv0bIs+c8C52uvBaulgJ7XvVvgvZjzn9oXC9Qsg6ialUCVdtbebbVKQXq/6Wjpr6n8RWat/IJoRJVaa7HWMpdg5yNbVRhlXUssrwL1eNBIj0vzb1QbC3FYlxfFMg3tTKbtoZTgTGACCuQ9cgaaDfOBykzEaXIDtvbIZUE/09X6hDBLVK+lzf97INSZLIme2B5iYlu6ZASseBgeucxScaZEAbXoQ+YTErVnM4D+ErjszbUooAHlZMD2QwvUKKjVlmmL9FmKhGoq LjWop33G QQloPt16M9tZaY5j5SdcqmpQPEV0mMh3GfX9GQgKl2+54C6YxwYfSetqhFjjRfm1Gg4yYL/U7s8taFL6a3VwZ9alEbFzoeZN29kv53SxNOf2A+eZa1RB80x53ZJZLwk8Yet5EZEZ1Eg2GgxTV1kxPxTiPwuu/815iipi0tR4bt5mSmUuHL5+Dd46D1xGhYmVX3z3lWknkc/uPbNNnyLdi+Vi4CZJ+QM0N6ZWpX2ewPhSjJ6T5lSqI7FsEZZovJ3iaY2LT3x/8Fca8q85dKgqRsmFG5kYYswuTguVBf8YC+2/KdeKt+l405WVcs/Az++QwGZLbF3xGDYRt2uY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/16/23 12:02 PM, Mike Rapoport wrote: > Hi, > > On Thu, Mar 09, 2023 at 06:57:13PM +0500, Muhammad Usama Anjum wrote: >> Define uffd_wp_range() for the cases when CONFIG_USERFAULTFD isn't set. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> include/linux/userfaultfd_k.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h >> index b680c0ec8b85..fd1a1ecdb5f6 100644 >> --- a/include/linux/userfaultfd_k.h >> +++ b/include/linux/userfaultfd_k.h >> @@ -182,6 +182,14 @@ extern int userfaultfd_wp_async(struct vm_area_struct *vma); >> >> #else /* CONFIG_USERFAULTFD */ >> >> +extern inline long uffd_wp_range(struct mm_struct *dst_mm, > > static inline I'll update. > >> + struct vm_area_struct *vma, >> + unsigned long start, unsigned long len, >> + bool enable_wp) >> +{ >> + return 0; >> +} >> + > > I didn't see uffd_wp_range() defined in the previous patch. > Could be a rebase issue? > > In any case, the stub should be defined in the same patch as the actual > function in order not to break bisectability. This 2/7 patch is a preparatory patch for 3/7 patch. I'll merge both then. > >> /* mm helpers */ >> static inline vm_fault_t handle_userfault(struct vm_fault *vmf, >> unsigned long reason) >> -- >> 2.39.2 >> > -- BR, Muhammad Usama Anjum