From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4397C2D0A3 for ; Fri, 6 Nov 2020 20:46:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EFAE1208C7 for ; Fri, 6 Nov 2020 20:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jlRzl2tq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFAE1208C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 58C056B0036; Fri, 6 Nov 2020 15:46:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 53AAB6B005C; Fri, 6 Nov 2020 15:46:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42A326B005D; Fri, 6 Nov 2020 15:46:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 1694A6B0036 for ; Fri, 6 Nov 2020 15:46:57 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A3476362C for ; Fri, 6 Nov 2020 20:46:56 +0000 (UTC) X-FDA: 77455177632.12.doll02_5d056c2272d5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 85A2418006FB7 for ; Fri, 6 Nov 2020 20:46:56 +0000 (UTC) X-HE-Tag: doll02_5d056c2272d5 X-Filterd-Recvd-Size: 3611 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 20:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=MUfJwre5E6JfpSssfgPC5njfPaSBNYvDAExnUw65edk=; b=jlRzl2tqeKGVbPzs9KiVS7n+DU kUldjBGXOUUw4JFPwbxpJWzLzxyOtenrJsrMVpCXcql/RlicXfF4/Bm44Lu8BKi7Iwrzqmy7GJpcb blg8vfi50BAL26mJAV7D74lqycEXP0UqSNWBazefc3WIwF4TyfkAIJqZfO71RcjnkVOpONPpFVjrv gejTvpk5lcf6HiVRXcBwzSWNmIAhYCRueDokoVms5hHOhMSv4TRy6iBO7qG2n2Xy03kZGF2G5j2gy XskOqKrOoUqhVDca2k+tvG+7XGzmqgHpNxBHjQW6fEBkKS9YsSKcczQN+wQHpR5qbXelqowHvwSFW zNwKgwmg==; Received: from [2601:1c0:6280:3f0::a1cb] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb8dF-0001AO-Ob; Fri, 06 Nov 2020 20:46:50 +0000 Subject: Re: [PATCH] mm: introduce oom_kill_disable sysctl knob To: Minchan Kim , Andrew Morton Cc: LKML , linux-mm , Michal Hocko References: <20201106203238.1375577-1-minchan@kernel.org> From: Randy Dunlap Message-ID: <57a31f2e-bb08-7303-e5fc-fe00e832cee6@infradead.org> Date: Fri, 6 Nov 2020 12:46:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201106203238.1375577-1-minchan@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Fix a few typos: On 11/6/20 12:32 PM, Minchan Kim wrote: > --- > Documentation/admin-guide/sysctl/vm.rst | 14 ++++++++++++++ > include/linux/mm.h | 2 ++ > include/linux/oom.h | 1 + > kernel/sysctl.c | 9 +++++++++ > mm/oom_kill.c | 24 ++++++++++++++++++++++++ > 5 files changed, 50 insertions(+) > > diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst > index f455fa00c00f..49dcedfaf0c0 100644 > --- a/Documentation/admin-guide/sysctl/vm.rst > +++ b/Documentation/admin-guide/sysctl/vm.rst > @@ -694,6 +694,20 @@ is used in oom_kill_allocating_task. > > The default value is 0. > > +oom_kill_disable > +================ > + > +This disables or enables OOM killing in out-of-memory situations. > + > +If this is set to one, the OOM killer is disabled so OOM kill never > +hapens in out-of-memory situation. It could cause system dangerous happens It could cause a dangerous system > +state due to memory allocation failure so user should be careful to careful when > +use it. using it. > + > +If this is set to zero, the OOM killer is enabled so OOM kill happens > +in out-of-memory situations. > + > +The default value is 0. > > overcommit_kbytes > ================= > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 8b84661a6410..0f48cdeeb1e7 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > #ifdef CONFIG_NUMA > /** > * oom_cpuset_eligible() - check task eligiblity for kill eligibility but that's not in your patch, so don't bother with it. :) -- ~Randy