From: zhong jiang <zhongjiang@huawei.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: akpm@linux-foundation.org, mhocko@suse.cz, qiuxishi@huawei.com,
linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: fix mlock incorrent event account
Date: Fri, 26 May 2017 19:05:07 +0800 [thread overview]
Message-ID: <59280BE3.9010302@huawei.com> (raw)
In-Reply-To: <e30ea010-1cee-a1d9-9136-249372ea1640@suse.cz>
On 2017/5/26 17:06, Vlastimil Babka wrote:
> On 05/26/2017 05:54 AM, zhongjiang wrote:
>> From: zhong jiang <zhongjiang@huawei.com>
>>
>> Recently, when I address in the issue, Subject "mlock: fix mlock count
>> can not decrease in race condition" had been take over, I review
>> the code and find the potential issue. it will result in the incorrect
>> account, it will make us misunderstand straightforward.
>>
>> The following testcase can prove the issue.
>>
>> int main(void)
>> {
>> char *map;
>> int fd;
>>
>> fd = open("test", O_CREAT|O_RDWR);
>> unlink("test");
>> ftruncate(fd, 4096);
>> map = mmap(NULL, 4096, PROT_WRITE, MAP_PRIVATE, fd, 0);
>> map[0] = 11;
>> mlock(map, 4096);
>> ftruncate(fd, 0);
>> close(fd);
>> munlock(map, 4096);
>> munmap(map, 4096);
>>
>> return 0;
>> }
>>
>> before:
>> unevictable_pgs_mlocked 10589
>> unevictable_pgs_munlocked 10588
>> unevictable_pgs_cleared 1
>>
>> apply the patch;
>> after:
>> unevictable_pgs_mlocked 9497
>> unevictable_pgs_munlocked 9497
>> unevictable_pgs_cleared 1
>>
>> unmap_mapping_range unmap them, page_remove_rmap will deal with
>> clear_page_mlock situation. we clear page Mlock flag and successful
>> isolate the page, the page will putback the evictable list. but it is not
>> record the munlock event.
>>
>> The patch add the event account when successful page isolation.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Hi,
>
> I think this is by design. UNEVICTABLE_PGMUNLOCKED is supposed for explicit
> munlock() actions from userspace. Truncation etc is counted by
> UNEVICTABLE_PGCLEARED.
>
> Vlastimil
it seems make sense. but the we just mmap the specified ragne and mlock it.
when the process drop out, exit_mmap will call munlock_vma_pages_all to
unmap the mlock range and make the event normal.
Do you think?
Thanks
zhongjinag
>> ---
>> mm/mlock.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/mm/mlock.c b/mm/mlock.c
>> index c483c5c..941930b 100644
>> --- a/mm/mlock.c
>> +++ b/mm/mlock.c
>> @@ -64,6 +64,7 @@ void clear_page_mlock(struct page *page)
>> -hpage_nr_pages(page));
>> count_vm_event(UNEVICTABLE_PGCLEARED);
>> if (!isolate_lru_page(page)) {
>> + count_vm_event(UNEVICTABLE_PGMUNLOCKED);
>> putback_lru_page(page);
>> } else {
>> /*
>>
>
> .
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-26 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 3:54 [PATCH v2] mm: fix mlock incorrent event account zhongjiang
2017-05-26 9:06 ` Vlastimil Babka
2017-05-26 11:05 ` zhong jiang [this message]
2017-05-29 8:07 ` Vlastimil Babka
2017-05-29 7:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59280BE3.9010302@huawei.com \
--to=zhongjiang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).