From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55979C433FE for ; Wed, 16 Feb 2022 02:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFB446B007B; Tue, 15 Feb 2022 21:45:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C838E6B007D; Tue, 15 Feb 2022 21:45:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B23396B007E; Tue, 15 Feb 2022 21:45:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id A458F6B007B for ; Tue, 15 Feb 2022 21:45:41 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5A2328249980 for ; Wed, 16 Feb 2022 02:45:41 +0000 (UTC) X-FDA: 79147102482.31.2FFDD2F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf11.hostedemail.com (Postfix) with ESMTP id 592CE40003 for ; Wed, 16 Feb 2022 02:45:40 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Jz2Jr29D7zZfd2; Wed, 16 Feb 2022 10:41:16 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Feb 2022 10:45:37 +0800 Subject: Re: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio() To: Matthew Wilcox CC: , References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-9-willy@infradead.org> <56e09280-c1dd-6bdb-81f0-524af99c5f4f@huawei.com> From: Miaohe Lin Message-ID: <59c2bef7-d41e-5801-7fc7-e3db77417b2b@huawei.com> Date: Wed, 16 Feb 2022 10:45:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam07 X-Rspam-User: X-Rspamd-Queue-Id: 592CE40003 X-Stat-Signature: hu1tqrgrfjcfek7pgjw47tdfjt87gagg X-HE-Tag: 1644979540-902486 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/16 4:33, Matthew Wilcox wrote: > On Tue, Feb 15, 2022 at 04:26:22PM +0800, Miaohe Lin wrote: >>> + folio_get(folio); >> >> Should we comment the assumption that caller already hold the refcnt? > > Added to the kernel-doc: > + * Context: Caller holds a reference on the page. > I see. Thanks. >> Anyway, this patch looks good to me. Thanks. >> >> Reviewed-by: Miaohe Lin >> >>> + local_lock(&lru_pvecs.lock); >>> + pvec = this_cpu_ptr(&lru_pvecs.lru_deactivate_file); >>> >>> - if (pagevec_add_and_need_flush(pvec, page)) >>> - pagevec_lru_move_fn(pvec, lru_deactivate_file_fn); >>> - local_unlock(&lru_pvecs.lock); >>> - } >>> + if (pagevec_add_and_need_flush(pvec, &folio->page)) >>> + pagevec_lru_move_fn(pvec, lru_deactivate_file_fn); >>> + local_unlock(&lru_pvecs.lock); >>> } >>> >>> /* >>> diff --git a/mm/truncate.c b/mm/truncate.c >>> index 567557c36d45..14486e75ec28 100644 >>> --- a/mm/truncate.c >>> +++ b/mm/truncate.c >>> @@ -525,7 +525,7 @@ static unsigned long __invalidate_mapping_pages(struct address_space *mapping, >>> * of interest and try to speed up its reclaim. >>> */ >>> if (!ret) { >>> - deactivate_file_page(&folio->page); >>> + deactivate_file_folio(folio); >>> /* It is likely on the pagevec of a remote CPU */ >>> if (nr_pagevec) >>> (*nr_pagevec)++; >>> >> >> > . >