From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB79BC433DF for ; Sun, 18 Oct 2020 19:48:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1665E20714 for ; Sun, 18 Oct 2020 19:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="c/QBYw00" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1665E20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F42216B005D; Sun, 18 Oct 2020 15:48:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECBE56B0062; Sun, 18 Oct 2020 15:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D92C56B0068; Sun, 18 Oct 2020 15:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id A83FD6B005D for ; Sun, 18 Oct 2020 15:48:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4E1A43629 for ; Sun, 18 Oct 2020 19:48:38 +0000 (UTC) X-FDA: 77386083516.10.men25_560500d27231 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 2BB9816A044 for ; Sun, 18 Oct 2020 19:48:38 +0000 (UTC) X-HE-Tag: men25_560500d27231 X-Filterd-Recvd-Size: 4357 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 19:48:37 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 18 Oct 2020 12:48:24 -0700 Received: from [10.2.63.174] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 18 Oct 2020 19:48:35 +0000 Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h To: Linus Torvalds CC: Matthew Wilcox , Andrew Morton , Jonathan Corbet , Jerome Glisse , Linux-MM , , Ralph Campbell , "Shuah Khan" , Jason Gary Gunthorpe References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org>

<20201018190327.GN20115@casper.infradead.org> <9eaf122b-e877-e104-6175-13d48c13ac85@nvidia.com> From: John Hubbard Message-ID: <59c6b448-039a-e56b-1ec6-9f92e316acb0@nvidia.com> Date: Sun, 18 Oct 2020 12:48:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603050504; bh=sgKQZvv8dgiX3aa5kXPg8KatB4IM31nDa6mZJO9a4yk=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=c/QBYw00/bzt1fRqaHsANWEKBMOHQUUz3HCd1WyJSJ5Yb+ZNh36UpvzbpOqxAmnCo IWOAXK8Y2LfogqcjdLgw6JhL4oKyhapWZ1DIlvhv4nl0zluTvDweOTDdFAx0CVnPM9 71ZXQviwIPcovOq6EqyWY1XEbWOTBhf/t/mDppm7zTtTkS3QZ072NCsMOFEA1aI7Wt oRwVQp6A1gu6o6Mvd3vpCQ6YPn0KNGrwZgVxK364xTa8dfizdxuRHQ5v9m8Mrkw6GS fJHJztlALFzmUl5ov9LhugHhHIkXekEAnHYX97IBrqn53qjp8mFYejqhyEUan32fRc HiDN/C3sjIJUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/18/20 12:33 PM, Linus Torvalds wrote: > On Sun, Oct 18, 2020 at 12:13 PM John Hubbard wrote: ... > Guys, you're looking at the wrong thing. > > Inside the *tools* subdirectory, that "../../.." thing makes sense. > You're in tools/testing/selftests/vm, and those crazy ".." paths are > ok. Ugly, but ok. > > But the thing I objected to wasn't that tools directory ugliness. > > Let me repeat what I found completely and utterly unacceptable, and > what you don't seem to have noticed, and what your patch didn't fix or > touch: > > +++ a/mm/gup_test.c > +#include "../../../../mm/gup_test.h" > > Notice what directory it is in? Notice how "../../.." etc is > COMPLETELY UNACCEPTABLE GARBAGE. > > Linus > aha, yes. yuck. So can we please just fix it up like this? A quick compile test shows that it does build as expected: diff --git a/mm/gup_test.c b/mm/gup_test.c index 32770656cc32..e4c396146e90 100644 --- a/mm/gup_test.c +++ b/mm/gup_test.c @@ -4,7 +4,7 @@ #include #include #include -#include "../../../../mm/gup_test.h" +#include "gup_test.h" static void put_back_pages(unsigned int cmd, struct page **pages, unsigned long nr_pages, unsigned int gup_test_flags) Meanwhile, I'll work on coming up with a rationalization for how I let that mistake slip past me. I've got a teenager living under the same roof with me here, so I'm routinely exposed to some truly inspirational ideas for excuses. :) thanks, -- John Hubbard NVIDIA