From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1581DC433E1 for ; Fri, 21 Aug 2020 04:20:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D13532076E for ; Fri, 21 Aug 2020 04:20:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D13532076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A5C98D0013; Fri, 21 Aug 2020 00:20:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 657298D000A; Fri, 21 Aug 2020 00:20:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5455D8D0013; Fri, 21 Aug 2020 00:20:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 3EF948D000A for ; Fri, 21 Aug 2020 00:20:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 09336824556B for ; Fri, 21 Aug 2020 04:20:56 +0000 (UTC) X-FDA: 77173275312.17.cream67_5f0f1d727036 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id C4EC3180D0181 for ; Fri, 21 Aug 2020 04:20:55 +0000 (UTC) X-HE-Tag: cream67_5f0f1d727036 X-Filterd-Recvd-Size: 6889 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 04:20:55 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AD4431B; Thu, 20 Aug 2020 21:20:54 -0700 (PDT) Received: from [10.163.67.49] (unknown [10.163.67.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64AA13F6CF; Thu, 20 Aug 2020 21:20:52 -0700 (PDT) Subject: Re: [PATCH v2 00/13] mm/debug_vm_pgtable fixes To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org References: <20200819130107.478414-1-aneesh.kumar@linux.ibm.com> <87tuwyvjei.fsf@linux.ibm.com> <856eb6d7-9c09-728e-b374-d787145ac052@arm.com> From: Anshuman Khandual Message-ID: <59e02206-6056-6272-cc89-cc7e4588c69b@arm.com> Date: Fri, 21 Aug 2020 09:50:21 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <856eb6d7-9c09-728e-b374-d787145ac052@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: C4EC3180D0181 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/21/2020 09:03 AM, Anshuman Khandual wrote: >=20 >=20 > On 08/19/2020 07:15 PM, Aneesh Kumar K.V wrote: >> "Aneesh Kumar K.V" writes: >> >>> This patch series includes fixes for debug_vm_pgtable test code so th= at >>> they follow page table updates rules correctly. The first two patches= introduce >>> changes w.r.t ppc64. The patches are included in this series for comp= leteness. We can >>> merge them via ppc64 tree if required. >>> >>> Hugetlb test is disabled on ppc64 because that needs larger change to= satisfy >>> page table update rules. >>> >>> Changes from V1: >>> * Address review feedback >>> * drop test specific pfn_pte and pfn_pmd. >>> * Update ppc64 page table helper to add _PAGE_PTE=20 >>> >>> Aneesh Kumar K.V (13): >>> powerpc/mm: Add DEBUG_VM WARN for pmd_clear >>> powerpc/mm: Move setting pte specific flags to pfn_pte >>> mm/debug_vm_pgtable/ppc64: Avoid setting top bits in radom value >>> mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge >>> vmap support. >>> mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with >>> CONFIG_NUMA_BALANCING >>> mm/debug_vm_pgtable/THP: Mark the pte entry huge before using >>> set_pmd/pud_at >>> mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update a= n >>> existing pte entry >>> mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP >>> mm/debug_vm_pgtable/locks: Move non page table modifying test toget= her >>> mm/debug_vm_pgtable/locks: Take correct page table lock >>> mm/debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entri= es >>> mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 >>> mm/debug_vm_pgtable: populate a pte entry before fetching it >>> >>> arch/powerpc/include/asm/book3s/64/pgtable.h | 29 +++- >>> arch/powerpc/include/asm/nohash/pgtable.h | 5 - >>> arch/powerpc/mm/book3s64/pgtable.c | 2 +- >>> arch/powerpc/mm/pgtable.c | 5 - >>> include/linux/io.h | 12 ++ >>> mm/debug_vm_pgtable.c | 151 +++++++++++------= -- >>> 6 files changed, 127 insertions(+), 77 deletions(-) >>> >> >> BTW I picked a wrong branch when sending this. Attaching the diff >> against what I want to send. pfn_pmd() no more updates _PAGE_PTE >> because that is handled by pmd_mkhuge(). >> >> diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book= 3s64/pgtable.c >> index 3b4da7c63e28..e18ae50a275c 100644 >> --- a/arch/powerpc/mm/book3s64/pgtable.c >> +++ b/arch/powerpc/mm/book3s64/pgtable.c >> @@ -141,7 +141,7 @@ pmd_t pfn_pmd(unsigned long pfn, pgprot_t pgprot) >> unsigned long pmdv; >> =20 >> pmdv =3D (pfn << PAGE_SHIFT) & PTE_RPN_MASK; >> - return __pmd(pmdv | pgprot_val(pgprot) | _PAGE_PTE); >> + return pmd_set_protbits(__pmd(pmdv), pgprot); >> } >> =20 >> pmd_t mk_pmd(struct page *page, pgprot_t pgprot) >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 7d9f8e1d790f..cad61d22f33a 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -229,7 +229,7 @@ static void __init pmd_huge_tests(pmd_t *pmdp, uns= igned long pfn, pgprot_t prot) >> =20 >> static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t p= rot) >> { >> - pmd_t pmd =3D pfn_pmd(pfn, prot); >> + pmd_t pmd =3D pmd_mkhuge(pfn_pmd(pfn, prot)); >> =20 >> if (!IS_ENABLED(CONFIG_NUMA_BALANCING)) >> return; >> >=20 > Cover letter does not mention which branch or tag this series applies o= n. > Just assumed it to be 5.9-rc1. Should the above changes be captured as = a > pre-requisite patch ? >=20 > Anyways, the series fails to be build on arm64. >=20 > A) Without CONFIG_TRANSPARENT_HUGEPAGE >=20 > mm/debug_vm_pgtable.c: In function =E2=80=98debug_vm_pgtable=E2=80=99: > mm/debug_vm_pgtable.c:1045:2: error: too many arguments to function =E2= =80=98pmd_advanced_tests=E2=80=99 > pmd_advanced_tests(mm, vma, pmdp, pmd_aligned, vaddr, prot, saved_pte= p); > ^~~~~~~~~~~~~~~~~~ > mm/debug_vm_pgtable.c:366:20: note: declared here > static void __init pmd_advanced_tests(struct mm_struct *mm, > ^~~~~~~~~~~~~~~~~~ >=20 > B) As mentioned previously, this should be solved by including >=20 > mm/debug_vm_pgtable.c: In function =E2=80=98pmd_huge_tests=E2=80=99: > mm/debug_vm_pgtable.c:215:7: error: implicit declaration of function =E2= =80=98arch_ioremap_pmd_supported=E2=80=99; did you mean =E2=80=98arch_dis= able_smp_support=E2=80=99? [-Werror=3Dimplicit-function-declaration] > if (!arch_ioremap_pmd_supported()) > ^~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > Please make sure that the series builds on all enabled platforms i.e x8= 6, > arm64, ppc32, ppc64, arc, s390 along with selectively enabling/disablin= g > all the features that make various #ifdefs in the test. >=20 > - Anshuman Here is another build failure on x86. mm/debug_vm_pgtable.c: In function =E2=80=98pud_advanced_tests=E2=80=99: mm/debug_vm_pgtable.c:306:31: error: passing argument 1 of =E2=80=98pudp_= huge_get_and_clear_full=E2=80=99 from incompatible pointer type [-Werror=3D= incompatible-pointer-types] pudp_huge_get_and_clear_full(vma, vaddr, pudp, 1); ^~~ In file included from ./include/linux/mm.h:33:0, from ./include/linux/highmem.h:8, from mm/debug_vm_pgtable.c:14: ./include/linux/pgtable.h:294:21: note: expected =E2=80=98struct mm_struc= t *=E2=80=99 but argument is of type =E2=80=98struct vm_area_struct *=E2=80= =99 static inline pud_t pudp_huge_get_and_clear_full(struct mm_struct *mm,