From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA66C433E0 for ; Thu, 30 Jul 2020 13:31:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 760B6206D8 for ; Thu, 30 Jul 2020 13:31:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 760B6206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F07CC6B0005; Thu, 30 Jul 2020 09:31:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90FD8D0001; Thu, 30 Jul 2020 09:31:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58E36B000A; Thu, 30 Jul 2020 09:31:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id BBC556B0005 for ; Thu, 30 Jul 2020 09:31:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5294F8248D7C for ; Thu, 30 Jul 2020 13:31:51 +0000 (UTC) X-FDA: 77094830022.25.nerve40_380909026f7b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 603141804E509 for ; Thu, 30 Jul 2020 13:31:47 +0000 (UTC) X-HE-Tag: nerve40_380909026f7b X-Filterd-Recvd-Size: 2782 Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jul 2020 13:31:45 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.75,414,1589212800"; d="scan'208";a="97117494" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 30 Jul 2020 21:31:42 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id 3DF554CE506F; Thu, 30 Jul 2020 21:31:38 +0800 (CST) Received: from [10.167.220.69] (10.167.220.69) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Jul 2020 21:31:39 +0800 Message-ID: <5F22CBB9.1080905@cn.fujitsu.com> Date: Thu, 30 Jul 2020 21:31:37 +0800 From: Xiao Yang User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Xiao Yang CC: , , Subject: Re: [PATCH] mm/slab.c: Update outdated kmem_list3 in a comment References: <20200722033355.26908-1-yangx.jy@cn.fujitsu.com> In-Reply-To: <20200722033355.26908-1-yangx.jy@cn.fujitsu.com> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.220.69] X-ClientProxiedBy: G08CNEXCHPEKD06.g08.fujitsu.local (10.167.33.205) To G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) X-yoursite-MailScanner-ID: 3DF554CE506F.AB027 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com X-Rspamd-Queue-Id: 603141804E509 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Ping. On 2020/7/22 11:33, Xiao Yang wrote: > kmem_list3 has been renamed to kmem_cache_node long long > ago so update it. > > References: > '6744f087ba2a ("slab: Common name for the per node structures")' > 'ce8eb6c424c7 ("slab: Rename list3/l3 to node")' > > Signed-off-by: Xiao Yang > --- > mm/slab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 9350062ffc1a..a7988aeb9bc3 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1050,7 +1050,7 @@ int slab_prepare_cpu(unsigned int cpu) > * offline. > * > * Even if all the cpus of a node are down, we don't free the > - * kmem_list3 of any cache. This to avoid a race between cpu_down, and > + * kmem_cache_node of any cache. This to avoid a race between cpu_down, and > * a kmalloc allocation from another cpu for memory from the node of > * the cpu going down. The list3 structure is usually allocated from > * kmem_cache_create() and gets destroyed at kmem_cache_destroy().