From: Randy Dunlap <rdunlap@infradead.org>
To: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: mmotm 2020-01-21-13-28 uploaded (convert everything to struct proc_ops)
Date: Tue, 21 Jan 2020 18:25:34 -0800 [thread overview]
Message-ID: <5a81ab98-4f02-f415-4da5-3d5685915a0e@infradead.org> (raw)
In-Reply-To: <20200121212915.APuBK%akpm@linux-foundation.org>
On 1/21/20 1:29 PM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2020-01-21-13-28 has been uploaded to
>
> http://www.ozlabs.org/~akpm/mmotm/
>
> mmotm-readme.txt says
>
> README for mm-of-the-moment:
>
> http://www.ozlabs.org/~akpm/mmotm/
>
> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> more than once a week.
NULL seems to be misspelled as NUL in the proc-convert-everything-to-struct-proc_ops.patch
patch for kernel/sched/psi.c:
static int __init psi_proc_init(void)
{
if (psi_enable) {
proc_mkdir("pressure", NULL);
- proc_create("pressure/io", 0, NULL, &psi_io_fops);
- proc_create("pressure/memory", 0, NULL, &psi_memory_fops);
- proc_create("pressure/cpu", 0, NULL, &psi_cpu_fops);
+ proc_create("pressure/io", 0, NULL, &psi_io_proc_ops);
+ proc_create("pressure/memory", 0, NUL, &psi_memory_proc_ops); <<<<<<<<<<
+ proc_create("pressure/cpu", 0, NULL &psi_cpu_proc_ops);
also missing a comma above...
}
return 0;
../kernel/sched/psi.c: In function ‘psi_proc_init’:
../kernel/sched/psi.c:1286:37: error: ‘NUL’ undeclared (first use in this function); did you mean ‘_UL’?
proc_create("pressure/memory", 0, NUL, &psi_memory_proc_ops);
^~~
_UL
../kernel/sched/psi.c:1286:37: note: each undeclared identifier is reported only once for each function it appears in
../kernel/sched/psi.c:1287:39: error: invalid operands to binary & (have ‘void *’ and ‘const struct proc_ops’)
proc_create("pressure/cpu", 0, NULL &psi_cpu_proc_ops);
^
../kernel/sched/psi.c:1287:3: error: too few arguments to function ‘proc_create’
proc_create("pressure/cpu", 0, NULL &psi_cpu_proc_ops);
^~~~~~~~~~~
In file included from ../kernel/sched/psi.c:133:0:
../include/linux/proc_fs.h:64:24: note: declared here
struct proc_dir_entry *proc_create(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct proc_ops *proc_ops);
^~~~~~~~~~~
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
next prev parent reply other threads:[~2020-01-22 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 21:29 mmotm 2020-01-21-13-28 uploaded akpm
2020-01-22 2:25 ` Randy Dunlap [this message]
2020-01-22 3:19 ` mmotm 2020-01-21-13-28 uploaded (struct proc_ops) Randy Dunlap
2020-01-26 15:07 ` Alexey Dobriyan
2020-01-22 3:54 ` mmotm 2020-01-21-13-28 uploaded (drivers/gpu/drm/i915/gt/intel_lrc.c) Randy Dunlap
2020-01-22 4:47 ` mmotm 2020-01-21-13-28 uploaded (nouveau) Randy Dunlap
2020-01-22 4:56 ` mmotm 2020-01-21-13-28 uploaded (smack) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a81ab98-4f02-f415-4da5-3d5685915a0e@infradead.org \
--to=rdunlap@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).