From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
npiggin@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] powerpc/mm: call H_BLOCK_REMOVE when supported
Date: Thu, 12 Sep 2019 19:50:14 +0530 [thread overview]
Message-ID: <5bcd3da7-1bc2-f3f9-3ed2-e3aa0bb540bd@linux.ibm.com> (raw)
In-Reply-To: <20190830120712.22971-4-ldufour@linux.ibm.com>
On 8/30/19 5:37 PM, Laurent Dufour wrote:
> Instead of calling H_BLOCK_REMOVE all the time when the feature is
> exhibited, call this hcall only when the couple base page size, page size
> is supported as reported by the TLB Invalidate Characteristics.
>
supported is not actually what we are checking here. We are checking
whether the base page size actual page size remove can be done in chunks
of 8 blocks. If we don't support 8 block you fallback to bulk
invalidate. May be update the commit message accordingly?
> For regular pages and hugetlb, the assumption is made that the page size is
> equal to the base page size. For THP the page size is assumed to be 16M.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
> arch/powerpc/platforms/pseries/lpar.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c
> index 375e19b3cf53..ef3dbf108a65 100644
> --- a/arch/powerpc/platforms/pseries/lpar.c
> +++ b/arch/powerpc/platforms/pseries/lpar.c
> @@ -1143,7 +1143,11 @@ static inline void __pSeries_lpar_hugepage_invalidate(unsigned long *slot,
> if (lock_tlbie)
> spin_lock_irqsave(&pSeries_lpar_tlbie_lock, flags);
>
> - if (firmware_has_feature(FW_FEATURE_BLOCK_REMOVE))
> + /*
> + * Assuming THP size is 16M, and we only support 8 bytes size buffer
> + * for the momment.
> + */
> + if (mmu_psize_defs[psize].hblk[MMU_PAGE_16M] == 8)
> hugepage_block_invalidate(slot, vpn, count, psize, ssize);
> else
> hugepage_bulk_invalidate(slot, vpn, count, psize, ssize);
So we don't use block invalidate if blocksize is != 8.
> @@ -1437,7 +1441,10 @@ static void pSeries_lpar_flush_hash_range(unsigned long number, int local)
> if (lock_tlbie)
> spin_lock_irqsave(&pSeries_lpar_tlbie_lock, flags);
>
> - if (firmware_has_feature(FW_FEATURE_BLOCK_REMOVE)) {
> + /*
> + * Currently, we only support 8 bytes size buffer in do_block_remove().
> + */
> + if (mmu_psize_defs[batch->psize].hblk[batch->psize] == 8) {
> do_block_remove(number, batch, param);
> goto out;
> }
>
-aneesh
next prev parent reply other threads:[~2019-09-12 14:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 12:07 [PATCH 0/3] powerpc/mm: Conditionally call H_BLOCK_REMOVE Laurent Dufour
2019-08-30 12:07 ` [PATCH 1/3] powerpc/mm: Initialize the HPTE encoding values Laurent Dufour
2019-09-12 13:32 ` Aneesh Kumar K.V
2019-09-12 13:37 ` Aneesh Kumar K.V
2019-09-13 10:56 ` Laurent Dufour
2019-08-30 12:07 ` [PATCH 2/3] powperc/mm: read TLB Block Invalidate Characteristics Laurent Dufour
2019-09-12 14:16 ` Aneesh Kumar K.V
2019-09-13 13:55 ` Laurent Dufour
2019-09-12 14:44 ` Aneesh Kumar K.V
2019-09-12 19:26 ` Laurent Dufour
2019-09-13 2:00 ` Aneesh Kumar K.V
2019-09-13 9:10 ` Laurent Dufour
2019-08-30 12:07 ` [PATCH 3/3] powerpc/mm: call H_BLOCK_REMOVE when supported Laurent Dufour
2019-09-12 14:20 ` Aneesh Kumar K.V [this message]
2019-09-13 13:16 ` Laurent Dufour
2019-09-12 13:44 ` [PATCH 0/3] powerpc/mm: Conditionally call H_BLOCK_REMOVE Aneesh Kumar K.V
2019-09-13 11:09 ` Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bcd3da7-1bc2-f3f9-3ed2-e3aa0bb540bd@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).