From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF4CC433E6 for ; Tue, 1 Sep 2020 07:51:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4343C2083B for ; Tue, 1 Sep 2020 07:51:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4343C2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D56528E0001; Tue, 1 Sep 2020 03:51:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D064A6B0062; Tue, 1 Sep 2020 03:51:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C42978E0001; Tue, 1 Sep 2020 03:51:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AEAF56B005D for ; Tue, 1 Sep 2020 03:51:29 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 80CC8180AD804 for ; Tue, 1 Sep 2020 07:51:29 +0000 (UTC) X-FDA: 77213722698.23.quiet59_5512e9b27096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 4B57037606 for ; Tue, 1 Sep 2020 07:51:29 +0000 (UTC) X-HE-Tag: quiet59_5512e9b27096 X-Filterd-Recvd-Size: 4058 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 07:51:28 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BgfQj5ZqZz9v4j1; Tue, 1 Sep 2020 09:51:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id otG6xobMGX17; Tue, 1 Sep 2020 09:51:25 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BgfQj4hHYz9v1SD; Tue, 1 Sep 2020 09:51:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A99F68B774; Tue, 1 Sep 2020 09:51:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 0bfitLpUFTsu; Tue, 1 Sep 2020 09:51:26 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C8C8D8B75E; Tue, 1 Sep 2020 09:51:25 +0200 (CEST) Subject: Re: [PATCH v3 08/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP To: "Aneesh Kumar K.V" , Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, Gerald Schaefer , Vineet Gupta , Mike Rapoport , Qian Cai References: <20200827080438.315345-1-aneesh.kumar@linux.ibm.com> <20200827080438.315345-9-aneesh.kumar@linux.ibm.com> <9beaaf93-b2dd-6d56-7737-9f022760f246@linux.ibm.com> <2fb4ac88-d417-2bdd-3c56-a816c356636a@linux.ibm.com> From: Christophe Leroy Message-ID: <5d25b02a-887a-432e-7ecd-cc5cbcea9b02@csgroup.eu> Date: Tue, 1 Sep 2020 09:51:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <2fb4ac88-d417-2bdd-3c56-a816c356636a@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr X-Rspamd-Queue-Id: 4B57037606 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 01/09/2020 =C3=A0 09:40, Aneesh Kumar K.V a =C3=A9crit=C2=A0: > On 9/1/20 12:20 PM, Christophe Leroy wrote: >> >> >> Le 01/09/2020 =C3=A0 08:25, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >>> On 9/1/20 8:52 AM, Anshuman Khandual wrote: >>>> >>>> >>>> >>>> There is a checkpatch.pl warning here. >>>> >>>> WARNING: Possible unwrapped commit description (prefer a maximum 75=20 >>>> chars per line) >>>> #7: >>>> Architectures like ppc64 use deposited page table while updating the= =20 >>>> huge pte >>>> >>>> total: 0 errors, 1 warnings, 40 lines checked >>>> >>> >>> I will ignore all these, because they are not really important IMHO. >>> >> >> When doing a git log in a 80 chars terminal window, having wrapping=20 >> lines is not really convenient. It should be easy to avoid it. >> >=20 > We have been ignoring that for a long time=C2=A0 isn't it? >=20 > For example ppc64 checkpatch already had > --max-line-length=3D90 >=20 >=20 > There was also recent discussion whether 80 character limit is valid an= y=20 > more. But I do keep it restricted to 80 character where ever it is=20 > easy/make sense. >=20 Here we are not talking about the code, but the commit log. As far as I know, the discussions about 80 character lines, 90 lines in=20 powerpc etc ... is for the code. We still aim at keeping lines not longer than 75 chars in the commit log. Christophe Christophe