From: Dave Hansen <dave.hansen@intel.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ben.widawsky@intel.com, alex.shi@linux.alibaba.com,
tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org,
stable@kernel.org
Subject: Re: [PATCH] mm/vmscan: restore zone_reclaim_mode ABI
Date: Mon, 29 Jun 2020 09:05:04 -0700 [thread overview]
Message-ID: <5d568f0d-b49b-6c31-db6c-02cb26c3b8a2@intel.com> (raw)
In-Reply-To: <20200629155302.6okkufqmj3kupvzw@beryllium.lan>
On 6/29/20 8:53 AM, Daniel Wagner wrote:
> On Mon, Jun 29, 2020 at 07:36:15AM -0700, Dave Hansen wrote:
>> On 6/29/20 12:13 AM, Daniel Wagner wrote:
>>> I went to go add a new RECLAIM_* mode for the zone_reclaim_mode
>>> sysctl.
>>
>> This conveys my motivation.
>
> You don't need to tell a story.
Interesting! I literally tell folks all the time that their changelogs
*should* tell a story. :)
I think this is clearly a case where you and I have differing personal
opinions on style. I understand what you are asking for, and this is
usually a case where our friendly maintainers can help out of they have
a strong preference either way.
> As explained in the documetation 'Describe your changes', describe
> your change in imperative mood, e.g. something like
>
> "Add RECLAIM_* mode for the the zone_reclaim_mode sysctl."
This is my personal opinion, but I think this interpretation takes the
documentation a bit too literally. The documentation speaking about
"imperative mood" applies specifically to the language about your fix,
it does not apply to the background.
It is there to encourage contributors to avoid some of the more passive
language like:
This patch does blah.... This patch fixes blah...
next prev parent reply other threads:[~2020-06-29 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 0:34 [PATCH] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-06-26 7:59 ` Daniel Wagner
2020-06-26 13:53 ` Dave Hansen
2020-06-29 7:13 ` Daniel Wagner
2020-06-29 14:36 ` Dave Hansen
2020-06-29 15:53 ` Daniel Wagner
2020-06-29 16:05 ` Dave Hansen [this message]
[not found] ` <20200626192426.GA4329@lca.pw>
2020-06-26 21:24 ` Dave Hansen
2020-06-29 6:52 ` Baoquan He
2020-06-29 14:27 ` Dave Hansen
2020-06-29 23:30 ` Baoquan He
2020-06-29 23:37 ` Dave Hansen
2020-07-01 2:47 ` Andrew Morton
2020-07-01 15:27 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d568f0d-b49b-6c31-db6c-02cb26c3b8a2@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=ben.widawsky@intel.com \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@kernel.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).