From: Mike Kravetz <mike.kravetz@oracle.com>
To: yuyufen <yuyufen@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Michal Hocko <mhocko@kernel.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: always use address space in inode for resv_map pointer
Date: Wed, 8 May 2019 13:16:09 -0700 [thread overview]
Message-ID: <5d7dc0d5-7cd3-eb95-a1e7-9c68fe393647@oracle.com> (raw)
In-Reply-To: <fafe9985-7db1-b65c-523d-875ab4b3b3b8@huawei.com>
On 5/8/19 12:10 AM, yuyufen wrote:
> On 2019/4/20 4:44, Mike Kravetz wrote:
>> Continuing discussion about commit 58b6e5e8f1ad ("hugetlbfs: fix memory
>> leak for resv_map") brought up the issue that inode->i_mapping may not
>> point to the address space embedded within the inode at inode eviction
>> time. The hugetlbfs truncate routine handles this by explicitly using
>> inode->i_data. However, code cleaning up the resv_map will still use
>> the address space pointed to by inode->i_mapping. Luckily, private_data
>> is NULL for address spaces in all such cases today but, there is no
>> guarantee this will continue.
>>
>> Change all hugetlbfs code getting a resv_map pointer to explicitly get
>> it from the address space embedded within the inode. In addition, add
>> more comments in the code to indicate why this is being done.
>>
>> Reported-by: Yufen Yu <yuyufen@huawei.com>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
...
>
> Dose this patch have been applied?
Andrew has pulled it into his tree. However, I do not believe there has
been an ACK or Review, so am not sure of the exact status.
> I think it is better to add fixes label, like:
> Fixes: 58b6e5e8f1ad ("hugetlbfs: fix memory leak for resv_map")
>
> Since the commit 58b6e5e8f1a has been merged to stable, this patch also be needed.
> https://www.spinics.net/lists/stable/msg298740.html
It must have been the AI that decided 58b6e5e8f1a needed to go to stable.
Even though this technically does not fix 58b6e5e8f1a, I'm OK with adding
the Fixes: to force this to go to the same stable trees.
--
Mike Kravetz
next prev parent reply other threads:[~2019-05-08 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 4:02 [PATCH] hugetlbfs: move resv_map to hugetlbfs_inode_info Yufen Yu
2019-04-12 23:40 ` Mike Kravetz
2019-04-13 11:57 ` yuyufen
2019-04-15 6:16 ` Naoya Horiguchi
2019-04-15 9:15 ` Michal Hocko
2019-04-15 17:11 ` Mike Kravetz
2019-04-15 23:59 ` Naoya Horiguchi
2019-04-16 0:37 ` Mike Kravetz
2019-04-16 6:50 ` Michal Hocko
2019-04-19 20:44 ` [PATCH] hugetlbfs: always use address space in inode for resv_map pointer Mike Kravetz
2019-05-08 7:10 ` yuyufen
2019-05-08 20:16 ` Mike Kravetz [this message]
2019-05-09 23:11 ` Andrew Morton
2019-05-09 23:32 ` Mike Kravetz
2019-04-16 12:57 ` [PATCH] hugetlbfs: move resv_map to hugetlbfs_inode_info yuyufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7dc0d5-7cd3-eb95-a1e7-9c68fe393647@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).