From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D139DC47E4B for ; Thu, 15 Jul 2021 08:35:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60D8561358 for ; Thu, 15 Jul 2021 08:35:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60D8561358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 365A48D00A3; Thu, 15 Jul 2021 04:35:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EF218D0065; Thu, 15 Jul 2021 04:35:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11B148D00A3; Thu, 15 Jul 2021 04:35:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id DD4BA8D0065 for ; Thu, 15 Jul 2021 04:35:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B02E822AAF for ; Thu, 15 Jul 2021 08:35:15 +0000 (UTC) X-FDA: 78364162590.25.7DC7D8E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf23.hostedemail.com (Postfix) with ESMTP id CA258900072E for ; Thu, 15 Jul 2021 08:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626338114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yi9obYV2IFRXQcU5OjCWyacMaSnPkoEY5XTUowFAJiA=; b=QY3UlvQKTFBw7KtnAyfarbb15LRCTHoH0yTuLS9YPQRTjQN5a8D67n5VSzZCQBrSaIVlB9 4QSS62jW02RiTVBCtFix4bPKuNiWm0dg+zWehbW0ZDRKrrsjzUKkb6iF4PotkLuK1pqvHj LPcHAETy0pkz7ZqV9MFbPY2yfjGqu+w= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-lfz6HJfMNryodCY-Oz90UA-1; Thu, 15 Jul 2021 04:35:12 -0400 X-MC-Unique: lfz6HJfMNryodCY-Oz90UA-1 Received: by mail-wr1-f69.google.com with SMTP id m9-20020a0560000089b02901362e1cd6a3so2940535wrx.13 for ; Thu, 15 Jul 2021 01:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:cc:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Yi9obYV2IFRXQcU5OjCWyacMaSnPkoEY5XTUowFAJiA=; b=iu8SBU6ysz+niyhvFqD+UpFIdMsqDcePzUAqy9sZeJ1BTwtUmjMRDTipd6RH6zu8hf jW/5t8OitiD8eTuzpEaCpHK//hoxlNwjkq4bItt4I4dmLzDVAX94k62KXESBWfKSEAe9 aU/ph+YlReIeBP2gH1IXc5OW4ze18S8tODCvy8Qlzehr9tziakPgWftf8UBS08z1G5ng D3tdrg6GS66TBsS2BBgVL0q9dFMWeghG46MxkXfO3DJaDUHmskRBXkBwJdslh1Q6cqtl oV0qdIhSff9C5fYEVoDoipReCvj0CJka76tSixpeK2UTgD+vbmD4clMhacMxNEt2/iSM Kc5g== X-Gm-Message-State: AOAM530SYE856sXFpF6mdk8k36/MGQJPaXcvinLKwe8fdl3Ej8xDDm2M Bm6UbrN5+L0FeKNsmVyGrWPyC/VjmljMEYwCztnJZKbfZK42N+m4DoyzQmAD7QM4e54KMahMXxa JI3DMXhxAwhE= X-Received: by 2002:a5d:50c7:: with SMTP id f7mr4007242wrt.126.1626338111391; Thu, 15 Jul 2021 01:35:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOcHackGTT36UUmS+7YRBiz7L/liYJnRUoJLQrhvcqPYVpB5MzgW5RyeKFX9AYIL0Pg+nx6Q== X-Received: by 2002:a5d:50c7:: with SMTP id f7mr4007203wrt.126.1626338111178; Thu, 15 Jul 2021 01:35:11 -0700 (PDT) Received: from [192.168.42.238] (3-14-107-185.static.kviknet.dk. [185.107.14.3]) by smtp.gmail.com with ESMTPSA id d10sm5342281wro.43.2021.07.15.01.35.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 01:35:10 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Cc: brouer@redhat.com, Desmond Cheong Zhi Xi , Zhang Qiang , Yanfei Xu , Chuck Lever , Matteo Croce , Linux-MM , LKML , bpf Subject: Re: [PATCH 4/4] Revert "mm/page_alloc: make should_fail_alloc_page() static" To: John Hubbard , Mel Gorman , Andrew Morton , acme@kernel.org, Jiri Olsa References: <20210713152100.10381-1-mgorman@techsingularity.net> <20210713152100.10381-5-mgorman@techsingularity.net> Message-ID: <5db9011e-9b52-b415-70b6-c7ee1b01436b@redhat.com> Date: Thu, 15 Jul 2021 10:35:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CA258900072E X-Stat-Signature: 3ker8zq6xcn45g3psmkc5s6ybmrba54a Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QY3UlvQK; spf=none (imf23.hostedemail.com: domain of jbrouer@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1626338114-345852 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Cc. Jiri Olsa + Arnaldo On 14/07/2021 09.06, John Hubbard wrote: > On 7/13/21 8:21 AM, Mel Gorman wrote: >> From: Matteo Croce >> >> This reverts commit f7173090033c70886d925995e9dfdfb76dbb2441. >> >> Fix an unresolved symbol error when CONFIG_DEBUG_INFO_BTF=3Dy: >> >> =C2=A0=C2=A0 LD=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vmlinux >> =C2=A0=C2=A0 BTFIDS=C2=A0 vmlinux >> FAILED unresolved symbol should_fail_alloc_page >> make: *** [Makefile:1199: vmlinux] Error 255 >> make: *** Deleting file 'vmlinux' >=20 > Yes! I ran into this yesterday. Your patch fixes this build failure > for me, so feel free to add: >=20 > Tested-by: John Hubbard >=20 >=20 > However, I should add that I'm still seeing another build failure, afte= r > fixing the above: >=20 > LD=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vmlinux > BTFIDS=C2=A0 vmlinux > FAILED elf_update(WRITE): no error This elf_update(WRITE) error is new to me. > make: *** [Makefile:1176: vmlinux] Error 255 > make: *** Deleting file 'vmlinux' It is annoying that vmlinux is deleted in this case, because I usually=20 give Jiri the output from 'resolve_btfids -v' on vmlinux. $ ./tools/bpf/resolve_btfids/resolve_btfids -v vmlinux.failed You can do: $ git diff diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index 3b261b0f74f0..02dec10a7d75 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -302,7 +302,8 @@ cleanup() rm -f .tmp_symversions.lds rm -f .tmp_vmlinux* rm -f System.map - rm -f vmlinux + # rm -f vmlinux + mv vmlinux vmlinux.failed rm -f vmlinux.o } >=20 >=20 > ...and un-setting CONFIG_DEBUG_INFO_BTF makes that disappear. Maybe som= eone > who is understands the BTFIDS build step can shed some light on that; I= 'm > not there yet. :) I'm just a user/consume of output from the BTFIDS build step, I think=20 Jiri Olsa own the tool resolve_btfids, and ACME pahole. I've hit a=20 number of issues in the past that Jiri and ACME help resolve quickly. The most efficient solution I've found was to upgrade pahole to a newer=20 version. What version of pahole does your build system have? What is your GCC version? --Jesper