From: Vlastimil Babka <vbabka@suse.cz>
To: Arun KS <arunks@codeaurora.org>,
akpm@linux-foundation.org, keescook@chromium.org,
khlebnikov@yandex-team.ru, minchan@kernel.org, mhocko@kernel.org,
osalvador@suse.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: getarunks@gmail.com
Subject: Re: [PATCH v2 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic
Date: Wed, 7 Nov 2018 10:04:59 +0100 [thread overview]
Message-ID: <5edc432c-b475-5d2e-6a87-700c32a8fad9@suse.cz> (raw)
In-Reply-To: <1541521310-28739-4-git-send-email-arunks@codeaurora.org>
On 11/6/18 5:21 PM, Arun KS wrote:
> totalram_pages and totalhigh_pages are made static inline function.
>
> Suggested-by: Michal Hocko <mhocko@suse.com>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Arun KS <arunks@codeaurora.org>
> Reviewed-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
One bug (probably) below:
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 59db322..02a9a4b 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -105,9 +105,7 @@ static inline wait_queue_head_t *get_pkmap_wait_queue_head(unsigned int color)
> }
> #endif
>
> -unsigned long totalhigh_pages __read_mostly;
> -EXPORT_SYMBOL(totalhigh_pages);
I think you still need to export _totalhigh_pages so that modules can
use the inline accessors.
> -
> +atomic_long_t _totalhigh_pages __read_mostly;
>
> EXPORT_PER_CPU_SYMBOL(__kmap_atomic_idx);
>
next prev parent reply other threads:[~2018-11-07 9:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 16:21 [PATCH v2 0/4] mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-11-06 16:21 ` [PATCH v2 1/4] mm: Fix multiple evaluvations of totalram_pages and managed_pages Arun KS
2018-11-07 8:20 ` Michal Hocko
2018-11-07 8:44 ` Vlastimil Babka
2018-11-07 9:23 ` Michal Hocko
2018-11-07 19:54 ` kbuild test robot
2018-11-07 20:07 ` kbuild test robot
2018-11-06 16:21 ` [PATCH v2 2/4] mm: Convert zone->managed_pages to atomic variable Arun KS
2018-11-07 8:57 ` Vlastimil Babka
2018-11-06 16:21 ` [PATCH v2 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic Arun KS
2018-11-07 9:04 ` Vlastimil Babka [this message]
2018-11-08 7:23 ` Arun KS
2018-11-07 20:07 ` kbuild test robot
2018-11-07 20:24 ` kbuild test robot
2018-11-06 16:21 ` [PATCH v2 4/4] mm: Remove managed_page_count spinlock Arun KS
2018-11-07 21:26 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5edc432c-b475-5d2e-6a87-700c32a8fad9@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=arunks@codeaurora.org \
--cc=getarunks@gmail.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).