From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6CBC10DCE for ; Tue, 10 Mar 2020 22:03:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E64B21927 for ; Tue, 10 Mar 2020 22:03:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="avlm0Oe8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E64B21927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 09F666B0003; Tue, 10 Mar 2020 18:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 050746B0006; Tue, 10 Mar 2020 18:03:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59506B0007; Tue, 10 Mar 2020 18:03:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id CB75B6B0003 for ; Tue, 10 Mar 2020 18:03:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A18F69885 for ; Tue, 10 Mar 2020 22:03:04 +0000 (UTC) X-FDA: 76580828688.12.class20_721a75a54a95f X-HE-Tag: class20_721a75a54a95f X-Filterd-Recvd-Size: 4642 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 22:03:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583877783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=em5WQq5ac7V0TSXaeHIBQxjAvzn15Y90KasLTGrg4SM=; b=avlm0Oe85BjZfZfEOZlIxeDhfWSqMvmqfYSfBkC9hoxY4Z/MBJarNQa5c6nYyLhYWsX39F MB2QbENCG2PzNa7CN38uIpHgFEYg6z1WWX4abJfp/dbnPKSYTk1uN26AOZA1ysILHCa5rw 7Y4VzJeN1sQLLJkJ6PcSpFpCkXGDXLM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-wLdsCGObPMuDyh9TZ5ep5g-1; Tue, 10 Mar 2020 18:03:01 -0400 X-MC-Unique: wLdsCGObPMuDyh9TZ5ep5g-1 Received: by mail-wr1-f71.google.com with SMTP id o9so7407512wrw.14 for ; Tue, 10 Mar 2020 15:03:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=40W/kfQFw5xqXbXKZGwOTmPRgRjffptCSgf0Kp+g8OA=; b=Bubx1efWj0v/HNoIeIwayGkyzd1ScB0ObLh9w19wWSJ8Ranflz/FSjmbSJdpCBkzop qZwXCNK5cLk7EvCfs/AlN6CxscShmz6Mc2lO95c3bBd8M7nKlliXkNABlWq8sqWQ9ns1 qrbuYVkguF3/7xLb9xI6XNyCw0p30LtVC+4EwJFaFJcdaNoTAqCWjjDGufs4hRhWQzHT blsOpqIR9bEn1WlSSX02aUAbYuRisKkf9vyO3tkyHseNaUAqY9dbwnfsRUk1VYYZALtp zpuhKFi0TEud14S4qQ9p1Bp7IOZaGmJZc1ujwq6guSs2t1VXoP2YsNCWxHc+YiNmt27H q6PA== X-Gm-Message-State: ANhLgQ3TtfDhJPpGJO/FuFWnqlM3UuUDI/EnNgiJfTzN0SNxvx32o8bd hhClgN0+18idnnFXPKUO4Pre126O2z4vhIDB5mGevz/adWj3zICLYnNDhPUfpos8Jfm/hjp4KXV EKKwG16H5lKk= X-Received: by 2002:a5d:4687:: with SMTP id u7mr15891902wrq.129.1583877780660; Tue, 10 Mar 2020 15:03:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtZW/8L6Ll/FpuR0abFGldY17cpkX73JNYI1cBMm+URNiyq/qfzVgh4k4hvqu/EPs8sL15bng== X-Received: by 2002:a5d:4687:: with SMTP id u7mr15891878wrq.129.1583877780451; Tue, 10 Mar 2020 15:03:00 -0700 (PDT) Received: from [192.168.3.122] (p5B0C6338.dip0.t-ipconnect.de. [91.12.99.56]) by smtp.gmail.com with ESMTPSA id u25sm5672417wml.17.2020.03.10.15.02.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2020 15:02:59 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM Date: Tue, 10 Mar 2020 23:02:58 +0100 Message-Id: <6021D755-F883-4524-B3D1-07C03C7DF11B@redhat.com> References: <20200310172114-mutt-send-email-mst@kernel.org> Cc: David Hildenbrand , David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Jason Wang , Stephen Rothwell , Tyler Sanderson , Wei Wang , Alexander Duyck , Nadav Amit , Michal Hocko , Andrew Morton In-Reply-To: <20200310172114-mutt-send-email-mst@kernel.org> To: "Michael S. Tsirkin" X-Mailer: iPhone Mail (17D50) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 10.03.2020 um 22:25 schrieb Michael S. Tsirkin : >=20 > =EF=BB=BFOn Tue, Mar 10, 2020 at 08:13:19PM +0100, David Hildenbrand wrot= e: >>> Should this have: >>>=20 >>> Cc: stable@vger.kernel.org # 4.19+ >>=20 >> I guess as nothing will actually "crash" it's not worth stable. >=20 >=20 > No - it's a regression, it would be a stable candidate from that POV. AFAIK =E2=80=9E It must fix a problem that causes a build error (but not for thin= gs marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security= issue, or some =E2=80=9Coh, that=E2=80=99s not good=E2=80=9D issue. In sho= rt, something critical.=E2=80=9C If this regression is that critical is debatable. But it doesn=E2=80=98t ma= tter as you correctly say, it=E2=80=98s too big :)