From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f198.google.com (mail-qt0-f198.google.com [209.85.216.198]) by kanga.kvack.org (Postfix) with ESMTP id 43CDB6B0038 for ; Mon, 15 Jan 2018 13:37:52 -0500 (EST) Received: by mail-qt0-f198.google.com with SMTP id y42so7974814qtc.19 for ; Mon, 15 Jan 2018 10:37:52 -0800 (PST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id j30si255038qta.291.2018.01.15.10.37.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 10:37:51 -0800 (PST) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0FIYnfq005365 for ; Mon, 15 Jan 2018 13:37:50 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fh00rmn38-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 15 Jan 2018 13:37:49 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Jan 2018 18:37:47 -0000 Subject: Re: [PATCH v6 01/24] x86/mm: Define CONFIG_SPF References: <1515777968-867-1-git-send-email-ldufour@linux.vnet.ibm.com> <1515777968-867-2-git-send-email-ldufour@linux.vnet.ibm.com> <753d7b28-3d7e-0c01-0386-8dad161f88ea@linux.vnet.ibm.com> From: Laurent Dufour Date: Mon, 15 Jan 2018 19:37:37 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <603205fb-21e5-859c-605c-fbd7b44438c0@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Thomas Gleixner Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Ingo Molnar , hpa@zytor.com, Will Deacon , Sergey Senozhatsky , Andrea Arcangeli , Alexei Starovoitov , kemi.wang@intel.com, sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org On 15/01/2018 18:49, Thomas Gleixner wrote: > On Mon, 15 Jan 2018, Laurent Dufour wrote: >> On 12/01/2018 19:57, Thomas Gleixner wrote: >>> On Fri, 12 Jan 2018, Laurent Dufour wrote: >>> >>>> Introduce CONFIG_SPF which turns on the Speculative Page Fault handler when >>>> building for 64bits with SMP. >>>> >>>> Signed-off-by: Laurent Dufour >>>> --- >>>> arch/x86/Kconfig | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >>>> index a317d5594b6a..d74353b85aaf 100644 >>>> --- a/arch/x86/Kconfig >>>> +++ b/arch/x86/Kconfig >>>> @@ -2882,6 +2882,10 @@ config X86_DMA_REMAP >>>> config HAVE_GENERIC_GUP >>>> def_bool y >>>> >>>> +config SPF >>>> + def_bool y >>>> + depends on X86_64 && SMP >>> >>> Can you please put that into a generic place as >>> >>> config SPF >>> bool >>> >>> and let the architectures select it. >> >> I'll change that to let the architectures (x86 and ppc64 currently) >> selecting it, but the definition will remain in the arch/xxx/Kconfig file >> since it depends on the architecture support in the page fault handler. > > Errm. No. > > config SPECULATIVE_PAGE_FAULT > bool > > goes into a generic config file, e.g. mm/Kconfig > > Each architecture which implements support does: > > select SPECULATIVE_PAGE_FAULT > > in arch/xxx/Kconfig Oh ok, I think I got it this time ;) Will do this way, this will be smarter. Thanks a lot, Laurent. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org