linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: vbabka@suse.cz, Linux-MM <linux-mm@kvack.org>
Subject: low-memory crash with patch "capture a page under direct compaction"
Date: Mon, 4 Mar 2019 22:55:04 -0500	[thread overview]
Message-ID: <604a92ae-cbbb-7c34-f9aa-f7c08925bedf@lca.pw> (raw)

Reverted the patches below from linux-next seems fixed a crash while running LTP
oom01.

915c005358c1 mm, compaction: Capture a page under direct compaction -fix
e492a5711b67 mm, compaction: capture a page under direct compaction

Especially, just removed this chunk along seems fixed the problem.

--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2227,10 +2227,10 @@ compact_zone(struct compact_control *cc, struct
capture_control *capc)
                }

                /* Stop if a page has been captured */
-               if (capc && capc->page) {
-                       ret = COMPACT_SUCCESS;
-                       break;
-               }


BUG_ON(!PageBuddy(page)); from  __isolate_free_page
fast_isolate_freepages at mm/compaction.c:1358
(inlined by) isolate_freepages at mm/compaction.c:1431
(inlined by) compaction_alloc at mm/compaction.c:1543
unmap_and_move at mm/migrate.c:1176
migrate_pages at mm/migrate.c:1426
compact_zone at mm/compaction.c:2174
kcompactd_do_work at mm/compaction.c:2557
kcompactd at mm/compaction.c:2640

[  985.025371] UBSAN: Undefined behaviour in ./include/linux/mm.h:1195:50
[  985.058855] index 7 is out of range for type 'zone [5]'
[  985.082233] CPU: 13 PID: 264 Comm: kcompactd1 Tainted: G        W
5.0.0-rc8-next-20190304+ #43
[  985.124314] Hardware name: HP ProLiant DL180 Gen9/ProLiant DL180 Gen9, BIOS
U20 10/25/2017
[  985.161530] Call Trace:
[  985.172517]  dump_stack+0x62/0x9a
[  985.187332]  ubsan_epilogue+0xd/0x7f
[  985.203347]  __ubsan_handle_out_of_bounds+0x14d/0x192
[  985.331394]  __isolate_free_page+0x52c/0x600
[  985.350570]  compaction_alloc+0x886/0x25f0
[  985.412281]  unmap_and_move+0x37/0x1e70
[  985.449069]  migrate_pages+0x2ca/0xb20
[  985.508167]  compact_zone+0x19cb/0x3620
[  985.587332]  kcompactd_do_work+0x2df/0x680
[  985.658292]  kcompactd+0x1d8/0x6c0
[  985.746357]  kthread+0x32c/0x3f0
[  985.797002]  ret_from_fork+0x35/0x40
[  985.812989]
================================================================================
[  985.850800] ------------[ cut here ]------------
[  985.871466] kernel BUG at mm/page_alloc.c:3124!
[  985.891423] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN PTI
[  985.919458] CPU: 13 PID: 264 Comm: kcompactd1 Tainted: G        W
5.0.0-rc8-next-20190304+ #43
[  985.961822] Hardware name: HP ProLiant DL180 Gen9/ProLiant DL180 Gen9, BIOS
U20 10/25/2017
[  985.999012] RIP: 0010:__isolate_free_page+0x464/0x600
[  986.021780] Code: 31 c0 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 c7 c6 e0 6e 6b a8
48 89 df e8 4a 8b f8 ff 0f 0b 48 c7 c7 e0 31 c9 a8 e8 a1 3f 43 00 <0f> 0b 48 c7
c7 20 31 c9 a8 e8 93 3f 43 00 48 c7 c6 40 71 6b a8 48
[  986.111505] RSP: 0000:ffff8881f56cf848 EFLAGS: 00010883
[  986.134890] RAX: 0000000070000080 RBX: ffff88847e030160 RCX: 0000000000000000
[  986.167582] RDX: 1ffff1108fc06032 RSI: 0000000000000004 RDI: ffffed103ead9ef6
[  986.199580] RBP: ffff8881f56cf898 R08: fffffbfff51c2471 R09: fffffbfff51c2470
[  986.231619] R10: fffffbfff51c2470 R11: ffffffffa8e12383 R12: 0000000000000008
[  986.264032] R13: dffffc0000000000 R14: 0000000000000000 R15: 0000000000000007
[  986.296108] FS:  0000000000000000(0000) GS:ffff888455480000(0000)
knlGS:0000000000000000
[  986.332433] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  986.358224] CR2: 00007f9c620d0000 CR3: 000000041b416004 CR4: 00000000001606a0
[  986.390940] Call Trace:
[  986.401894]  compaction_alloc+0x886/0x25f0
[  986.462643]  unmap_and_move+0x37/0x1e70
[  986.500043]  migrate_pages+0x2ca/0xb20
[  986.560356]  compact_zone+0x19cb/0x3620
[  986.638822]  kcompactd_do_work+0x2df/0x680
[  986.710168]  kcompactd+0x1d8/0x6c0
[  986.798424]  kthread+0x32c/0x3f0
[  986.849165]  ret_from_fork+0x35/0x40
[  986.865180] Modules linked in: nls_iso8859_1 nls_cp437 vfat fat kvm_intel kvm
irqbypass efivars ip_tables x_tables xfs sd_mod ahci igb libahci i2c_algo_bit
libata i2c_core dm_mirror dm_region_hash dm_log dm_mod efivarfs
[  986.953234] ---[ end trace 9cfeadd3642eaaf8 ]---
[  986.974041] RIP: 0010:__isolate_free_page+0x464/0x600
[  986.996784] Code: 31 c0 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 c7 c6 e0 6e 6b a8
48 89 df e8 4a 8b f8 ff 0f 0b 48 c7 c7 e0 31 c9 a8 e8 a1 3f 43 00 <0f> 0b 48 c7
c7 20 31 c9 a8 e8 93 3f 43 00 48 c7 c6 40 71 6b a8 48
[  987.085030] RSP: 0000:ffff8881f56cf848 EFLAGS: 00010883
[  987.109886] RAX: 0000000070000080 RBX: ffff88847e030160 RCX: 0000000000000000
[  987.141793] RDX: 1ffff1108fc06032 RSI: 0000000000000004 RDI: ffffed103ead9ef6
[  987.173768] RBP: ffff8881f56cf898 R08: fffffbfff51c2471 R09: fffffbfff51c2470
[  987.205814] R10: fffffbfff51c2470 R11: ffffffffa8e12383 R12: 0000000000000008
[  987.237426] R13: dffffc0000000000 R14: 0000000000000000 R15: 0000000000000007
[  987.269606] FS:  0000000000000000(0000) GS:ffff888455480000(0000)
knlGS:0000000000000000
[  987.305810] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  987.332027] CR2: 00007f9c620d0000 CR3: 000000041b416004 CR4: 00000000001606a0
[  987.365458] Kernel panic - not syncing: Fatal exception
[  988.449736] Shutting down cpus with NMI
[  988.470880] Kernel Offset: 0x26200000 from 0xffffffff81000000 (relocation
range: 0xffffffff80000000-0xffffffffbfffffff)
[  988.522206] ---[ end Kernel panic - not syncing: Fatal exception ]---


             reply	other threads:[~2019-03-05  3:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05  3:55 Qian Cai [this message]
2019-03-05 14:42 ` low-memory crash with patch "capture a page under direct compaction" Mel Gorman
2019-03-05 15:13   ` Qian Cai
2019-03-05 15:27     ` Mel Gorman
2019-03-06  3:01       ` Qian Cai
2019-03-06  3:14         ` Qian Cai
2019-03-06  9:13           ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=604a92ae-cbbb-7c34-f9aa-f7c08925bedf@lca.pw \
    --to=cai@lca.pw \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).