From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=deGn=FX=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF56C4361B
	for <linux-mm@archiver.kernel.org>; Sat, 19 Dec 2020 02:06:34 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 0C44E23BCB
	for <linux-mm@archiver.kernel.org>; Sat, 19 Dec 2020 02:06:33 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C44E23BCB
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 3544F6B005C; Fri, 18 Dec 2020 21:06:33 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 3041A6B005D; Fri, 18 Dec 2020 21:06:33 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 21B866B0068; Fri, 18 Dec 2020 21:06:33 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154])
	by kanga.kvack.org (Postfix) with ESMTP id 0CE766B005C
	for <linux-mm@kvack.org>; Fri, 18 Dec 2020 21:06:33 -0500 (EST)
Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay01.hostedemail.com (Postfix) with ESMTP id CA3F2181C9661
	for <linux-mm@kvack.org>; Sat, 19 Dec 2020 02:06:32 +0000 (UTC)
X-FDA: 77608392624.25.fact87_3908a8a27442
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin25.hostedemail.com (Postfix) with ESMTP id A89BA180A4343
	for <linux-mm@kvack.org>; Sat, 19 Dec 2020 02:06:32 +0000 (UTC)
X-HE-Tag: fact87_3908a8a27442
X-Filterd-Recvd-Size: 3484
Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143])
	by imf21.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Sat, 19 Dec 2020 02:06:31 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
	id <B5fdd60260000>; Fri, 18 Dec 2020 18:06:30 -0800
Received: from [10.2.61.104] (172.20.145.6) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 19 Dec
 2020 02:06:29 +0000
Subject: Re: [PATCH RFC 7/9] mm/gup: Decrement head page once for group of
 subpages
To: Jason Gunthorpe <jgg@ziepe.ca>, Joao Martins <joao.m.martins@oracle.com>
CC: <linux-mm@kvack.org>, Dan Williams <dan.j.williams@intel.com>, Ira Weiny
	<ira.weiny@intel.com>, <linux-nvdimm@lists.01.org>, Matthew Wilcox
	<willy@infradead.org>, Jane Chu <jane.chu@oracle.com>, Muchun Song
	<songmuchun@bytedance.com>, Mike Kravetz <mike.kravetz@oracle.com>, "Andrew
 Morton" <akpm@linux-foundation.org>, Daniel Jordan
	<daniel.m.jordan@oracle.com>
References: <20201208172901.17384-1-joao.m.martins@oracle.com>
 <20201208172901.17384-9-joao.m.martins@oracle.com>
 <20201208193446.GP5487@ziepe.ca>
 <cf5585f0-1352-e3ab-9dbf-0185ad0a1b31@oracle.com>
 <20201217200530.GK5487@ziepe.ca>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <604ac536-a829-4ae6-e0c8-291ab9e0138e@nvidia.com>
Date: Fri, 18 Dec 2020 18:06:28 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101
 Thunderbird/84.0
MIME-Version: 1.0
In-Reply-To: <20201217200530.GK5487@ziepe.ca>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1608343590; bh=OH53xx8sNxbZpEAHW3MZBKOYLl1Mb9gG8A7DayBo6y4=;
	h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
	 MIME-Version:In-Reply-To:Content-Type:Content-Language:
	 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
	b=rWr1vsQ+xPscwDyZiaTbRZ1RTHZ+mYt3wxd4tuJTV+HypbusMqEDF7xeym/OOp1rA
	 nwJd7Gf1b/Gp825AcnY7gRogjaRYGpNXiUzIdNncQHJWeMj3mPd/ivIFWcbEpeE3yQ
	 SHeki2QqF6+afmqXvruuErOpqgHFMr2cHbnn0mWb+A8sYz3eoGWuW+G0OQ39JlZpXq
	 ch4vilGvKxLmqtvjtrUJ+mq1Bv7UX4+LnbR0gFjdEyrafoxh6a1tY8988OpvOF2OTw
	 TQ42CnFxFj8bRkesPP15z1S8KpHat6lq9x5GRcuVqz/8BjqILqi+GST0GxmKci5XW6
	 /tQFvnC4cBpjA==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 12/17/20 12:05 PM, Jason Gunthorpe wrote:
> On Thu, Dec 17, 2020 at 07:05:37PM +0000, Joao Martins wrote:
>>> No reason not to fix set_page_dirty_lock() too while you are here.
>>
>> The wack of atomics you mentioned earlier you referred to, I suppose it
>> ends being account_page_dirtied(). See partial diff at the end.
> 
> Well, even just eliminating the lock_page, page_mapping, PageDirty,
> etc is already a big win.
> 
> If mapping->a_ops->set_page_dirty() needs to be called multiple times
> on the head page I'd probably just suggest:
> 
>    while (ntails--)
>          rc |= (*spd)(head);

I think once should be enough. There is no counter for page dirtiness,
and this kind of accounting is always tracked in the head page, so there
is no reason to repeatedly call set_page_dirty() from the same
spot.


thanks,
-- 
John Hubbard
NVIDIA