From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xy4g=45=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 816AFC0044D
	for <linux-mm@archiver.kernel.org>; Thu, 12 Mar 2020 01:12:31 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 5B38820734
	for <linux-mm@archiver.kernel.org>; Thu, 12 Mar 2020 01:12:31 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="q1DQgbIQ"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B38820734
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 8AA4F6B0003; Wed, 11 Mar 2020 21:12:30 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 85BB66B0006; Wed, 11 Mar 2020 21:12:30 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 74A1F6B0007; Wed, 11 Mar 2020 21:12:30 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154])
	by kanga.kvack.org (Postfix) with ESMTP id 59D586B0003
	for <linux-mm@kvack.org>; Wed, 11 Mar 2020 21:12:30 -0400 (EDT)
Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with ESMTP id 241E94DBF
	for <linux-mm@kvack.org>; Thu, 12 Mar 2020 01:12:30 +0000 (UTC)
X-FDA: 76584934860.29.farm22_4ff62164c7d24
X-HE-Tag: farm22_4ff62164c7d24
X-Filterd-Recvd-Size: 3620
Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65])
	by imf19.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Thu, 12 Mar 2020 01:12:29 +0000 (UTC)
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
	id <B5e698c6e0000>; Wed, 11 Mar 2020 18:12:14 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Wed, 11 Mar 2020 18:12:27 -0700
X-PGP-Universal: processed;
	by hqpgpgate101.nvidia.com on Wed, 11 Mar 2020 18:12:27 -0700
Received: from [10.2.50.198] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 12 Mar
 2020 01:12:27 +0000
Subject: Re: [RESEND PATCH] mm/sparsemem: use wrapped macros instead of
 open-coding
To: chenqiwu <qiwuchen55@gmail.com>
CC: <akpm@linux-foundation.org>, <linux-mm@kvack.org>, chenqiwu
	<chenqiwu@xiaomi.com>
References: <1583489966-16390-1-git-send-email-qiwuchen55@gmail.com>
 <a731692c-0a04-2926-a573-d49e4f9c2efe@nvidia.com>
 <20200311080142.GA30917@cqw-OptiPlex-7050>
From: John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <60aee418-5885-d278-0088-cb6a98f7bbec@nvidia.com>
Date: Wed, 11 Mar 2020 18:09:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200311080142.GA30917@cqw-OptiPlex-7050>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1583975534; bh=BdagN3sM+4W8Olcxih6GZlT3YNm2ff79SRZouY3GkVQ=;
	h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
	 Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
	 X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
	 Content-Transfer-Encoding;
	b=q1DQgbIQga9+Ubg6oi/znM2l67XOwU+ZGPPZ/nv1KhsrZtInakOBwvOPQ4gBd4QpM
	 +Wq72u7OuzmzC93/C8ijKJPD8y3JwhDO1v82H+e0vmnQAOXfHop1bAfpZr6D01fVVT
	 tU9/7iBRvjBKlz7XBnyNkUkX9qRdDWYDVnkjy0/fXyxbzyC1qhW5P9myFb++vOZ7j/
	 3jHNBSXy95NeLxTu3dLERL5zl8JgM3TwjUptu8rqkV2rllnKGGlkFf9tQqWNqXGHs+
	 CsQX7aYBH0A4rrsKEp1yQ3le0j/FcudUAwqbDkAfOZghCEeaiMu8BrBwl/xZo6WJ9i
	 mVGgLDq7DtvRg==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 3/11/20 1:01 AM, chenqiwu wrote:
...
> 
> Hi John,
> I tested this patch only on arm64 build, not sure if any other build
> breakings. But I think any architecture is worth to support virt_to_pfn()


If a patch causes a build break (on any architecture), it normally should not
be merged into any maintainer's git tree. That's why the patch submission
checklist, here:

     https://www.kernel.org/doc/html/latest/process/submit-checklist.html

...requests "Builds on multiple CPU architectures".

We don't all always do all of the steps there, but it is still a good baseline
checklist. And conversely, if you routinely skip key steps such as cross-compilation,
then reviewers have a lot more to worry about when looking at your patch submissions,
so that potentially slows down approvals.


> API. Could you please send your compile-tested patch to x86 upstream?
> 


I don't think that will help in this case, unless of course there is something
wrong with my build setup, and I'm seeing a problem that no one else sees.


thanks,
-- 
John Hubbard
NVIDIA