From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D94EEC433B4 for ; Wed, 7 Apr 2021 12:35:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9DF76611EE for ; Wed, 7 Apr 2021 12:35:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DF76611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AF526B007D; Wed, 7 Apr 2021 08:35:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25F806B007E; Wed, 7 Apr 2021 08:35:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 127916B0080; Wed, 7 Apr 2021 08:35:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id E71766B007D for ; Wed, 7 Apr 2021 08:35:29 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9FB2B180ACF6C for ; Wed, 7 Apr 2021 12:35:29 +0000 (UTC) X-FDA: 78005516778.35.FEAFDAA Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP id AB5A42000250 for ; Wed, 7 Apr 2021 12:35:29 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4D3C7B029; Wed, 7 Apr 2021 12:35:28 +0000 (UTC) Subject: Re: unexpected -ENOMEM from percpu_counter_init() To: Wang Yugui , linux-mm@kvack.org References: <20210401185158.3275.409509F4@e16-tech.com> Cc: linux-btrfs@vger.kernel.org From: Vlastimil Babka Message-ID: <60e9b994-e37c-d059-4af5-0cb7860ca4f3@suse.cz> Date: Wed, 7 Apr 2021 14:35:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210401185158.3275.409509F4@e16-tech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AB5A42000250 X-Stat-Signature: nq8nxw7df6qmmwhbugcrmau836p8aku8 Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1617798929-849756 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +CC btrfs On 4/1/21 12:51 PM, Wang Yugui wrote: > Hi, > > an unexpected -ENOMEM from percpu_counter_init() happened when xfstest > with kernel 5.11.10 and 5.10.27 Is there a dmesg log showing allocation failure or something? > direct caller: > int btrfs_drew_lock_init(struct btrfs_drew_lock *lock) > { > int ret; > > ret = percpu_counter_init(&lock->writers, 0, GFP_KERNEL); > if (ret) > return ret; > > atomic_set(&lock->readers, 0); > init_waitqueue_head(&lock->pending_readers); > init_waitqueue_head(&lock->pending_writers); > > return 0; > } > > upper caller: > nofs_flag = memalloc_nofs_save(); > ret = btrfs_drew_lock_init(&root->snapshot_lock); > memalloc_nofs_restore(nofs_flag); > if (ret == -ENOMEM) printk("ENOMEM btrfs_drew_lock_init\n"); > if (ret) > goto fail; > > The hardware of this server: > CPU: Xeon(R) CPU E5-2660 v2(10 core) *2 > memory: 192G, no swap > > Only one xfstests job is running in this server, and about 7% of memory > is used. > > Any advice please. > > Best Regards > Wang Yugui (wangyugui@e16-tech.com) > 2021/04/01 > >