From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068E9C433EF for ; Fri, 21 Jan 2022 09:51:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EC786B0085; Fri, 21 Jan 2022 04:51:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74E5B6B0087; Fri, 21 Jan 2022 04:51:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C8216B0092; Fri, 21 Jan 2022 04:51:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 488136B0085 for ; Fri, 21 Jan 2022 04:51:13 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 07F2695C90 for ; Fri, 21 Jan 2022 09:51:13 +0000 (UTC) X-FDA: 79053826026.28.570FFC2 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf22.hostedemail.com (Postfix) with ESMTP id B7848C0004 for ; Fri, 21 Jan 2022 09:51:12 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id z10so9325475qkf.7 for ; Fri, 21 Jan 2022 01:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=z1FINpzDsQPI0PUajwhqnDxhxA4dZ+cIwmmEukBNCPI=; b=EbyA23v4IdYcSSNOOEme3+yuAPNlAw/CEp+nfLDkBym5L8yhuZALXoNYQcDczAGKJi vo++fLaJl2YQNSC7G+KGpS4E+GymFjuJMg+c5tu6LR/xgF0vE7ZB3tfJ/eheu9Y38Bdr rJ6HHlPXxg0ZYZAQ4JFrPFnAndAHCFoXZq51boDgy6fFZ+8J0GuxingrkytYrbnzbRvD r9aHnbDn/wh4a/TF2PPNOJ8LHG5mfo1z0ejTTLG9kIga+BeQOM3/uCcmnQyi3lRflKYd PQuaYkUohknt6XJBUT7Tq47+unvLO4fPe+Ltbj4HfgXrkl8JXh17YvU+arw2va3E/4jk JArA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=z1FINpzDsQPI0PUajwhqnDxhxA4dZ+cIwmmEukBNCPI=; b=7+YFlrFdLIOJrDVon98DGMle6fFGI3YGOLFL4qWaTSYo7xhg0KL0LVMlDvNfPzpl4K iDvAAwtJlEfyR4mh7Iubr0fMZdZEF15tzzpIK+WXkH7Bt8kEWmp1j6g8PwJXHXU1IIdU F1DlisaOU9pgtey+plAljBEayukqORwlsW5t6zBsRTGBULvD4CIf41IX03q3c3Brm470 8aoqk2ORBIPTLuFD+V4yC7T6jm7OjTuFsH26vjbKcGL9+nlWUs22W5cb0nnDAIsizlhN dtrHGY/Cbn9DlWLiMVK5gHuROqppYJc7LI7gS/pMLJpAz01ZzRy8tP+PowrlmsE4v0bt CUBQ== X-Gm-Message-State: AOAM532fllL7y3QfCneDx1GzHWNtRbThgbZcmfSRe+xDaupZG1amh/Oy h8qb32g3Ew5LPts/7AbQ26o= X-Google-Smtp-Source: ABdhPJyQVVSGRAag0A6AHd3n5hs3zX1Hidbo65RISgZJEtvTDZgw1i554pbF4gnze89jc1Z1c4UNDA== X-Received: by 2002:a05:620a:24c7:: with SMTP id m7mr2077240qkn.35.1642758672129; Fri, 21 Jan 2022 01:51:12 -0800 (PST) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id y19sm2764090qtx.75.2022.01.21.01.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 01:51:11 -0800 (PST) Message-ID: <61ea820f.1c69fb81.e79d5.09c9@mx.google.com> X-Google-Original-Message-ID: <20220121095108.GA1002138@cgel.zte@gmail.com> Date: Fri, 21 Jan 2022 09:51:08 +0000 From: CGEL To: Johannes Weiner Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Yang Subject: Re: [PATCH] psi: Treat ksm swapping in copy as memstall References: <20220116152150.859520-1-yang.yang29@zte.com.cn> <61e7ac25.1c69fb81.e8938.bc67@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B7848C0004 X-Stat-Signature: o6g9194gqh7remeksoaiewzh67nrxy45 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EbyA23v4; spf=pass (imf22.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1642758672-802796 X-Bogosity: Ham, tests=bogofilter, spamicity=0.347286, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Wed, Jan 19, 2022 at 07:58:23AM -0500, Johannes Weiner wrote: > On Wed, Jan 19, 2022 at 06:13:54AM +0000, CGEL wrote: > > I did a test, when we use zram, it takes longer time for ksm copying than > > swap_readpage(). Ksm copying average takes 147263ns, swap_readpage() > > average takes 55639ns. So I think this patch is reasonable. > > Ok, that sounds reasonable to me as well. Please add the > PageWorkingset() check and resubmit the patch. Thanks! I am a litte confused about adding PageWorkingset(), since I think ksm_might_need_to_copy() memstall is like swap_readpage() memstall and swap_readpage() doesn't add PageWorkingset(). Would please make it cleaner? Thanks!