From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D105FC4332F for ; Mon, 21 Nov 2022 23:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FD806B0071; Mon, 21 Nov 2022 18:48:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AE1C6B0073; Mon, 21 Nov 2022 18:48:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB7EA8E0001; Mon, 21 Nov 2022 18:48:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DC79F6B0071 for ; Mon, 21 Nov 2022 18:48:14 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A0EDB40C4B for ; Mon, 21 Nov 2022 23:48:14 +0000 (UTC) X-FDA: 80159090508.03.4440155 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf19.hostedemail.com (Postfix) with ESMTP id 08F4A1A000D for ; Mon, 21 Nov 2022 23:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669074494; x=1700610494; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3QFhYCGVIFGfzM0P2JRBlzSrAHp6vmlTph1ySfJVank=; b=fDmI2mMqjuR6PvwVqiHbghFHOqK7N5INzluKcQCBC63/nPBR1xsgWAhn UmzePmQLacOFjWRrAP1QgouZa1R/HjTwDNzmol+8c0smGSJ1yapihp4Fx DD8kfM2cy68ja8HW20YBvA2GiHZs6FDw2r7cRRk8kYLUrJ1JCYx2O3RwC hqnIQodBJ9ooxgSu2CIMK2D9aPXGuTOq+ilqF+oTB9Y6/2sf8R2nRyDqS jixLv9PS9HWt69a4isy+VyVxr3unGkjWAPKDIM8hO1gOrrNzfeVxWFo3z I/X8cWJAaD8p32f5Ydkk2XIWOkgM6aA9EOlGF/ewb6PKOJQxSL65t+7OH Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="311318241" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="311318241" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 15:48:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="747109675" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="747109675" Received: from ticela-or-327.amr.corp.intel.com (HELO [10.209.6.63]) ([10.209.6.63]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 15:48:10 -0800 Message-ID: <6260c853-3c6c-7302-677e-1910918c69b7@intel.com> Date: Mon, 21 Nov 2022 15:48:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 01/20] x86/tdx: Define TDX supported page sizes as macros Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, peterz@infradead.org, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=fDmI2mMq; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669074494; a=rsa-sha256; cv=none; b=ipP+NCtfTTzb9L/xSwW2ymoo82nrKuwPlqv9OU/aM8OBpgJmdRL/dOP721jefp3zxvXw7C h/BGYv68q6aZfF26DMHFuxK3Sn1fB+sAGLETQD35i++BQIbCeLVP68b/9Nk8K24KPu0DOJ H9frEapWf8g3lcnFY58EnLpF7sr+tHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669074494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lCGXkoUOiqreps9tMlZQrYS2R9CS7c11IW6Gq6Uo+og=; b=E/gOPVvCY/9suwEUBJO9mZhZhBqxrCTup1yhxoTfJDbU7pJBHI4qpGcjNrFFSsJsBAGhID tTQhZtExkSpWU/2ieJPaxbzd2uf2QRS6D5btSwn8zc5fjImvv1VFoqhHT+hRQjY4EQ7sb+ ulwXVNSBEBzA7OPoSo2xWB1nxVe0DHk= X-Rspamd-Queue-Id: 08F4A1A000D X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=fDmI2mMq; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam06 X-Stat-Signature: 3oj4e1q1toej3htag6iugjjo4fybrzd1 X-HE-Tag: 1669074493-809427 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001562, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/20/22 16:26, Kai Huang wrote: > +/* > + * TDX supported page sizes (4K/2M/1G). > + * > + * Those values are part of the TDX module ABI. Do not change them. > + */ > +#define TDX_PS_4K 0 > +#define TDX_PS_2M 1 > +#define TDX_PS_1G 2 That comment can just be: /* TDX supported page sizes from the TDX module ABI. */ I think folks understand that the kernel can't willy nilly change ABI values.