From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA819C433EF for ; Fri, 15 Apr 2022 05:09:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A7DC6B007D; Fri, 15 Apr 2022 01:09:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4572E6B007E; Fri, 15 Apr 2022 01:09:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D1D36B0080; Fri, 15 Apr 2022 01:09:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 1D0386B007D for ; Fri, 15 Apr 2022 01:09:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id E512012086C for ; Fri, 15 Apr 2022 05:09:50 +0000 (UTC) X-FDA: 79357936140.16.F32DAD6 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 2BB7A1C0004 for ; Fri, 15 Apr 2022 05:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1649999390; x=1681535390; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y4PW6r0NI=; b=CMPNWyaXC+5Ao8bpY5stnytChgMrISU4YAvwAwRTkTi0Gzl9YlnYH53W FxcbA2n9y4gsMWt4S9E6o5X3beIAFZBiePehU66IAJ8uaBMt1eBhBSPYe XbKky4DtUYLfmCzTYobsWdGEsfuSD1obT+mEuGj4MLO3GzCz2PZXFdB23 p5rCD8TRMlhaKieuzkS9SlWBgh68mK/8RMqXUHb4Dw6q215lkgZuwLJXt t4071Wz1WHFmYFMOhPymV8OvF5zRaixs7azd6Kr/Spp3zFbnmf3b8tJQn mzVL60olZG8LHtOegtGOJc8j0RUb+H+NZr/xt3427qBqIsvfEPA0fFCyw A==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="302161121" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:09:49 +0800 IronPort-SDR: SRDJ196yyDyhJqb+x7UZGrbHVH4cvww83JE/2fU7kDlKgZ+WMMY3tqpfa9ckz7fFNrPCI3pU9x Fl4YdT8Dt6dnDdy0l0L6GH5pNHP6lOyOZkWIjnTMkjQ3sqee881bEahIL7KesnzuffaYU3Ri8z eXJ6EB3RrRHLRzHO5/oano9XzLDRvfRIW5Sxpx3GOmcNKesfTCWI+/obcuHaDP5qvzOd/XFO3y x2prQ5DqN5t++J6Objs5YkWxA/rRazTKHk4tPYvty60pVAigm6ZteyKI7PV9WCXAzOprfTmc4n NiDJOHUJ2FZHdN68sYrO/uQT Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:41:00 -0700 IronPort-SDR: iirod2rsZb5CRqkeQfCzMZxxUotaIX0CpzDMycqQlTD89KC+FFxj4Y7le5Y2DXhF8d09CblYo9 XTQSrHRX7vFsUPmmKeTUNFHQB66mps78bSwyQN9jyAhcgn7hPcOoA0fBlxvSP7Q7RD5M0tEj0t N/+8mplqyytJn6Izwi4cBq87JoIrLyi6AFQumCi+qrXHtENsc2Qx80uHpUKmAPiq17AalQLppy jtVfytMQwXQE+dl4mj+CSRo3cYjCCfnId9Vhn9S4pkc5GLbSwisjSsAZHZHYUxGxvpHzjY0pBk Fbw= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:09:50 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KfksS1wnvz1SVp5 for ; Thu, 14 Apr 2022 22:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999387; x=1652591388; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y 4PW6r0NI=; b=A2KBgHYSLIEiloAT36KBlSnrdHo/5oKL9FrIFynJT5WRtSMAWFY bOfFXbV9aPU/SW14KWhWGoxgvZNpDxlNmySfQsvY8YKVzB0GPsCqMriDKUnvzDGe gxI79wWgz9d4ps/B6Xlf+gQiJxT1WJ1ZvXg2qG+PSKztllpdqubmLYAwOO/nz5St h4S8KA8vLEE0CNTHJjAA8Hcfkt3KCfxgWm/synsXo5jFqWGlKXVMBpl0q6F/zUl8 QMkInWk2S7O06U7jACfYKTCYPrMyVz97bbnYwKLXgej41iNgxlqjzLyt5sjDI1Lg BUEAK+PEVHrx0bfVbsoqkvKO8/sBQvwsP4Q== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2cHIjM1tU8KJ for ; Thu, 14 Apr 2022 22:09:47 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KfksM3c9Fz1Rvlx; Thu, 14 Apr 2022 22:09:43 -0700 (PDT) Message-ID: <62ebc311-e5ef-cea5-5236-0c83d1a3eb64@opensource.wdc.com> Date: Fri, 15 Apr 2022 14:09:42 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-11-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220415045258.199825-11-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2BB7A1C0004 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=CMPNWyaX; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=A2KBgHYS; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf18.hostedemail.com: domain of "prvs=0972008b0=damien.lemoal@opensource.wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=0972008b0=damien.lemoal@opensource.wdc.com" X-Stat-Signature: esddhe3qzs35fsxoz1pujt345o3ufwdo X-HE-Tag: 1649999389-874183 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/15/22 13:52, Christoph Hellwig wrote: > Use the bdev based helper instead of poking into the queue. > > Signed-off-by: Christoph Hellwig > --- > mm/swapfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 63c61f8b26118..4c7537162af5e 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode) > * write only restriction. Hence zoned block devices are not > * suitable for swapping. Disallow them here. > */ > - if (blk_queue_is_zoned(p->bdev->bd_disk->queue)) > + if (bdev_is_zoned(p->bdev)) > return -EINVAL; > p->flags |= SWP_BLKDEV; > } else if (S_ISREG(inode->i_mode)) { Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research