From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A57C2BA19 for ; Wed, 15 Apr 2020 20:32:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A5BA20774 for ; Wed, 15 Apr 2020 20:32:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A5BA20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A98A68E0041; Wed, 15 Apr 2020 16:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A23078E0001; Wed, 15 Apr 2020 16:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A898E0041; Wed, 15 Apr 2020 16:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 792148E0001 for ; Wed, 15 Apr 2020 16:32:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3A2F740D3 for ; Wed, 15 Apr 2020 20:32:09 +0000 (UTC) X-FDA: 76711236378.10.grain37_69fce06f79949 X-HE-Tag: grain37_69fce06f79949 X-Filterd-Recvd-Size: 2561 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 20:32:07 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0TvdyiWI_1586982722; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TvdyiWI_1586982722) by smtp.aliyun-inc.com(127.0.0.1); Thu, 16 Apr 2020 04:32:04 +0800 Subject: Re: [PATCHv3, RESEND 3/8] khugepaged: Drain all LRU caches before scanning pages To: "Kirill A. Shutemov" , akpm@linux-foundation.org, Andrea Arcangeli Cc: Zi Yan , Ralph Campbell , John Hubbard , William Kucharski , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200413125220.663-1-kirill.shutemov@linux.intel.com> <20200413125220.663-4-kirill.shutemov@linux.intel.com> From: Yang Shi Message-ID: <63b9ce4d-0e1d-8e40-5ec3-154fe6e95557@linux.alibaba.com> Date: Wed, 15 Apr 2020 13:31:58 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200413125220.663-4-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/13/20 5:52 AM, Kirill A. Shutemov wrote: > Having a page in LRU add cache offsets page refcount and gives > false-negative on PageLRU(). It reduces collapse success rate. > > Drain all LRU add caches before scanning. It happens relatively > rare and should not disturb the system too much. > > Signed-off-by: Kirill A. Shutemov > --- > mm/khugepaged.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Yang Shi > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 5968ec5ddd6b..ee66c140c2d6 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2059,6 +2059,8 @@ static void khugepaged_do_scan(void) > > barrier(); /* write khugepaged_pages_to_scan to local stack */ > > + lru_add_drain_all(); > + > while (progress < pages) { > if (!khugepaged_prealloc_page(&hpage, &wait)) > break;