From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA20CC433F5 for ; Tue, 15 Feb 2022 15:01:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30F526B0085; Tue, 15 Feb 2022 10:01:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BE768D0001; Tue, 15 Feb 2022 10:01:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 186566B0088; Tue, 15 Feb 2022 10:01:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 09DB96B0085 for ; Tue, 15 Feb 2022 10:01:39 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C4CB3181AC9C6 for ; Tue, 15 Feb 2022 15:01:38 +0000 (UTC) X-FDA: 79145328276.19.C418FF9 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf25.hostedemail.com (Postfix) with ESMTP id 5B7EEA0009 for ; Tue, 15 Feb 2022 15:01:35 +0000 (UTC) Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nJzKT-0001Wq-7a; Tue, 15 Feb 2022 10:01:21 -0500 Message-ID: <63f930e411655a6ad37d4818d0ae19784c82f076.camel@surriel.com> Subject: Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path From: Rik van Riel To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: kernel-team@fb.com, linux-mm@kvack.org, Miaohe Lin , Andrew Morton , Mel Gorman , Johannes Weiner , Matthew Wilcox Date: Tue, 15 Feb 2022 10:01:20 -0500 In-Reply-To: <2a881586-3f5e-c277-f373-a9014d631700@redhat.com> References: <20220212213740.423efcea@imladris.surriel.com> <2a881586-3f5e-c277-f373-a9014d631700@redhat.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-xmBlxiMQ0RX+8gFzH+9g" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5B7EEA0009 X-Stat-Signature: 6i6t8p7kkwm3oc9bbgorqrjmx6yggffi X-HE-Tag: 1644937295-662089 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=-xmBlxiMQ0RX+8gFzH+9g Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2022-02-15 at 12:22 +0100, David Hildenbrand wrote: > On 13.02.22 03:37, Rik van Riel wrote: > > Sometimes the page offlining code can leave behind a hwpoisoned > > clean > > page cache page. This can lead to programs being killed over and > > over > > and over again as they fault in the hwpoisoned page, get killed, > > and > > then get re-spawned by whatever wanted to run them. >=20 > Hi Rik, >=20 > am I correct that you are only talking about soft offlining as > triggered > from mm/memory-failure.c, not page offlining as in memory offlining > mm/memory_hotunplug.c ? That is correct in that I am talking only about memory-failure.c, however the code in memory-failure.c has both hard and soft offlining modes, and I suppose this patch covers both? --=20 All Rights Reversed. --=-xmBlxiMQ0RX+8gFzH+9g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAmILwEAACgkQznnekoTE 3oMtsAf/XQAcMuxVcOH1jkV3QUkXIetX7cd6gY7wiQ5Nw88ELC97QThAKEp/zTv5 RfVSqZmBLEaaW0oP81CrFinLrMk1IZZp8X8hkuK7V+086dGa1oxHoaF+k55yNpx9 6eIqlEiTloIgbTLVG6qKJhEZqgDCM0+fwBMVasVIAvfZ/scni5reBLJM2RZ3jVfl xwBOvAIPZT+/8kxxQSuT+h2UDiATqZWdfGrGR/TuX86AxqVQEpNUovmufTST9tvd yJpDju9ZHAbyB/tWquV+d5CBcXhQWqzw2aA3OH1te2nUz6M8azQA47gWZTBLzd80 ULrSoX/7Ez9S1U0VVYFIhivhGwbhmg== =9B67 -----END PGP SIGNATURE----- --=-xmBlxiMQ0RX+8gFzH+9g--