From: William Kucharski <william.kucharski@oracle.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
hannes@cmpxchg.org, mhocko@suse.com, mgorman@techsingularity.net,
kirill.shutemov@linux.intel.com, hughd@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: correct nr_reclaimed for THP
Date: Thu, 9 May 2019 22:33:35 -0600 [thread overview]
Message-ID: <640160C2-4579-45FC-AABB-B60185A2348D@oracle.com> (raw)
In-Reply-To: <87tve3j9jf.fsf@yhuang-dev.intel.com>
> On May 9, 2019, at 9:03 PM, Huang, Ying <ying.huang@intel.com> wrote:
>
> Yang Shi <yang.shi@linux.alibaba.com> writes:
>
>> On 5/9/19 7:12 PM, Huang, Ying wrote:
>>>
>>> How about to change this to
>>>
>>>
>>> nr_reclaimed += hpage_nr_pages(page);
>>
>> Either is fine to me. Is this faster than "1 << compound_order(page)"?
>
> I think the readability is a little better. And this will become
>
> nr_reclaimed += 1
>
> if CONFIG_TRANSPARENT_HUAGEPAGE is disabled.
I find this more legible and self documenting, and it avoids the bit shift
operation completely on the majority of systems where THP is not configured.
next prev parent reply other threads:[~2019-05-10 4:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 0:16 [PATCH] mm: vmscan: correct nr_reclaimed for THP Yang Shi
2019-05-10 0:39 ` Shakeel Butt
2019-05-10 2:12 ` Huang, Ying
2019-05-10 2:25 ` Yang Shi
2019-05-10 3:03 ` Huang, Ying
2019-05-10 4:33 ` William Kucharski [this message]
2019-05-10 15:48 ` Yang Shi
2019-05-10 15:41 ` Yang Shi
2019-05-10 16:36 ` Matthew Wilcox
2019-05-10 16:50 ` Yang Shi
2019-05-10 16:52 ` Matthew Wilcox
2019-05-10 16:54 ` Yang Shi
2019-05-10 22:54 ` Ira Weiny
2019-05-10 23:06 ` Matthew Wilcox
2019-05-11 4:09 ` Yafang Shao
2019-05-11 22:33 ` William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=640160C2-4579-45FC-AABB-B60185A2348D@oracle.com \
--to=william.kucharski@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).