From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE4EC433E0 for ; Sat, 11 Jul 2020 02:04:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8CF112076A for ; Sat, 11 Jul 2020 02:04:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="dotSC7vJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CF112076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06AE48D0002; Fri, 10 Jul 2020 22:04:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01C138D0001; Fri, 10 Jul 2020 22:04:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C8E8D0002; Fri, 10 Jul 2020 22:04:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id CAF208D0001 for ; Fri, 10 Jul 2020 22:04:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 495392496 for ; Sat, 11 Jul 2020 02:04:30 +0000 (UTC) X-FDA: 77024150700.19.ants54_5115ea026ed3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 21D011ACEAD for ; Sat, 11 Jul 2020 02:04:30 +0000 (UTC) X-HE-Tag: ants54_5115ea026ed3 X-Filterd-Recvd-Size: 3740 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 02:04:29 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 10 Jul 2020 19:03:32 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 10 Jul 2020 19:04:28 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 10 Jul 2020 19:04:28 -0700 Received: from [10.2.51.208] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 11 Jul 2020 02:04:28 +0000 Subject: Re: [PATCH v2 5/6] mm: Print the inode number in dump_page To: "Matthew Wilcox (Oracle)" , CC: Andrew Morton , Vlastimil Babka , "Kirill A. Shutemov" , William Kucharski , Mike Rapoport References: <20200709202117.7216-1-willy@infradead.org> <20200709202117.7216-6-willy@infradead.org> From: John Hubbard Message-ID: <6492792d-725d-f290-dd17-9942d937cd1b@nvidia.com> Date: Fri, 10 Jul 2020 19:04:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709202117.7216-6-willy@infradead.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594433012; bh=r/gqfLUM3jBXhydxc87I0D5erlv40SIWfl+VlqM4TjM=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=dotSC7vJdK5AxO+5NOAP8zlTpp0RM3BW8RHBkS+eWYnK+KzcyNin2NhVv3ch3/67J L5lZO6ZXYTgJ8v+J8p1H/iGiNby058CoaTtUb3yJn5JzhOo/TL6+iMmMjadJY3ZMiI Wz6ucCqQYdIz6XUKtyDDTSEQIgKMKhRnRdshdXwXUuVv1J/zkf8nzzbR/z0jQ5Xw+3 AkY1UcR6A9XqQox+DNMU3G1lKH09ZRp5rmwxt5H/kQeGM8iXlZBZyXlDCsKjGITeMM QP0pQs0d1ylpOgPsZp5cIC092hIB6bxL4gIEIa3sYVAmPCpANKazETwZcTnxHa/oNX RRoeed/ikho9A== X-Rspamd-Queue-Id: 21D011ACEAD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-07-09 13:21, Matthew Wilcox (Oracle) wrote: > The inode number helps correlate this page with debug messages elsewhere > in the kernel. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/debug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > diff --git a/mm/debug.c b/mm/debug.c > index fb64ff7454b6..60347d0d7609 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -137,7 +137,7 @@ void __dump_page(struct page *page, const char *reason) > } > > if (!dentry_first) { > - pr_warn("aops:%ps\n", a_ops); > + pr_warn("aops:%ps ino:%lx\n", a_ops, host->i_ino); > goto out_mapping; > } > > @@ -151,8 +151,8 @@ void __dump_page(struct page *page, const char *reason) > * crash, but it's unlikely that we reach here with a > * corrupted struct page > */ > - pr_warn("aops:%ps dentry name:\"%pd\"\n", a_ops, > - &dentry); > + pr_warn("aops:%ps ino:%lx dentry name:\"%pd\"\n", > + a_ops, host->i_ino, &dentry); > } > } > out_mapping: >