From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BBF1C433DF for ; Mon, 12 Oct 2020 08:13:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7871320E65 for ; Mon, 12 Oct 2020 08:13:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vLxLC2ao" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7871320E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70D85940008; Mon, 12 Oct 2020 04:13:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BF4B900002; Mon, 12 Oct 2020 04:13:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 585B0940008; Mon, 12 Oct 2020 04:13:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 27D1A900002 for ; Mon, 12 Oct 2020 04:13:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A68FD8249980 for ; Mon, 12 Oct 2020 08:13:17 +0000 (UTC) X-FDA: 77362558434.03.birth42_6009b0e271f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 8659028A4E8 for ; Mon, 12 Oct 2020 08:13:17 +0000 (UTC) X-HE-Tag: birth42_6009b0e271f9 X-Filterd-Recvd-Size: 4483 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 12 Oct 2020 08:13:17 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id u21so21967848eja.2 for ; Mon, 12 Oct 2020 01:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ISkqozpSXsD9a8Oh/2Mwcyva57KxR87dIuzCIf+AzK4=; b=vLxLC2ao0L4Ivfe+BPwXRED7H586V1sSXEIbMF9LfxQwxO+Zj65QHw9YpnzzpNF+5s pe0SgL866UCiUr5PMln2kM/rXsQAiQwxm9xqBa1r/w5BcshC+iOmiozfO7Z4u6AwQfAz Vfx3PqBr4wY4D9HosTE8Wp76eUyQkFEjvjbUBNXO9p/9oGzOrrNit+i1xQ8rB5QbDjQs F9Ihv4Bw7KG4xGNRxT0nbSDmdL/1EJi1xqf/gG4FNU+OUu4iG+9rU7nADfRhvp4+8AAf HcdDZZMKxxCfFS+tSPVctDoJoYUswL6SPs0UcCi3bxYvLZGbno5o1HYN8rV+tCw9Xic+ UV3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=ISkqozpSXsD9a8Oh/2Mwcyva57KxR87dIuzCIf+AzK4=; b=D4TzjhtPPd/loik9X5gut3BdsotJVK5A7ff7r3icMTepEjWUYDQON40XFqBK/QO7EN LtEoxmbM+jW0VfSNk+cnMO2ByfBHUmEBEyTkwatK50MDKWDbls+BXCU5a3bo11nbV9ho MOOygGfeBJ2UwVSzEPDYOQX05fl68jyrK/Qva0XZ+WvH07HuKh78De7k0xhG1LYvB/Y9 F7VRcS4Ipo0iFWkdFuX9xVejHK5yWl8DmxRu0hZ8vnxmzaz2u2tQI+wLZ96JlnbESR3K JIiYrLwS53cy9vRymcvMtCeoOqvOTr31sx7dE7dZVS+mpXzEudEibXz32443d/e678Pv 73Bg== X-Gm-Message-State: AOAM533VpRuXpQmQa5YYcP/PCN1+Tb7dAUbq2UlCBrsjgCIn1kw4rnyP PBx8Ms2fVxHKKVRDBKP6AQY= X-Google-Smtp-Source: ABdhPJyESr76MyJXr7Jw9FX0sBn+vlDp7RU85Q8VgP3nIl7qNvty4ksx+a/gWI8+0WMbFKdXmfr7Ow== X-Received: by 2002:a17:906:4e06:: with SMTP id z6mr28073702eju.370.1602490395918; Mon, 12 Oct 2020 01:13:15 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id p16sm10218325ejz.103.2020.10.12.01.13.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2020 01:13:15 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH 1/6] mm: mmap: fix fput in error path To: Jason Gunthorpe , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, daniel@ffwll.ch, sumit.semwal@linaro.org, willy@infradead.org, jhubbard@nvidia.com, Miaohe Lin References: <20201009150342.1979-1-christian.koenig@amd.com> <20201009150420.450833e3830b9d39a2385dd9@linux-foundation.org> <20201009222509.GC5177@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <666ef8f3-6299-3c0b-6ebb-04e957a115a1@gmail.com> Date: Mon, 12 Oct 2020 10:13:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201009222509.GC5177@ziepe.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 10.10.20 um 00:25 schrieb Jason Gunthorpe: > On Fri, Oct 09, 2020 at 03:04:20PM -0700, Andrew Morton wrote: >> On Fri, 9 Oct 2020 17:03:37 +0200 "Christian K=C3=B6nig" wrote: >> >>> Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." >>> adds a workaround for a bug in mmap_region. >>> >>> As the comment states ->mmap() callback can change >>> vma->vm_file and so we might call fput() on the wrong file. >>> >>> Revert the workaround and proper fix this in mmap_region. >>> >> Doesn't this patch series address the same thing as >> https://lkml.kernel.org/r/20200916090733.31427-1-linmiaohe@huawei.com? > Same basic issue, looks like both of these patches should be combined > to plug it fully. Yes, agree completely. It's a different error path, but we need to fix both occasions. Christian. > > Jason