linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Andi Kleen <andi@firstfloor.org>, hannes@cmpxchg.org
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] mm: Simplify and batch working set shadow pages LRU isolation locking
Date: Fri, 27 Oct 2017 16:51:01 -0400	[thread overview]
Message-ID: <66fbc72d-e3e9-ccb1-1a16-cd7150d7e36e@oracle.com> (raw)
In-Reply-To: <20171026234854.25764-1-andi@firstfloor.org>

On 10/26/2017 07:48 PM, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> When shrinking the working set shadow pages LRU we currently
> use a complicated hand-over locking scheme. The isolation
> function runs under the local lru lock for the list, but
> it also needs to take the tree_lock for the address space.
>
> This is done by releasing the lru lock, and then trying
> to get the tree_lock and retrying on failure.

The lru lock is dropped after trying for the tree_lock, so maybe instead:

This is done by trying to get the tree_lock and then either retrying the 
operation if we don't get it or releasing the lru lock.


Otherwise the patch looks good, it's a lot simpler.

Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>

Daniel

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-10-27 20:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 23:48 [PATCH] mm: Simplify and batch working set shadow pages LRU isolation locking Andi Kleen
2017-10-27 17:01 ` Johannes Weiner
2017-10-27 17:22   ` Andi Kleen
2017-10-27 20:59     ` Daniel Jordan
2017-10-27 20:51 ` Daniel Jordan [this message]
2017-11-08  1:56 ` [lkp-robot] [mm] 47bd678bc7: WARNING:at_mm/workingset.c:#scan_shadow_nodes kernel test robot
2017-11-09  0:03   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66fbc72d-e3e9-ccb1-1a16-cd7150d7e36e@oracle.com \
    --to=daniel.m.jordan@oracle.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).