From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFBFC4338F for ; Wed, 28 Jul 2021 08:19:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1138D60BD3 for ; Wed, 28 Jul 2021 08:19:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1138D60BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8935C6B0036; Wed, 28 Jul 2021 04:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 844496B005D; Wed, 28 Jul 2021 04:19:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7315C8D0001; Wed, 28 Jul 2021 04:19:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 56DF06B0036 for ; Wed, 28 Jul 2021 04:19:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EE6D21C946 for ; Wed, 28 Jul 2021 08:19:38 +0000 (UTC) X-FDA: 78411297636.25.8C6FB15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 1D4848BF7 for ; Wed, 28 Jul 2021 08:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627460377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cMq1gwm+6T9vDcPA3c1XF1gvVYDuhc4StArzHX5xwCI=; b=bR26+N6tRj+INmYFF9kx4XwJpUynL0F8U/UVRgxT+h8iqRvNUBSHmZabwQqT0j9k0AeUAR VTlRORiolQZMLQxVSTcEf/rpLmHOJmQG2FyR1t8ctQtGN20L7TNTXVOnBFqgTTTx9QpJSO /xKNbUT670WNh95wJaDI/mDKDHY/Hqc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-6JkcZfPbNHu0Pc2WFKuecw-1; Wed, 28 Jul 2021 04:19:36 -0400 X-MC-Unique: 6JkcZfPbNHu0Pc2WFKuecw-1 Received: by mail-wm1-f71.google.com with SMTP id 25-20020a05600c0219b029024ebb12928cso640800wmi.3 for ; Wed, 28 Jul 2021 01:19:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cMq1gwm+6T9vDcPA3c1XF1gvVYDuhc4StArzHX5xwCI=; b=O2VVglFz0w3mzpp4+s/ZXuLouyjevkEWzxxFoj0emHFQJSYkRZWycN9KP6Nxt8dNAK d2MZZuVSlJm2T9m1amdX8VFkmmH3didMUyTs6lh/eYmci3TX2WFD+AATj+OMg1DpovQe e6+47c/MOtLbY1hyNuPy42GExcRxNbhNI+S7koCYWS1hkNvtqBFXVkL9KIYC6f5bNEWw cGB2Yq4MQIgjs2LLkBDwvQIFEcKzdcoyqqLqwK50cjGPgv35vtMipcmJs9U9ZxvG58BH 4MeNdOZr3GuyFlnGSZ8hcC0hkPOChTQr0Yx4jRRzKLSisaYzv4sb2U3ydH1GBmIAjrW6 s1/A== X-Gm-Message-State: AOAM531GQL6IaZFS+nZAg9321gUosOIz4o59jAMCgmKtyVeYodOOjTr4 v3oPLCTAOM63YjIEeSY5zyAod8cWWz1Entyh9DoqbSLoA2IMp+yRp88xLyA/FY01UJxPhpqNeSn EfdIS8aagNJ0= X-Received: by 2002:adf:cd86:: with SMTP id q6mr28250659wrj.422.1627460375067; Wed, 28 Jul 2021 01:19:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRnfKgNDMzo46Svrl5aVK1frPgHu+b8iuuHo5e6TfWUjtLT0hd6kKOYumCz8bHqIPUgGoh7w== X-Received: by 2002:adf:cd86:: with SMTP id q6mr28250645wrj.422.1627460374860; Wed, 28 Jul 2021 01:19:34 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id v12sm819298wrq.59.2021.07.28.01.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 01:19:34 -0700 (PDT) Subject: Re: [PATCH] mm/migrate: fix NR_ISOLATED corruption on 64-bit To: "Aneesh Kumar K.V" , linux-mm@kvack.org Cc: akpm@linux-foundation.org, Yang Shi , Michael Ellerman , Nicholas Piggin References: <20210728042531.359409-1-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat Message-ID: <671b0c80-9cae-0854-ccbe-1c3e66b20ce2@redhat.com> Date: Wed, 28 Jul 2021 10:19:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210728042531.359409-1-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1D4848BF7 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bR26+N6t; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf22.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: ngh8fx816eohdq8wa3iioaiten434kft X-HE-Tag: 1627460377-327905 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.21 06:25, Aneesh Kumar K.V wrote: > Similar to commit 2da9f6305f30 ("mm/vmscan: fix NR_ISOLATED_FILE corruption on 64-bit") > avoid using unsigned int for nr_pages. With unsigned int type the large > unsigned int converts to a large positive signed long. > > Symptoms include CMA allocations hanging forever > due to alloc_contig_range->...->isolate_migratepages_block waiting > forever in "while (unlikely(too_many_isolated(pgdat)))". > > Fixes: c5fc5c3ae0c8 ("mm: migrate: account THP NUMA migration counters correctly") > Cc: Yang Shi > Reported-by: Michael Ellerman > Signed-off-by: Aneesh Kumar K.V > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 34a9ad3e0a4f..7e240437e7d9 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2068,7 +2068,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > LIST_HEAD(migratepages); > new_page_t *new; > bool compound; > - unsigned int nr_pages = thp_nr_pages(page); > + int nr_pages = thp_nr_pages(page); > > /* > * PTE mapped THP or HugeTLB page can't reach here so the page could > Already posted: https://lkml.kernel.org/r/20210722054840.501423-1-npiggin@gmail.com but this patch description is a lot better. -- Thanks, David / dhildenb