From: Laura Abbott <labbott@redhat.com>
To: Prakash Gupta <guptap@codeaurora.org>,
akpm@linux-foundation.org, l.stach@pengutronix.de,
gregkh@linuxfoundation.org
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm: cma: fix stack corruption due to sprintf usage
Date: Fri, 11 Aug 2017 08:56:50 -0700 [thread overview]
Message-ID: <687e393b-b74f-5999-90a5-26dcb26c7df7@redhat.com> (raw)
In-Reply-To: <1502446217-21840-1-git-send-email-guptap@codeaurora.org>
On 08/11/2017 03:10 AM, Prakash Gupta wrote:
> name[] in cma_debugfs_add_one() can only accommodate 16 chars including
> NULL to store sprintf output. It's common for cma device name to be larger
> than 15 chars. This can cause stack corrpution. If the gcc stack protector
> is turned on, this can cause a panic due to stack corruption.
>
> Below is one example trace:
>
> Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in:
> ffffff8e69a75730
> Call trace:
> [<ffffff8e68289504>] dump_backtrace+0x0/0x2c4
> [<ffffff8e682897e8>] show_stack+0x20/0x28
> [<ffffff8e685ea808>] dump_stack+0xb8/0xf4
> [<ffffff8e683c454c>] panic+0x154/0x2b0
> [<ffffff8e682a724c>] print_tainted+0x0/0xc0
> [<ffffff8e69a75730>] cma_debugfs_init+0x274/0x290
> [<ffffff8e682839ec>] do_one_initcall+0x5c/0x168
> [<ffffff8e69a50e24>] kernel_init_freeable+0x1c8/0x280
>
> Fix the short sprintf buffer in cma_debugfs_add_one() by using scnprintf()
> instead of sprintf().
>
Acked-by: Laura Abbott <labbott@redhat.com>
> fixes: f318dd083c81 ("cma: Store a name in the cma structure")
> Signed-off-by: Prakash Gupta <guptap@codeaurora.org>
> ---
> mm/cma_debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma_debug.c b/mm/cma_debug.c
> index 595b757..c03ccbc 100644
> --- a/mm/cma_debug.c
> +++ b/mm/cma_debug.c
> @@ -167,7 +167,7 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
> char name[16];
> int u32s;
>
> - sprintf(name, "cma-%s", cma->name);
> + scnprintf(name, sizeof(name), "cma-%s", cma->name);
>
> tmp = debugfs_create_dir(name, cma_debugfs_root);
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-08-11 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 10:10 [PATCH] mm: cma: fix stack corruption due to sprintf usage Prakash Gupta
2017-08-11 15:56 ` Laura Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687e393b-b74f-5999-90a5-26dcb26c7df7@redhat.com \
--to=labbott@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=guptap@codeaurora.org \
--cc=l.stach@pengutronix.de \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).