From: David Hildenbrand <david@redhat.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
Oscar Salvador <osalvador@suse.de>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Yang Shi <shy828301@gmail.com>,
Muchun Song <songmuchun@bytedance.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 0/4] mm, hwpoison: improve handling workload related to hugetlb and memory_hotplug
Date: Wed, 11 May 2022 18:22:41 +0200 [thread overview]
Message-ID: <6986a8dd-7211-fb4d-1d66-5b203cad1aab@redhat.com> (raw)
In-Reply-To: <20220511161052.GA224675@hori.linux.bs1.fc.nec.co.jp>
On 11.05.22 18:10, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Wed, May 11, 2022 at 05:11:17PM +0200, David Hildenbrand wrote:
>> On 09.05.22 12:53, Miaohe Lin wrote:
>>> On 2022/5/9 17:58, Oscar Salvador wrote:
>>>> On Mon, May 09, 2022 at 05:04:54PM +0800, Miaohe Lin wrote:
>>>>>>> So that leaves us with either
>>>>>>>
>>>>>>> 1) Fail offlining -> no need to care about reonlining
>>>>>
>>>>> Maybe fail offlining will be a better alternative as we can get rid of many races
>>>>> between memory failure and memory offline? But no strong opinion. :)
>>>>
>>>> If taking care of those races is not an herculean effort, I'd go with
>>>> allowing offlining + disallow re-onlining.
>>>> Mainly because memory RAS stuff.
>>>
>>> This dose make sense to me. Thanks. We can try to solve those races if
>>> offlining + disallow re-onlining is applied. :)
>>>
>>>>
>>>> Now, to the re-onlining thing, we'll have to come up with a way to check
>>>> whether a section contains hwpoisoned pages, so we do not have to go
>>>> and check every single page, as that will be really suboptimal.
>>>
>>> Yes, we need a stable and cheap way to do that.
>>
>> My simplistic approach would be a simple flag/indicator in the memory block devices
>> that indicates that any page in the memory block was hwpoisoned. It's easy to
>> check that during memory onlining and fail it.
>>
>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>> index 084d67fd55cc..3d0ef812e901 100644
>> --- a/drivers/base/memory.c
>> +++ b/drivers/base/memory.c
>> @@ -183,6 +183,9 @@ static int memory_block_online(struct memory_block *mem)
>> struct zone *zone;
>> int ret;
>>
>> + if (mem->hwpoisoned)
>> + return -EHWPOISON;
>> +
>> zone = zone_for_pfn_range(mem->online_type, mem->nid, mem->group,
>> start_pfn, nr_pages);
>>
>
> Thanks for the idea, a simple flag could work if we don't have to consider
> unpoison. If we need consider unpoison, we need remember the last hwpoison
> page in the memory block, so mem->hwpoisoned should be the counter of
> hwpoison pages.
Right, but unpoisoning+memory offlining+memory onlining is a yet more
extreme use case we don't have to bother about I think.
>
>>
>>
>> Once the problematic DIMM would actually get unplugged, the memory block devices
>> would get removed as well. So when hotplugging a new DIMM in the same
>> location, we could online that memory again.
>
> What about PG_hwpoison flags? struct pages are also freed and reallocated
> in the actual DIMM replacement?
Once memory is offline, the memmap is stale and is no longer
trustworthy. It gets reinitialize during memory onlining -- so any
previous PG_hwpoison is overridden at least there. In some setups, we
even poison the whole memmap via page_init_poison() during memory offlining.
Apart from that, we should be freeing the memmap in all relevant cases
when removing memory. I remember there are a couple of corner cases, but
we don't really have to care about that.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-05-11 16:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 4:28 [RFC PATCH v1 0/4] mm, hwpoison: improve handling workload related to hugetlb and memory_hotplug Naoya Horiguchi
2022-04-27 4:28 ` [RFC PATCH v1 1/4] mm, hwpoison, hugetlb: introduce SUBPAGE_INDEX_HWPOISON to save raw error page Naoya Horiguchi
2022-04-27 7:11 ` Miaohe Lin
2022-04-27 13:03 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-28 3:14 ` Miaohe Lin
2022-05-12 22:31 ` Jane Chu
2022-05-12 22:49 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-27 4:28 ` [RFC PATCH v1 2/4] mm,hwpoison,hugetlb,memory_hotplug: hotremove memory section with hwpoisoned hugepage Naoya Horiguchi
2022-04-29 8:49 ` Miaohe Lin
2022-05-09 7:55 ` HORIGUCHI NAOYA(堀口 直也)
2022-05-09 8:57 ` Miaohe Lin
2022-04-27 4:28 ` [RFC PATCH v1 3/4] mm, hwpoison: add parameter unpoison to get_hwpoison_huge_page() Naoya Horiguchi
2022-04-27 4:28 ` [RFC PATCH v1 4/4] mm, memory_hotplug: fix inconsistent num_poisoned_pages on memory hotremove Naoya Horiguchi
2022-04-28 3:20 ` Miaohe Lin
2022-04-28 4:05 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-28 7:16 ` Miaohe Lin
2022-05-09 13:34 ` Naoya Horiguchi
2022-04-27 10:48 ` [RFC PATCH v1 0/4] mm, hwpoison: improve handling workload related to hugetlb and memory_hotplug David Hildenbrand
2022-04-27 12:20 ` Oscar Salvador
2022-04-27 12:20 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-28 8:44 ` David Hildenbrand
2022-05-09 7:29 ` HORIGUCHI NAOYA(堀口 直也)
2022-05-09 9:04 ` Miaohe Lin
2022-05-09 9:58 ` Oscar Salvador
2022-05-09 10:53 ` Miaohe Lin
2022-05-11 15:11 ` David Hildenbrand
2022-05-11 16:10 ` HORIGUCHI NAOYA(堀口 直也)
2022-05-11 16:22 ` David Hildenbrand [this message]
2022-05-12 3:04 ` Miaohe Lin
2022-05-12 6:35 ` HORIGUCHI NAOYA(堀口 直也)
2022-05-12 7:28 ` David Hildenbrand
2022-05-12 11:13 ` Miaohe Lin
2022-05-12 12:59 ` David Hildenbrand
2022-05-16 3:25 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6986a8dd-7211-fb4d-1d66-5b203cad1aab@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).