From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEB4C2B9F8 for ; Tue, 25 May 2021 08:01:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3DAD61401 for ; Tue, 25 May 2021 08:01:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3DAD61401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41CA96B006C; Tue, 25 May 2021 04:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CCDB6B006E; Tue, 25 May 2021 04:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21ECF6B0070; Tue, 25 May 2021 04:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id D93C06B006C for ; Tue, 25 May 2021 04:01:26 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 54853180ACF6C for ; Tue, 25 May 2021 08:01:26 +0000 (UTC) X-FDA: 78179008572.36.A1E0D77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id CF0D22BF3 for ; Tue, 25 May 2021 08:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621929685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjNqiqiXVGP3DJ5wl1DJMtCI9aa0pRIGSjankLipvdY=; b=RMsOsOAzS2fAFIQdgGKqcKem8h8DtM41/9CEz8tZMMvR83M6KJO8MzVVEogNsV8K+bUe0s 5IqNrxBIGoqxE2T7yP/8c1FMqiRdP8IJHtaU35qd6bpQI9Q3hzr1Zwr9lWk9BVNYtgHgDB DG0cR5nakyPXipU5iAzm9pMJDihF7Tk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-vU8Tx1c0PEK_Gb9d6CL3Xw-1; Tue, 25 May 2021 04:01:23 -0400 X-MC-Unique: vU8Tx1c0PEK_Gb9d6CL3Xw-1 Received: by mail-wr1-f72.google.com with SMTP id d12-20020adfc3cc0000b029011166e2f1a7so13173639wrg.19 for ; Tue, 25 May 2021 01:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=JjNqiqiXVGP3DJ5wl1DJMtCI9aa0pRIGSjankLipvdY=; b=VgfBSUOSIb4nD/zSEdVKeNrMLGtS2lVNIDeH0zsgbyID+wlzJf7DK1cxfIKxd1QCo5 H0Ay1mSKYm+VtNBJnK5RJsVAGPBaAhRRoNwXRbG6qaFwNkgRVR/WiCeJiOUZrz0R5W9y 0pdb9UB9RMHM7ZpPtCsBANH5bBpRIXvSIp962WIesH4H3T8509MkXg1ETK3CYqL2Pdc+ 1HCcLaNpX27BEJsU+bOfysnXE0jQt2/+MEnntsxSr49ShB0orsSFcg9Y7PK2MSDXjT0k uYOWIPTffeWBGXHWNPxlmoMcjU/HerqGHov0BSct0VTjH+qCRG+IRufhKIkeomj8WnyS sEIw== X-Gm-Message-State: AOAM533C7Odhlma2kw4D5gJPQGjwY3GWjsm2S76FHdBQVEnkCR7YMbnH L6G8nVubPAcnKptfiZC3DyxP83tJkpV1DF/qAWwnygjj3aioMciGDn3XzhKtT/HIEnXBcAebNW9 l6OH9madR1zI= X-Received: by 2002:a1c:4602:: with SMTP id t2mr2512683wma.173.1621929682746; Tue, 25 May 2021 01:01:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzikjnPJqkXBvfVZB+3A6fA3p1ARG+OLBPRXRyF31+3yFFLV71/sueRzeVrJeNPVTYKkRuaTQ== X-Received: by 2002:a1c:4602:: with SMTP id t2mr2512665wma.173.1621929682533; Tue, 25 May 2021 01:01:22 -0700 (PDT) Received: from ?IPv6:2003:d8:2f38:2400:62f4:c5fa:ba13:ac32? (p200300d82f38240062f4c5faba13ac32.dip0.t-ipconnect.de. [2003:d8:2f38:2400:62f4:c5fa:ba13:ac32]) by smtp.gmail.com with ESMTPSA id p10sm14153763wrr.58.2021.05.25.01.01.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 01:01:22 -0700 (PDT) Subject: Re: [PATCH 5/5] mm/page_alloc: improve memmap_pages and dma_reserve dbg msg To: Dong Aisheng , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, dongas86@gmail.com, Andrew Morton References: <20210517112044.233138-1-aisheng.dong@nxp.com> <20210517112044.233138-6-aisheng.dong@nxp.com> From: David Hildenbrand Organization: Red Hat Message-ID: <69b5a56c-e9a0-01e7-5fd5-78c6e656fa68@redhat.com> Date: Tue, 25 May 2021 10:01:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210517112044.233138-6-aisheng.dong@nxp.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CF0D22BF3 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RMsOsOAz; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: o9obfm9o4pp9h9b3uxbckjanex69p3jg X-HE-Tag: 1621929682-14963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.05.21 13:20, Dong Aisheng wrote: > Make debug message more accurately. > > Cc: Andrew Morton > Signed-off-by: Dong Aisheng > --- > mm/page_alloc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3100fcb08500..16f494352f58 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7263,14 +7263,15 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > pr_debug(" %s zone: %lu pages used for memmap\n", > zone_names[j], memmap_pages); > } else > - pr_warn(" %s zone: %lu pages exceeds freesize %lu\n", > + pr_warn(" %s zone: %lu memmap pages exceeds freesize %lu\n", > zone_names[j], memmap_pages, freesize); > } > > /* Account for reserved pages */ > if (j == 0 && freesize > dma_reserve) { > freesize -= dma_reserve; > - pr_debug(" %s zone: %lu pages reserved\n", zone_names[0], dma_reserve); > + pr_debug(" %s zone: %lu pages reserved for dma\n", > + zone_names[0], dma_reserve); ... which is not really correct I think. See the comment above set_dma_reserve(). It's called dma_reserve because it involves the first zone -- where many unfreeable allocations like the kernel image end up. Memory is not reserved for dma purposes ... and the zone name should be sufficient. -- Thanks, David / dhildenb