From: peter enderborg <peter.enderborg@sony.com>
To: Guilherme Piccoli <gpiccoli@canonical.com>,
David Rientjes <rientjes@google.com>
Cc: "Guilherme G. Piccoli" <kernel@gpiccoli.net>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Gavin Guo <gavin.guo@canonical.com>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl
Date: Mon, 18 May 2020 09:06:14 +0200 [thread overview]
Message-ID: <6bf5e178-f2c8-f453-9035-93e31995bb53@sony.com> (raw)
In-Reply-To: <CAHD1Q_zrQmUTRpdW3bZ0CRKuu2dKgueXUjqCNtC5oyZ67CGp2A@mail.gmail.com>
On 5/11/20 1:26 PM, Guilherme Piccoli wrote:
> On Sun, May 10, 2020 at 10:25 PM David Rientjes <rientjes@google.com> wrote:
>> [...]
>> The kernel log is not preferred for this (or drop_caches, really) because
>> the amount of info can causing important information to be lost. We don't
>> really gain anything by printing that someone manually triggered
>> compaction; they could just write to the kernel log themselves if they
>> really wanted to. The reverse is not true: we can't suppress your kernel
>> message with this patch.
>>
>> Instead, a statsfs-like approach could be used to indicate when this has
>> happened and there is no chance of losing events because it got scrolled
>> off the kernel log. It has the added benefit of not requiring the entire
>> log to be parsed for such events.
> OK, agreed! Let's forget the kernel log. So, do you think the way to
> go is the statsfs, not a zoneinfo stat, a per-node thing? I'm saying
> that because kernel mm subsystem statistics seem pretty.."comfortable"
> the way they are, in files like vmstat, zoneinfo, etc. Let me know
> your thoughts on this, if I could work on that or should wait statsfs.
> Thanks,
>
>
> Guilherme
I think a trace notification in compaction like kcompad_wake would be good.
next prev parent reply other threads:[~2020-05-18 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:59 [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl Guilherme G. Piccoli
2020-05-07 23:04 ` Andrew Morton
2020-05-08 2:14 ` Guilherme G. Piccoli
2020-05-08 18:31 ` David Rientjes
2020-05-08 19:01 ` Guilherme Piccoli
2020-05-11 1:24 ` David Rientjes
2020-05-11 11:26 ` Guilherme Piccoli
2020-05-18 7:06 ` peter enderborg [this message]
2020-05-18 12:14 ` Guilherme Piccoli
2020-05-18 12:54 ` Enderborg, Peter
2020-05-18 13:50 ` Guilherme Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf5e178-f2c8-f453-9035-93e31995bb53@sony.com \
--to=peter.enderborg@sony.com \
--cc=akpm@linux-foundation.org \
--cc=gavin.guo@canonical.com \
--cc=gpiccoli@canonical.com \
--cc=kernel@gpiccoli.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).