From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D199C4321E for ; Tue, 29 Nov 2022 14:07:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E70E86B0078; Tue, 29 Nov 2022 09:07:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E21096B007B; Tue, 29 Nov 2022 09:07:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC3516B007E; Tue, 29 Nov 2022 09:07:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BCADE6B0078 for ; Tue, 29 Nov 2022 09:07:05 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CC421AB58B for ; Tue, 29 Nov 2022 11:39:13 +0000 (UTC) X-FDA: 80186283786.15.0CAE103 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id B7B65140009 for ; Tue, 29 Nov 2022 11:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669721952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eRu/Hx0QeU09vI6dag4oeFynexJuKZWNYSe4MiEdyGs=; b=R92yCG3/a1b8ZjYFIxVjJnX3gLMI0YaDl9Bg6GePg+P9eSIfR4I2ZHOi47KkPpVzGbvkt/ r7OhHQSPaNt50Mp0ig9Jwzs6BLANiADC6iEBCnWUGfPLbrt8oQoQ2KQoCkmOdRI3uW8nT1 /wk79clqlBr3U9oscSCFKBF2Wd3dZ8Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-403-8GWmYONMOJG0pmG6hoqhBQ-1; Tue, 29 Nov 2022 06:39:11 -0500 X-MC-Unique: 8GWmYONMOJG0pmG6hoqhBQ-1 Received: by mail-wm1-f69.google.com with SMTP id bi19-20020a05600c3d9300b003cf9d6c4016so10065929wmb.8 for ; Tue, 29 Nov 2022 03:39:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eRu/Hx0QeU09vI6dag4oeFynexJuKZWNYSe4MiEdyGs=; b=6X+5lbE3MD/mJ11EmhdQvuIFZf9qZkHAse1coX43PTTmTC/1H425hxx4R3BMHXYGgj LXLyAxwCtc5hAblWj7Tv6/JcVlzIKRr8Bv/JDf0JlvEP0PIcqrDLwTfP3ZurrsnuAZT9 daVlZAbRV4ZM1RSHn8JnhlSQsjZXcspBPLWhraP9nQleYuqx+e9mgq9fiBEq64dTae1X RnJ67dg5qmB61wBx2aL4XQ93EUfYu1HKFzJzOnqs0tC9EFadiOLsMSlTjtDLbPKUiHTv Hv8i74Q/ZII9qt9PMhW0VCzSM9HX2s/vx8g9oYa1+jvAr0g3poRterYmyCXA9sUY5zfv 8oig== X-Gm-Message-State: ANoB5pmifsvImRatRpsSL0fHgH/hfpBAoGPZrzBO7YaTs16E0Q1GaKqb fq9SggslgUwuhO8tYExE/2xJ14kM3CGT85zCStioerJEnqyvMBptOOgS1WHvNx3caQlJ0/wDJSX NoaxO1P5woUw= X-Received: by 2002:a7b:ca45:0:b0:3c4:bda1:7c57 with SMTP id m5-20020a7bca45000000b003c4bda17c57mr44926299wml.6.1669721949900; Tue, 29 Nov 2022 03:39:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf6s03pDZ7+AzRjiuWChsKfmd6tu6WfpxK1aogO4cyP+8Olozy3bxlj+8EqBduo9KzTHvAm5sQ== X-Received: by 2002:a7b:ca45:0:b0:3c4:bda1:7c57 with SMTP id m5-20020a7bca45000000b003c4bda17c57mr44926175wml.6.1669721948661; Tue, 29 Nov 2022 03:39:08 -0800 (PST) Received: from [192.168.3.108] (p5b0c6623.dip0.t-ipconnect.de. [91.12.102.35]) by smtp.gmail.com with ESMTPSA id bg11-20020a05600c3c8b00b003d069fc7372sm1471927wmb.1.2022.11.29.03.39.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 03:39:08 -0800 (PST) Message-ID: <6d7f7775-5703-c27a-e57b-03aafb4de712@redhat.com> Date: Tue, 29 Nov 2022 12:39:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v9 1/8] mm: Introduce memfd_restricted system call to create restricted user memory To: "Kirill A. Shutemov" , Michael Roth Cc: Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, mhocko@suse.com, Muchun Song , wei.w.wang@intel.com References: <20221025151344.3784230-1-chao.p.peng@linux.intel.com> <20221025151344.3784230-2-chao.p.peng@linux.intel.com> <20221129000632.sz6pobh6p7teouiu@amd.com> <20221129112139.usp6dqhbih47qpjl@box.shutemov.name> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221129112139.usp6dqhbih47qpjl@box.shutemov.name> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R92yCG3/"; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669721953; a=rsa-sha256; cv=none; b=ji/60Xs7FPsy10JeJXUbnpteA+t3Z8BUexAyzfKOJK2lWGyq6fZ1IgPJn3WpqoIVFyQEBq hkXP5jeK/evoVBZMQAlyHJSTFmAykIadiRPjQ0XIsK2ESxenwgJ5LPdvQjYCCMCibvNOVn vezligr2oRw3HCqj6jEjcTMZ6UKwHYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669721953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eRu/Hx0QeU09vI6dag4oeFynexJuKZWNYSe4MiEdyGs=; b=gkmGv5rFIqHSeW0WgfAqlzNkKUBnrLhjMtWGGkMpdWd8tUFUPbUnZyJud6GnPlz8nG7gqT Frhk2e4Upd/m2m+HD790LvKIOnNqkuEjBhwM12FtJw+Q8Hv/fIGNHcBLtGl+kjl3w8QaCt 3B/+0XFmeUSecGCndgRtBc0i8HTTuI8= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R92yCG3/"; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Stat-Signature: djx1odw1q44ki4bb77brg6erwfkafurd X-Rspamd-Queue-Id: B7B65140009 X-Rspam-User: X-HE-Tag: 1669721952-407665 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.11.22 12:21, Kirill A. Shutemov wrote: > On Mon, Nov 28, 2022 at 06:06:32PM -0600, Michael Roth wrote: >> On Tue, Oct 25, 2022 at 11:13:37PM +0800, Chao Peng wrote: >>> From: "Kirill A. Shutemov" >>> >> >> >> >>> +static struct file *restrictedmem_file_create(struct file *memfd) >>> +{ >>> + struct restrictedmem_data *data; >>> + struct address_space *mapping; >>> + struct inode *inode; >>> + struct file *file; >>> + >>> + data = kzalloc(sizeof(*data), GFP_KERNEL); >>> + if (!data) >>> + return ERR_PTR(-ENOMEM); >>> + >>> + data->memfd = memfd; >>> + mutex_init(&data->lock); >>> + INIT_LIST_HEAD(&data->notifiers); >>> + >>> + inode = alloc_anon_inode(restrictedmem_mnt->mnt_sb); >>> + if (IS_ERR(inode)) { >>> + kfree(data); >>> + return ERR_CAST(inode); >>> + } >>> + >>> + inode->i_mode |= S_IFREG; >>> + inode->i_op = &restrictedmem_iops; >>> + inode->i_mapping->private_data = data; >>> + >>> + file = alloc_file_pseudo(inode, restrictedmem_mnt, >>> + "restrictedmem", O_RDWR, >>> + &restrictedmem_fops); >>> + if (IS_ERR(file)) { >>> + iput(inode); >>> + kfree(data); >>> + return ERR_CAST(file); >>> + } >>> + >>> + file->f_flags |= O_LARGEFILE; >>> + >>> + mapping = memfd->f_mapping; >>> + mapping_set_unevictable(mapping); >>> + mapping_set_gfp_mask(mapping, >>> + mapping_gfp_mask(mapping) & ~__GFP_MOVABLE); >> >> Is this supposed to prevent migration of pages being used for >> restrictedmem/shmem backend? > > Yes, my bad. I expected it to prevent migration, but it is not true. Maybe add a comment that these pages are not movable and we don't want to place them into movable pageblocks (including CMA and ZONE_MOVABLE). That's the primary purpose of the GFP mask here. -- Thanks, David / dhildenb